From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dave Marchevsky <davemarchevsky@fb.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 3/9] selftests/bpf: normalize all the rest SEC() uses
Date: Tue, 21 Sep 2021 16:12:34 -0700 [thread overview]
Message-ID: <CAEf4BzayZcSwLmOwD5W95xS6oPc9EDLU0X=rMhoWnU3XxsjApg@mail.gmail.com> (raw)
In-Reply-To: <6ccf9689-4171-970c-c412-c0ec9652a5c7@fb.com>
On Mon, Sep 20, 2021 at 10:41 PM Dave Marchevsky <davemarchevsky@fb.com> wrote:
>
> On 9/20/21 7:43 PM, Andrii Nakryiko wrote:
> > Normalize all the other non-conforming SEC() usages across all
> > selftests. This is in preparation for libbpf to start to enforce
> > stricter SEC() rules in libbpf 1.0 mode.
> >
> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> > ---
> > .../selftests/bpf/prog_tests/flow_dissector.c | 4 +--
> > .../selftests/bpf/prog_tests/sockopt_multi.c | 30 +++++++++----------
> > tools/testing/selftests/bpf/progs/bpf_flow.c | 3 +-
> > .../bpf/progs/cg_storage_multi_isolated.c | 4 +--
> > .../bpf/progs/cg_storage_multi_shared.c | 4 +--
> > .../selftests/bpf/progs/sockopt_multi.c | 5 ++--
> > .../selftests/bpf/progs/test_cgroup_link.c | 4 +--
> > .../bpf/progs/test_misc_tcp_hdr_options.c | 2 +-
> > .../selftests/bpf/progs/test_sk_lookup.c | 6 ++--
> > .../selftests/bpf/progs/test_sockmap_listen.c | 2 +-
> > .../progs/test_sockmap_skb_verdict_attach.c | 2 +-
> > .../bpf/progs/test_tcp_check_syncookie_kern.c | 2 +-
> > .../bpf/progs/test_tcp_hdr_options.c | 2 +-
> > .../selftests/bpf/test_tcp_check_syncookie.sh | 2 +-
>
> Ran test_tcp_check_syncookie.sh as CI suite doesn't - works.
>
Thanks for the due diligence!
> checkpatch has some line length complaints, otherwise LGTM
Keep in mind that checkpatch is not the absolute authority. I think it
also didn't get the memo about the 100 character line limit :) But
generally yes, we should try to keep it more or less happy.
>
> Acked-by: Dave Marchevsky <davemarchevsky@fb.com>
next prev parent reply other threads:[~2021-09-21 23:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 23:43 [PATCH v2 bpf-next 0/9] libbpf: stricter BPF program section name handling Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 1/9] selftests/bpf: normalize XDP section names in selftests Andrii Nakryiko
2021-09-21 4:55 ` Dave Marchevsky
2021-09-21 23:08 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 2/9] selftests/bpf: normalize SEC("classifier") usage Andrii Nakryiko
2021-09-21 5:20 ` Dave Marchevsky
2021-09-21 23:10 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 3/9] selftests/bpf: normalize all the rest SEC() uses Andrii Nakryiko
2021-09-21 5:41 ` Dave Marchevsky
2021-09-21 23:12 ` Andrii Nakryiko [this message]
2021-09-20 23:43 ` [PATCH v2 bpf-next 4/9] libbpf: refactor internal sec_def handling to enable pluggability Andrii Nakryiko
2021-09-22 0:42 ` Dave Marchevsky
2021-09-22 22:06 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 5/9] libbpf: reduce reliance of attach_fns on sec_def internals Andrii Nakryiko
2021-09-22 1:00 ` Dave Marchevsky
2021-09-20 23:43 ` [PATCH v2 bpf-next 6/9] libbpf: refactor ELF section handler definitions Andrii Nakryiko
2021-09-22 1:34 ` Dave Marchevsky
2021-09-22 21:54 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 7/9] libbpf: complete SEC() table unification for BPF_APROG_SEC/BPF_EAPROG_SEC Andrii Nakryiko
2021-09-22 1:42 ` Dave Marchevsky
2021-09-22 21:55 ` Andrii Nakryiko
2021-09-22 22:12 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 8/9] libbpf: add opt-in strict BPF program section name handling logic Andrii Nakryiko
2021-09-22 1:53 ` Dave Marchevsky
2021-09-22 21:57 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 9/9] selftests/bpf: switch sk_lookup selftests to strict SEC("sk_lookup") use Andrii Nakryiko
2021-09-22 2:37 ` Dave Marchevsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzayZcSwLmOwD5W95xS6oPc9EDLU0X=rMhoWnU3XxsjApg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).