From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Slava Bacherikov <slava@bacher09.org>
Cc: Andrii Nakryiko <andriin@fb.com>,
Kees Cook <keescook@chromium.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Jann Horn <jannh@google.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Liu Yiding <liuyd.fnst@cn.fujitsu.com>,
kpsingh@google.com
Subject: Re: [PATCH v4 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF
Date: Thu, 2 Apr 2020 12:31:36 -0700 [thread overview]
Message-ID: <CAEf4Bzb2mgDPcdNGWnBgoqsuWYqDiv39U2irn4iCp=7B3kx1nA@mail.gmail.com> (raw)
In-Reply-To: <f43f4e17-f496-9ee1-7d89-c8f742720a5f@bacher09.org>
On Thu, Apr 2, 2020 at 8:40 AM Slava Bacherikov <slava@bacher09.org> wrote:
>
>
>
> 02.04.2020 18:33, Slava Bacherikov wrote:
> > + depends on DEBUG_INFO || COMPILE_TEST
>
> Andrii are you fine by this ?
I think it needs a good comment explaining this weirdness, at least.
As I said, if there is no DEBUG_INFO, there is not point in doing
DWARF-to-BTF conversion, even more -- it actually might fail, I
haven't checked what pahole does in that case. So I'd rather drop
GCC_PLUGIN_RANDSTRUCT is that's the issue here. DEBUG_INFO_SPLIT and
DEBUG_INFO_REDUCED look good.
next prev parent reply other threads:[~2020-04-02 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 21:55 [PATCH v2 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF Slava Bacherikov
2020-03-31 22:40 ` KP Singh
2020-04-01 0:03 ` Andrii Nakryiko
2020-04-01 7:34 ` Kees Cook
2020-04-01 14:20 ` [PATCH v3 " Slava Bacherikov
2020-04-01 14:37 ` Slava Bacherikov
2020-04-01 17:46 ` Andrii Nakryiko
2020-04-01 18:24 ` Slava Bacherikov
2020-04-01 15:49 ` Kees Cook
2020-04-02 15:33 ` [PATCH v4 " Slava Bacherikov
2020-04-02 15:40 ` Slava Bacherikov
2020-04-02 19:31 ` Andrii Nakryiko [this message]
2020-04-02 20:34 ` Kees Cook
2020-04-02 20:38 ` Slava Bacherikov
2020-04-02 20:41 ` [PATCH v5 " Slava Bacherikov
2020-04-02 21:02 ` Andrii Nakryiko
2020-04-02 22:49 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4Bzb2mgDPcdNGWnBgoqsuWYqDiv39U2irn4iCp=7B3kx1nA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kpsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyd.fnst@cn.fujitsu.com \
--cc=slava@bacher09.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).