From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
BPF Mailing List <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: capable_bpf_net_admin()
Date: Thu, 18 Jun 2020 12:21:58 -0700 [thread overview]
Message-ID: <CAHo-OoyU5OHQuqpTEo-uAQcwcLpzkXezFY6Re-Hv6jGM9aSFSA@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLXgnqSM16=a3O1NyqYae1n_rMyw4_hcx5APm9s-h3TBtQ@mail.gmail.com>
Ok so I think
> + if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN))
> + return -EPERM;
should be
> + if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN))
> + return -EPERM;
and presumably similar change just below that for perfmon.
next prev parent reply other threads:[~2020-06-18 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 6:43 capable_bpf_net_admin() Maciej Żenczykowski
2020-06-18 7:01 ` capable_bpf_net_admin() Alexei Starovoitov
2020-06-18 10:19 ` capable_bpf_net_admin() Maciej Żenczykowski
2020-06-18 19:03 ` capable_bpf_net_admin() John Stultz
2020-06-18 19:21 ` Maciej Żenczykowski [this message]
2020-06-18 19:59 ` [PATCH] restore behaviour of CAP_SYS_ADMIN allowing the loading of net bpf program Maciej Żenczykowski
2020-06-18 21:02 ` Alexei Starovoitov
2020-06-20 21:26 ` [PATCH bpf v2] restore behaviour of CAP_SYS_ADMIN allowing the loading of networking bpf programs Maciej Żenczykowski
2020-06-22 19:44 ` John Stultz
2020-06-24 0:54 ` Alexei Starovoitov
2020-07-06 20:11 ` John Stultz
2020-07-06 20:15 ` Daniel Borkmann
2020-07-06 20:36 ` John Stultz
2020-06-20 1:59 ` capable_bpf_net_admin() John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHo-OoyU5OHQuqpTEo-uAQcwcLpzkXezFY6Re-Hv6jGM9aSFSA@mail.gmail.com \
--to=zenczykowski@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=amit.pundir@linaro.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.stultz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).