From: John Stultz <john.stultz@linaro.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Maciej Żenczykowski" <zenczykowski@gmail.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"BPF Mailing List" <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH bpf v2] restore behaviour of CAP_SYS_ADMIN allowing the loading of networking bpf programs
Date: Mon, 6 Jul 2020 13:11:42 -0700 [thread overview]
Message-ID: <CALAqxLVfxSj961C5muL5iAYjB5p_JTx7T6E7zQ7nsfQGC-exFA@mail.gmail.com> (raw)
In-Reply-To: <CAADnVQJOpsQhT0oY5GZikf00MT1=pR3vpCZkn+Z4hp2_duUFSQ@mail.gmail.com>
On Tue, Jun 23, 2020 at 5:54 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
> On Mon, Jun 22, 2020 at 12:44 PM John Stultz <john.stultz@linaro.org> wrote:
> > On Sat, Jun 20, 2020 at 2:26 PM Maciej Żenczykowski
> > <zenczykowski@gmail.com> wrote:
> > > From: Maciej Żenczykowski <maze@google.com>
> > >
> > > This is a fix for a regression introduced in 5.8-rc1 by:
> > > commit 2c78ee898d8f10ae6fb2fa23a3fbaec96b1b7366
> > > 'bpf: Implement CAP_BPF'
> > >
> > > Before the above commit it was possible to load network bpf programs
> > > with just the CAP_SYS_ADMIN privilege.
> > >
> > > The Android bpfloader happens to run in such a configuration (it has
> > > SYS_ADMIN but not NET_ADMIN) and creates maps and loads bpf programs
> > > for later use by Android's netd (which has NET_ADMIN but not SYS_ADMIN).
> > >
> > > Cc: Alexei Starovoitov <ast@kernel.org>
> > > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > > Reported-by: John Stultz <john.stultz@linaro.org>
> > > Fixes: 2c78ee898d8f ("bpf: Implement CAP_BPF")
> > > Signed-off-by: Maciej Żenczykowski <maze@google.com>
> >
> > Thanks so much for helping narrow this regression down and submitting this fix!
> > It's much appreciated!
> >
> > Tested-by: John Stultz <john.stultz@linaro.org>
>
> Applied to bpf tree. Thanks
Hey all,
Just wanted to follow up on this as I've not seen the regression fix
land in 5.8-rc4 yet? Is it still pending, or did it fall through a
gap?
thanks
-john
next prev parent reply other threads:[~2020-07-06 20:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 6:43 capable_bpf_net_admin() Maciej Żenczykowski
2020-06-18 7:01 ` capable_bpf_net_admin() Alexei Starovoitov
2020-06-18 10:19 ` capable_bpf_net_admin() Maciej Żenczykowski
2020-06-18 19:03 ` capable_bpf_net_admin() John Stultz
2020-06-18 19:21 ` capable_bpf_net_admin() Maciej Żenczykowski
2020-06-18 19:59 ` [PATCH] restore behaviour of CAP_SYS_ADMIN allowing the loading of net bpf program Maciej Żenczykowski
2020-06-18 21:02 ` Alexei Starovoitov
2020-06-20 21:26 ` [PATCH bpf v2] restore behaviour of CAP_SYS_ADMIN allowing the loading of networking bpf programs Maciej Żenczykowski
2020-06-22 19:44 ` John Stultz
2020-06-24 0:54 ` Alexei Starovoitov
2020-07-06 20:11 ` John Stultz [this message]
2020-07-06 20:15 ` Daniel Borkmann
2020-07-06 20:36 ` John Stultz
2020-06-20 1:59 ` capable_bpf_net_admin() John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLVfxSj961C5muL5iAYjB5p_JTx7T6E7zQ7nsfQGC-exFA@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).