* [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h
@ 2020-09-28 8:23 Ciara Loftus
2020-09-28 11:33 ` Magnus Karlsson
2020-09-29 18:30 ` patchwork-bot+bpf
0 siblings, 2 replies; 3+ messages in thread
From: Ciara Loftus @ 2020-09-28 8:23 UTC (permalink / raw)
To: bpf; +Cc: magnus.karlsson, Ciara Loftus
After 'peeking' the ring, the consumer, not the producer, reads the data.
Fix this mistake in the comments.
Fixes: 15d8c9162ced ("xsk: Add function naming comments and reorder functions")
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
net/xdp/xsk_queue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
index bf42cfd74b89..a0bb2f722b3f 100644
--- a/net/xdp/xsk_queue.h
+++ b/net/xdp/xsk_queue.h
@@ -96,7 +96,7 @@ struct xsk_queue {
* seen and read by the consumer.
*
* The consumer peeks into the ring to see if the producer has written
- * any new entries. If so, the producer can then read these entries
+ * any new entries. If so, the consumer can then read these entries
* and when it is done reading them release them back to the producer
* so that the producer can use these slots to fill in new entries.
*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h
2020-09-28 8:23 [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h Ciara Loftus
@ 2020-09-28 11:33 ` Magnus Karlsson
2020-09-29 18:30 ` patchwork-bot+bpf
1 sibling, 0 replies; 3+ messages in thread
From: Magnus Karlsson @ 2020-09-28 11:33 UTC (permalink / raw)
To: Ciara Loftus; +Cc: bpf, Karlsson, Magnus
On Mon, Sep 28, 2020 at 10:49 AM Ciara Loftus <ciara.loftus@intel.com> wrote:
>
> After 'peeking' the ring, the consumer, not the producer, reads the data.
> Fix this mistake in the comments.
>
> Fixes: 15d8c9162ced ("xsk: Add function naming comments and reorder functions")
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> net/xdp/xsk_queue.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
> index bf42cfd74b89..a0bb2f722b3f 100644
> --- a/net/xdp/xsk_queue.h
> +++ b/net/xdp/xsk_queue.h
> @@ -96,7 +96,7 @@ struct xsk_queue {
> * seen and read by the consumer.
> *
> * The consumer peeks into the ring to see if the producer has written
> - * any new entries. If so, the producer can then read these entries
> + * any new entries. If so, the consumer can then read these entries
> * and when it is done reading them release them back to the producer
> * so that the producer can use these slots to fill in new entries.
> *
> --
> 2.17.1
>
Thank you Ciara.
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h
2020-09-28 8:23 [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h Ciara Loftus
2020-09-28 11:33 ` Magnus Karlsson
@ 2020-09-29 18:30 ` patchwork-bot+bpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bpf @ 2020-09-29 18:30 UTC (permalink / raw)
To: Ciara Loftus; +Cc: bpf
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Mon, 28 Sep 2020 08:23:44 +0000 you wrote:
> After 'peeking' the ring, the consumer, not the producer, reads the data.
> Fix this mistake in the comments.
>
> Fixes: 15d8c9162ced ("xsk: Add function naming comments and reorder functions")
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> net/xdp/xsk_queue.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- xsk: fix a documentation mistake in xsk_queue.h
https://git.kernel.org/bpf/bpf-next/c/f1fc8ece6c07
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-29 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 8:23 [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h Ciara Loftus
2020-09-28 11:33 ` Magnus Karlsson
2020-09-29 18:30 ` patchwork-bot+bpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).