bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments
@ 2020-04-21 23:29 Tobias Klauser
  2020-04-22  5:37 ` Magnus Karlsson
  2020-04-26 16:34 ` Alexei Starovoitov
  0 siblings, 2 replies; 3+ messages in thread
From: Tobias Klauser @ 2020-04-21 23:29 UTC (permalink / raw)
  To: Björn Töpel, Magnus Karlsson; +Cc: bpf, netdev

s/backpreassure/backpressure/

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 net/xdp/xsk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
index c350108aa38d..f6e6609f70a3 100644
--- a/net/xdp/xsk.c
+++ b/net/xdp/xsk.c
@@ -322,7 +322,7 @@ bool xsk_umem_consume_tx(struct xdp_umem *umem, struct xdp_desc *desc)
 		if (!xskq_cons_peek_desc(xs->tx, desc, umem))
 			continue;
 
-		/* This is the backpreassure mechanism for the Tx path.
+		/* This is the backpressure mechanism for the Tx path.
 		 * Reserve space in the completion queue and only proceed
 		 * if there is space in it. This avoids having to implement
 		 * any buffering in the Tx path.
@@ -406,7 +406,7 @@ static int xsk_generic_xmit(struct sock *sk)
 		addr = desc.addr;
 		buffer = xdp_umem_get_data(xs->umem, addr);
 		err = skb_store_bits(skb, 0, buffer, len);
-		/* This is the backpreassure mechanism for the Tx path.
+		/* This is the backpressure mechanism for the Tx path.
 		 * Reserve space in the completion queue and only proceed
 		 * if there is space in it. This avoids having to implement
 		 * any buffering in the Tx path.
-- 
2.26.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments
  2020-04-21 23:29 [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments Tobias Klauser
@ 2020-04-22  5:37 ` Magnus Karlsson
  2020-04-26 16:34 ` Alexei Starovoitov
  1 sibling, 0 replies; 3+ messages in thread
From: Magnus Karlsson @ 2020-04-22  5:37 UTC (permalink / raw)
  To: Tobias Klauser
  Cc: Björn Töpel, Magnus Karlsson, bpf, Network Development

On Wed, Apr 22, 2020 at 1:30 AM Tobias Klauser <tklauser@distanz.ch> wrote:
>
> s/backpreassure/backpressure/

Thanks Tobias.

Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>

> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  net/xdp/xsk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index c350108aa38d..f6e6609f70a3 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -322,7 +322,7 @@ bool xsk_umem_consume_tx(struct xdp_umem *umem, struct xdp_desc *desc)
>                 if (!xskq_cons_peek_desc(xs->tx, desc, umem))
>                         continue;
>
> -               /* This is the backpreassure mechanism for the Tx path.
> +               /* This is the backpressure mechanism for the Tx path.
>                  * Reserve space in the completion queue and only proceed
>                  * if there is space in it. This avoids having to implement
>                  * any buffering in the Tx path.
> @@ -406,7 +406,7 @@ static int xsk_generic_xmit(struct sock *sk)
>                 addr = desc.addr;
>                 buffer = xdp_umem_get_data(xs->umem, addr);
>                 err = skb_store_bits(skb, 0, buffer, len);
> -               /* This is the backpreassure mechanism for the Tx path.
> +               /* This is the backpressure mechanism for the Tx path.
>                  * Reserve space in the completion queue and only proceed
>                  * if there is space in it. This avoids having to implement
>                  * any buffering in the Tx path.
> --
> 2.26.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments
  2020-04-21 23:29 [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments Tobias Klauser
  2020-04-22  5:37 ` Magnus Karlsson
@ 2020-04-26 16:34 ` Alexei Starovoitov
  1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-04-26 16:34 UTC (permalink / raw)
  To: Tobias Klauser
  Cc: Björn Töpel, Magnus Karlsson, bpf, Network Development

On Tue, Apr 21, 2020 at 4:30 PM Tobias Klauser <tklauser@distanz.ch> wrote:
>
> s/backpreassure/backpressure/
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Applied. Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-26 16:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 23:29 [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments Tobias Klauser
2020-04-22  5:37 ` Magnus Karlsson
2020-04-26 16:34 ` Alexei Starovoitov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).