From: Yafang Shao <laoar.shao@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH bpf-next v3 00/27] bpf: RLIMIT_MEMLOCK cleanups
Date: Wed, 6 Apr 2022 22:32:02 +0800 [thread overview]
Message-ID: <CALOAHbB2tsrcx5LZbrxJ8LZQW7dSCrD7ErKx4HRXj2i29Pq9Ew@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzaEF013kPkV=gkN6fw7e9hO_h0MLWuDbx4Qd68ZCr=5pw@mail.gmail.com>
On Wed, Apr 6, 2022 at 4:53 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Apr 5, 2022 at 6:09 AM Yafang Shao <laoar.shao@gmail.com> wrote:
> >
> > We have switched to memcg based memory accouting and thus the rlimit is
> > not needed any more. LIBBPF_STRICT_AUTO_RLIMIT_MEMLOCK was introduced in
> > libbpf for backward compatibility, so we can use it instead now.
> >
> > This patchset cleanups the usage of RLIMIT_MEMLOCK in tools/bpf/,
> > tools/testing/selftests/bpf and samples/bpf. The file
> > tools/testing/selftests/bpf/bpf_rlimit.h is removed. The included header
> > sys/resource.h is removed from many files as it is useless in these files.
> >
> > - v3: Get rid of bpf_rlimit.h and fix some typos (Andrii)
> > - v2: Use libbpf_set_strict_mode instead. (Andrii)
> > - v1: https://lore.kernel.org/bpf/20220320060815.7716-2-laoar.shao@gmail.com/
> >
> > Yafang Shao (27):
> > bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in
> > xdping
> > bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in
> > xdpxceiver
> > bpf: selftests: No need to include bpf_rlimit.h in test_tcpnotify_user
> > bpf: selftests: No need to include bpf_rlimit.h in flow_dissector_load
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > get_cgroup_id_user
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > test_cgroup_storage
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > get_cgroup_id_user
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lpm_map
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lru_map
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > test_skb_cgroup_id_user
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock_addr
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sockmap
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sysctl
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_tag
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > test_tcp_check_syncookie_user
> > bpf: selftests: Set libbpf 1.0 API mode explicitly in
> > test_verifier_log
> > bpf: samples: Set libbpf 1.0 API mode explicitly in hbm
> > bpf: selftests: Get rid of bpf_rlimit.h
> > bpf: selftests: No need to include sys/resource.h in some files
> > bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in
> > xdpsock_user
> > bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in
> > xsk_fwd
> > bpf: samples: No need to include sys/resource.h in many files
> > bpf: bpftool: Remove useless return value of libbpf_set_strict_mode
> > bpf: bpftool: Set LIBBPF_STRICT_AUTO_RLIMIT_MEMLOCK for legacy libbpf
> > bpf: bpftool: remove RLIMIT_MEMLOCK
> > bpf: runqslower: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK
> >
>
> Hey Yafang, thanks for the clean up! It looks good, but please make it
> a bit more manageable in terms of number of patches. There is no need
> to have so many tiny patches. Can you squash together all the
> samples/bpf changes into one patch, all the selftests/bpf changes into
> another, bpftool ones still can be just one patch. runqslower makes
> sense to keep separate. Please also use customary subject prefixes for
> those: "selftests/bpf: ", "bpftool: ", "samples/bpf: ". For runqslower
> probably "tools/runqslower: " would be ok as well.
>
Thanks for your suggestion. I will change it.
--
Thanks
Yafang
prev parent reply other threads:[~2022-04-06 17:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:08 [PATCH bpf-next v3 00/27] bpf: RLIMIT_MEMLOCK cleanups Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 01/27] bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in xdping Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 02/27] bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in xdpxceiver Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 03/27] bpf: selftests: No need to include bpf_rlimit.h in test_tcpnotify_user Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 04/27] bpf: selftests: No need to include bpf_rlimit.h in flow_dissector_load Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 05/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in get_cgroup_id_user Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 06/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_cgroup_storage Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 07/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in get_cgroup_id_user Yafang Shao
2022-04-05 20:46 ` Jeff Johnson
2022-04-06 14:33 ` Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 08/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lpm_map Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 09/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lru_map Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 10/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_skb_cgroup_id_user Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 11/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock_addr Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 12/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 13/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sockmap Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 14/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sysctl Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 15/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_tag Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 16/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_tcp_check_syncookie_user Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 17/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in test_verifier_log Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 18/27] bpf: samples: Set libbpf 1.0 API mode explicitly in hbm Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 19/27] bpf: selftests: Get rid of bpf_rlimit.h Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 20/27] bpf: selftests: No need to include sys/resource.h in some files Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 21/27] bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in xdpsock_user Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 22/27] bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in xsk_fwd Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 23/27] bpf: samples: No need to include sys/resource.h in many files Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 24/27] bpf: bpftool: Remove useless return value of libbpf_set_strict_mode Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 25/27] bpf: bpftool: Set LIBBPF_STRICT_AUTO_RLIMIT_MEMLOCK for legacy libbpf Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 26/27] bpf: bpftool: remove RLIMIT_MEMLOCK Yafang Shao
2022-04-05 13:08 ` [PATCH bpf-next v3 27/27] bpf: runqslower: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK Yafang Shao
2022-04-05 20:52 ` [PATCH bpf-next v3 00/27] bpf: RLIMIT_MEMLOCK cleanups Andrii Nakryiko
2022-04-06 14:32 ` Yafang Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbB2tsrcx5LZbrxJ8LZQW7dSCrD7ErKx4HRXj2i29Pq9Ew@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).