bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: "sunyucong@gmail.com" <sunyucong@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Jiang Wang <jiang.wang@bytedance.com>,
	Cong Wang <cong.wang@bytedance.com>,
	Yucong Sun <fallentree@fb.com>,
	Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: reduce more flakyness in sockmap_listen
Date: Wed, 15 Sep 2021 09:54:28 -0700	[thread overview]
Message-ID: <CAM_iQpWpP5SfLyt_aNGAD3hnmC7MdJjrKnxRj6MphwLpMX4mCQ@mail.gmail.com> (raw)
In-Reply-To: <CAJygYd2uJNEvX4MWruAZ2a3uJ2HJbnoCmMkuS2fFY59S6x=Sww@mail.gmail.com>

On Mon, Sep 6, 2021 at 7:24 PM sunyucong@gmail.com <sunyucong@gmail.com> wrote:
>
> Hi Cong, sorry for the back and forth. Let me clarify the problem here:
>
>  If you apply following patch on bpf-next, running ./test_progs -t
> sockmap_listen and you will observe full timeout on all the select()
> calls for these read() , it looks like select() won't work on
> redirected socket, which I think is a issue, but would love to hear
> what you think.

Ah, I see, we do call the original ->sk_data_ready() when redirecting
the packet, via sk_psock_data_ready(), however it looks like those
->poll() still reads the original queues (e.g. ->sk_receive_queue) but
misses the sockmap queues (psock->ingress_skb).

Let me think about the right fix of this.

Thanks a lot for the details!

      parent reply	other threads:[~2021-09-15 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 18:47 [PATCH bpf-next] selftests/bpf: reduce more flakyness in sockmap_listen Yucong Sun
2021-08-26  1:04 ` Alexei Starovoitov
2021-08-26  2:37   ` sunyucong
2021-08-26 18:18     ` sunyucong
2021-08-26 19:07       ` Alexei Starovoitov
2021-08-26 19:23         ` sunyucong
2021-08-26 21:05           ` Alexei Starovoitov
2021-08-26 21:07             ` sunyucong
2021-08-31 19:33         ` Cong Wang
2021-09-02  1:33           ` Cong Wang
2021-09-02  3:34             ` sunyucong
2021-09-03 23:44               ` Cong Wang
2021-09-07  2:24                 ` sunyucong
2021-09-15 14:13                   ` sunyucong
2021-09-15 16:54                   ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpWpP5SfLyt_aNGAD3hnmC7MdJjrKnxRj6MphwLpMX4mCQ@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=fallentree@fb.com \
    --cc=jiang.wang@bytedance.com \
    --cc=sunyucong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).