From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: bpf <bpf@vger.kernel.org>
Cc: andrii@kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 0/3] bpf/selftests: page size fixes
Date: Fri, 26 Mar 2021 14:21:38 +0200 [thread overview]
Message-ID: <CANoWsw=ForMxYDGY=JpRherVshXKm9+Fjwcc_xvEVF=gpxcn0A@mail.gmail.com> (raw)
In-Reply-To: <20210326114658.210034-1-yauheni.kaliuta@redhat.com>
Oops, one patch is missing.
Will recend
On Fri, Mar 26, 2021 at 1:47 PM Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
>
> A set of fixes for selftests to make them working on systems with PAGE_SIZE > 4K
>
> 2 questions left:
>
> - about `nit: if (!ASSERT_OK(err, "setsockopt_attach"))`. I left
> CHECK() for now since otherwise it has too many negations. But
> should I anyway use ASSERT?
>
> - https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/prog_tests/mmap.c#L41
> and below -- it works now as is, but should be switched also to page_size?
>
> Yauheni Kaliuta (3):
> selftests/bpf: test_progs/sockopt_sk: pass page size from userspace
> bpf: selftests: test_progs/sockopt_sk: remove version
> selftests/bpf: ringbuf, mmap: bump up page size to 64K
>
> tools/testing/selftests/bpf/prog_tests/ringbuf.c | 9 +++++++--
> tools/testing/selftests/bpf/prog_tests/sockopt_sk.c | 2 ++
> tools/testing/selftests/bpf/progs/map_ptr_kern.c | 9 +++++++--
> tools/testing/selftests/bpf/progs/sockopt_sk.c | 11 ++++-------
> tools/testing/selftests/bpf/progs/test_mmap.c | 10 ++++++++--
> tools/testing/selftests/bpf/progs/test_ringbuf.c | 8 +++++++-
> .../testing/selftests/bpf/progs/test_ringbuf_multi.c | 7 ++++++-
> 7 files changed, 41 insertions(+), 15 deletions(-)
>
> --
> 2.29.2
>
--
WBR, Yauheni
next prev parent reply other threads:[~2021-03-26 12:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 11:46 [PATCH 0/3] bpf/selftests: page size fixes Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 1/3] selftests/bpf: test_progs/sockopt_sk: pass page size from userspace Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 2/3] bpf: selftests: test_progs/sockopt_sk: remove version Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 3/3] selftests/bpf: ringbuf, mmap: bump up page size to 64K Yauheni Kaliuta
2021-03-26 12:21 ` Yauheni Kaliuta [this message]
2021-03-26 12:24 ` [PATCH v2 0/4] bpf/selftests: page size fixes Yauheni Kaliuta
2021-03-28 5:05 ` Andrii Nakryiko
2021-03-28 17:06 ` Yauheni Kaliuta
2021-03-28 18:30 ` Andrii Nakryiko
2021-03-26 12:24 ` [PATCH v2 1/4] selftests/bpf: test_progs/sockopt_sk: Convert to use BPF skeleton Yauheni Kaliuta
2021-03-26 12:24 ` [PATCH v2 2/4] selftests/bpf: test_progs/sockopt_sk: pass page size from userspace Yauheni Kaliuta
2021-03-28 5:00 ` Andrii Nakryiko
2021-03-26 12:24 ` [PATCH v2 3/4] bpf: selftests: test_progs/sockopt_sk: remove version Yauheni Kaliuta
2021-03-26 12:24 ` [PATCH v2 4/4] selftests/bpf: ringbuf, mmap: bump up page size to 64K Yauheni Kaliuta
2021-03-28 5:03 ` Andrii Nakryiko
2021-03-29 15:19 ` Yauheni Kaliuta
2021-03-31 5:49 ` Andrii Nakryiko
2021-03-31 6:11 ` Yauheni Kaliuta
2021-03-31 6:25 ` Andrii Nakryiko
2021-03-31 16:43 ` Yauheni Kaliuta
2021-03-28 4:58 ` [PATCH v2 1/4] selftests/bpf: test_progs/sockopt_sk: Convert to use BPF skeleton Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANoWsw=ForMxYDGY=JpRherVshXKm9+Fjwcc_xvEVF=gpxcn0A@mail.gmail.com' \
--to=yauheni.kaliuta@redhat.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).