From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v2 4/4] selftests/bpf: ringbuf, mmap: bump up page size to 64K
Date: Mon, 29 Mar 2021 18:19:29 +0300 [thread overview]
Message-ID: <CANoWswmy1bHbU8hBkF2DiyW3oHr1wDxZU3CsyDHOJ+-fe5DBTA@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZowiRKeLGw7JikKuMs+dy-=OTMbUb3eFJCq03Br7P30g@mail.gmail.com>
On Sun, Mar 28, 2021 at 8:03 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
[...]
> >
> > struct {
> > __uint(type, BPF_MAP_TYPE_ARRAY);
> > - __uint(max_entries, 4096);
> > + __uint(max_entries, PAGE_SIZE);
>
>
> so you can set map size at runtime before bpf_object__load (or
> skeleton's load) with bpf_map__set_max_entries. That way you don't
> have to do any assumptions. Just omit max_entries in BPF source code,
> and always set it in userspace.
Will it work for ringbuf_multi? If I just set max_entries for ringbuf1
and ringbuf2 that way, it gives me
libbpf: map 'ringbuf_arr': failed to create inner map: -22
libbpf: map 'ringbuf_arr': failed to create: Invalid argument(-22)
libbpf: failed to load object 'test_ringbuf_multi'
libbpf: failed to load BPF skeleton 'test_ringbuf_multi': -22
test_ringbuf_multi:FAIL:skel_load skeleton load failed
next prev parent reply other threads:[~2021-03-29 15:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 11:46 [PATCH 0/3] bpf/selftests: page size fixes Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 1/3] selftests/bpf: test_progs/sockopt_sk: pass page size from userspace Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 2/3] bpf: selftests: test_progs/sockopt_sk: remove version Yauheni Kaliuta
2021-03-26 11:47 ` [PATCH 3/3] selftests/bpf: ringbuf, mmap: bump up page size to 64K Yauheni Kaliuta
2021-03-26 12:21 ` [PATCH 0/3] bpf/selftests: page size fixes Yauheni Kaliuta
2021-03-26 12:24 ` [PATCH v2 0/4] " Yauheni Kaliuta
2021-03-28 5:05 ` Andrii Nakryiko
2021-03-28 17:06 ` Yauheni Kaliuta
2021-03-28 18:30 ` Andrii Nakryiko
2021-03-26 12:24 ` [PATCH v2 1/4] selftests/bpf: test_progs/sockopt_sk: Convert to use BPF skeleton Yauheni Kaliuta
2021-03-26 12:24 ` [PATCH v2 2/4] selftests/bpf: test_progs/sockopt_sk: pass page size from userspace Yauheni Kaliuta
2021-03-28 5:00 ` Andrii Nakryiko
2021-03-26 12:24 ` [PATCH v2 3/4] bpf: selftests: test_progs/sockopt_sk: remove version Yauheni Kaliuta
2021-03-26 12:24 ` [PATCH v2 4/4] selftests/bpf: ringbuf, mmap: bump up page size to 64K Yauheni Kaliuta
2021-03-28 5:03 ` Andrii Nakryiko
2021-03-29 15:19 ` Yauheni Kaliuta [this message]
2021-03-31 5:49 ` Andrii Nakryiko
2021-03-31 6:11 ` Yauheni Kaliuta
2021-03-31 6:25 ` Andrii Nakryiko
2021-03-31 16:43 ` Yauheni Kaliuta
2021-03-28 4:58 ` [PATCH v2 1/4] selftests/bpf: test_progs/sockopt_sk: Convert to use BPF skeleton Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANoWswmy1bHbU8hBkF2DiyW3oHr1wDxZU3CsyDHOJ+-fe5DBTA@mail.gmail.com \
--to=yauheni.kaliuta@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).