* [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id
@ 2020-11-10 11:50 xiakaixu1987
2020-11-10 13:02 ` Denis Kirjanov
2020-11-10 18:41 ` Andrii Nakryiko
0 siblings, 2 replies; 4+ messages in thread
From: xiakaixu1987 @ 2020-11-10 11:50 UTC (permalink / raw)
To: ast, daniel, kafai, songliubraving, yhs, andrii, john.fastabend, kpsingh
Cc: netdev, bpf, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The unsigned variable datasec_id is assigned a return value from the call
to check_pseudo_btf_id(), which may return negative error code.
Fixes coccicheck warning:
./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 6200519582a6..e9d8d4309bb4 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -9572,7 +9572,7 @@ static int check_pseudo_btf_id(struct bpf_verifier_env *env,
struct bpf_insn *insn,
struct bpf_insn_aux_data *aux)
{
- u32 datasec_id, type, id = insn->imm;
+ s32 datasec_id, type, id = insn->imm;
const struct btf_var_secinfo *vsi;
const struct btf_type *datasec;
const struct btf_type *t;
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id
2020-11-10 11:50 [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id xiakaixu1987
@ 2020-11-10 13:02 ` Denis Kirjanov
2020-11-10 18:42 ` Andrii Nakryiko
2020-11-10 18:41 ` Andrii Nakryiko
1 sibling, 1 reply; 4+ messages in thread
From: Denis Kirjanov @ 2020-11-10 13:02 UTC (permalink / raw)
To: xiakaixu1987
Cc: ast, daniel, kafai, songliubraving, yhs, andrii, john.fastabend,
kpsingh, netdev, bpf, linux-kernel, Kaixu Xia
On 11/10/20, xiakaixu1987@gmail.com <xiakaixu1987@gmail.com> wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The unsigned variable datasec_id is assigned a return value from the call
> to check_pseudo_btf_id(), which may return negative error code.
>
> Fixes coccicheck warning:
>
> ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared
> with zero: datasec_id > 0
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> kernel/bpf/verifier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 6200519582a6..e9d8d4309bb4 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -9572,7 +9572,7 @@ static int check_pseudo_btf_id(struct bpf_verifier_env
> *env,
> struct bpf_insn *insn,
> struct bpf_insn_aux_data *aux)
> {
> - u32 datasec_id, type, id = insn->imm;
> + s32 datasec_id, type, id = insn->imm;
but the value is passed as u32 to btf_type_by_id()...
btf_find_by_name_kind() returns s32
> const struct btf_var_secinfo *vsi;
> const struct btf_type *datasec;
> const struct btf_type *t;
> --
> 2.20.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id
2020-11-10 13:02 ` Denis Kirjanov
@ 2020-11-10 18:42 ` Andrii Nakryiko
0 siblings, 0 replies; 4+ messages in thread
From: Andrii Nakryiko @ 2020-11-10 18:42 UTC (permalink / raw)
To: Denis Kirjanov
Cc: xiakaixu1987, Alexei Starovoitov, Daniel Borkmann, Martin Lau,
Song Liu, Yonghong Song, Andrii Nakryiko, john fastabend,
KP Singh, Networking, bpf, open list, Kaixu Xia
On Tue, Nov 10, 2020 at 5:02 AM Denis Kirjanov <kda@linux-powerpc.org> wrote:
>
> On 11/10/20, xiakaixu1987@gmail.com <xiakaixu1987@gmail.com> wrote:
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > The unsigned variable datasec_id is assigned a return value from the call
> > to check_pseudo_btf_id(), which may return negative error code.
> >
> > Fixes coccicheck warning:
> >
> > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared
> > with zero: datasec_id > 0
> >
> > Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> > ---
> > kernel/bpf/verifier.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 6200519582a6..e9d8d4309bb4 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -9572,7 +9572,7 @@ static int check_pseudo_btf_id(struct bpf_verifier_env
> > *env,
> > struct bpf_insn *insn,
> > struct bpf_insn_aux_data *aux)
> > {
> > - u32 datasec_id, type, id = insn->imm;
> > + s32 datasec_id, type, id = insn->imm;
>
> but the value is passed as u32 to btf_type_by_id()...
>
> btf_find_by_name_kind() returns s32
Right, valid range of BTF type IDs are >= 0 and (significantly) less
than INT_MAX. So s32 is used to signal valid BTF ID or negative error,
but all the APIs accepting BTF ID accept it as just u32.
>
>
> > const struct btf_var_secinfo *vsi;
> > const struct btf_type *datasec;
> > const struct btf_type *t;
> > --
> > 2.20.0
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id
2020-11-10 11:50 [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id xiakaixu1987
2020-11-10 13:02 ` Denis Kirjanov
@ 2020-11-10 18:41 ` Andrii Nakryiko
1 sibling, 0 replies; 4+ messages in thread
From: Andrii Nakryiko @ 2020-11-10 18:41 UTC (permalink / raw)
To: xiakaixu1987
Cc: Alexei Starovoitov, Daniel Borkmann, Martin Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, john fastabend, KP Singh,
Networking, bpf, open list, Kaixu Xia
On Tue, Nov 10, 2020 at 3:50 AM <xiakaixu1987@gmail.com> wrote:
>
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The unsigned variable datasec_id is assigned a return value from the call
> to check_pseudo_btf_id(), which may return negative error code.
>
> Fixes coccicheck warning:
>
> ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> kernel/bpf/verifier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 6200519582a6..e9d8d4309bb4 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -9572,7 +9572,7 @@ static int check_pseudo_btf_id(struct bpf_verifier_env *env,
> struct bpf_insn *insn,
> struct bpf_insn_aux_data *aux)
> {
> - u32 datasec_id, type, id = insn->imm;
> + s32 datasec_id, type, id = insn->imm;
you are changing types for type and id variables here, so split out
datasec_id definition into a separate line
> const struct btf_var_secinfo *vsi;
> const struct btf_type *datasec;
> const struct btf_type *t;
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-10 18:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 11:50 [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id xiakaixu1987
2020-11-10 13:02 ` Denis Kirjanov
2020-11-10 18:42 ` Andrii Nakryiko
2020-11-10 18:41 ` Andrii Nakryiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).