From: Song Liu <song@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH bpf 1/2] libbpf: Fix type of old_fd in bpf_xdp_set_link_opts
Date: Tue, 14 Apr 2020 15:24:28 -0700 [thread overview]
Message-ID: <CAPhsuW7X00K9_QsGm8XhFw2QB03MQSEYRv2f6KupXnWHmH-puA@mail.gmail.com> (raw)
In-Reply-To: <20200414145025.182163-1-toke@redhat.com>
On Tue, Apr 14, 2020 at 9:20 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> The 'old_fd' parameter used for atomic replacement of XDP programs is
> supposed to be an FD, but was left as a u32 from an earlier iteration of
> the patch that added it. It was converted to an int when read, so things
> worked correctly even with negative values, but better change the
> definition to correctly reflect the intention.
>
> Fixes: bd5ca3ef93cd ("libbpf: Add function to set link XDP fd while specifying old program")
> Reported-by: David Ahern <dsahern@gmail.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Song Liu <songliubraving@fb.com>
next prev parent reply other threads:[~2020-04-14 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 14:50 [PATCH bpf 1/2] libbpf: Fix type of old_fd in bpf_xdp_set_link_opts Toke Høiland-Jørgensen
2020-04-14 14:50 ` [PATCH bpf 2/2] selftests/bpf: Check for correct program attach/detach in xdp_attach test Toke Høiland-Jørgensen
2020-04-14 22:30 ` Song Liu
2020-04-14 19:47 ` [PATCH bpf 1/2] libbpf: Fix type of old_fd in bpf_xdp_set_link_opts David Ahern
2020-04-14 22:24 ` Song Liu [this message]
2020-04-15 12:34 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW7X00K9_QsGm8XhFw2QB03MQSEYRv2f6KupXnWHmH-puA@mail.gmail.com \
--to=song@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).