* [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c
@ 2021-03-11 5:56 Bhaskar Chowdhury
2021-03-11 6:12 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-11 5:56 UTC (permalink / raw)
To: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, davem, kuba, hawk, netdev, bpf, linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
Trivial spelling fixes throughout the file.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
net/core/filter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 255aeee72402..931ee5f39ae7 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2927,7 +2927,7 @@ BPF_CALL_4(bpf_msg_pop_data, struct sk_msg *, msg, u32, start,
*
* Then if B is non-zero AND there is no space allocate space and
* compact A, B regions into page. If there is space shift ring to
- * the rigth free'ing the next element in ring to place B, leaving
+ * the right freeing the next element in ring to place B, leaving
* A untouched except to reduce length.
*/
if (start != offset) {
@@ -3710,7 +3710,7 @@ static inline int __bpf_skb_change_tail(struct sk_buff *skb, u32 new_len,
* be the one responsible for writing buffers.
*
* It's really expected to be a slow path operation here for
- * control message replies, so we're implicitly linearizing,
+ * control message replies, so we're implicitly linearising,
* uncloning and drop offloads from the skb by this.
*/
ret = __bpf_try_make_writable(skb, skb->len);
@@ -3778,7 +3778,7 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
* allow to expand on mac header. This means that
* skb->protocol network header, etc, stay as is.
* Compared to bpf_skb_change_tail(), we're more
- * flexible due to not needing to linearize or
+ * flexible due to not needing to linearise or
* reset GSO. Intention for this helper is to be
* used by an L3 skb that needs to push mac header
* for redirection into L2 device.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c
2021-03-11 5:56 [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c Bhaskar Chowdhury
@ 2021-03-11 6:12 ` Randy Dunlap
2021-03-11 6:21 ` Bhaskar Chowdhury
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-03-11 6:12 UTC (permalink / raw)
To: Bhaskar Chowdhury, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, davem, kuba, hawk, netdev, bpf,
linux-kernel
On 3/10/21 9:56 PM, Bhaskar Chowdhury wrote:
>
> Trivial spelling fixes throughout the file.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Hi Bhaskar,
FYI:
a. we accept British or American spellings
b. we accept one or two spaces after a period ('.') at the end of a sentence
c. we accept Oxford (serial) comma or not
> ---
> net/core/filter.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 255aeee72402..931ee5f39ae7 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2927,7 +2927,7 @@ BPF_CALL_4(bpf_msg_pop_data, struct sk_msg *, msg, u32, start,
> *
> * Then if B is non-zero AND there is no space allocate space and
> * compact A, B regions into page. If there is space shift ring to
> - * the rigth free'ing the next element in ring to place B, leaving
> + * the right freeing the next element in ring to place B, leaving
> * A untouched except to reduce length.
> */
> if (start != offset) {
> @@ -3710,7 +3710,7 @@ static inline int __bpf_skb_change_tail(struct sk_buff *skb, u32 new_len,
> * be the one responsible for writing buffers.
> *
> * It's really expected to be a slow path operation here for
> - * control message replies, so we're implicitly linearizing,
> + * control message replies, so we're implicitly linearising,
> * uncloning and drop offloads from the skb by this.
> */
> ret = __bpf_try_make_writable(skb, skb->len);
> @@ -3778,7 +3778,7 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
> * allow to expand on mac header. This means that
> * skb->protocol network header, etc, stay as is.
> * Compared to bpf_skb_change_tail(), we're more
> - * flexible due to not needing to linearize or
> + * flexible due to not needing to linearise or
> * reset GSO. Intention for this helper is to be
> * used by an L3 skb that needs to push mac header
> * for redirection into L2 device.
> --
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c
2021-03-11 6:12 ` Randy Dunlap
@ 2021-03-11 6:21 ` Bhaskar Chowdhury
0 siblings, 0 replies; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-11 6:21 UTC (permalink / raw)
To: Randy Dunlap
Cc: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, davem, kuba, hawk, netdev, bpf, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]
On 22:12 Wed 10 Mar 2021, Randy Dunlap wrote:
>On 3/10/21 9:56 PM, Bhaskar Chowdhury wrote:
>>
>> Trivial spelling fixes throughout the file.
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>
>Hi Bhaskar,
>
>FYI:
>
>a. we accept British or American spellings
>b. we accept one or two spaces after a period ('.') at the end of a sentence
>c. we accept Oxford (serial) comma or not
>
Hey Randy,
First one had an apostrophe in the word....(s/free'ing/freeing/) ????
Yup, last two was bad change ..it all same whether it's "s" or "z" in
it.Apologies.. will be cautious ...
>> ---
>> net/core/filter.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/core/filter.c b/net/core/filter.c
>> index 255aeee72402..931ee5f39ae7 100644
>> --- a/net/core/filter.c
>> +++ b/net/core/filter.c
>> @@ -2927,7 +2927,7 @@ BPF_CALL_4(bpf_msg_pop_data, struct sk_msg *, msg, u32, start,
>> *
>> * Then if B is non-zero AND there is no space allocate space and
>> * compact A, B regions into page. If there is space shift ring to
>> - * the rigth free'ing the next element in ring to place B, leaving
>> + * the right freeing the next element in ring to place B, leaving
>> * A untouched except to reduce length.
>> */
>> if (start != offset) {
>> @@ -3710,7 +3710,7 @@ static inline int __bpf_skb_change_tail(struct sk_buff *skb, u32 new_len,
>> * be the one responsible for writing buffers.
>> *
>> * It's really expected to be a slow path operation here for
>> - * control message replies, so we're implicitly linearizing,
>> + * control message replies, so we're implicitly linearising,
>> * uncloning and drop offloads from the skb by this.
>> */
>> ret = __bpf_try_make_writable(skb, skb->len);
>> @@ -3778,7 +3778,7 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
>> * allow to expand on mac header. This means that
>> * skb->protocol network header, etc, stay as is.
>> * Compared to bpf_skb_change_tail(), we're more
>> - * flexible due to not needing to linearize or
>> + * flexible due to not needing to linearise or
>> * reset GSO. Intention for this helper is to be
>> * used by an L3 skb that needs to push mac header
>> * for redirection into L2 device.
>> --
>
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 5:56 [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c Bhaskar Chowdhury
2021-03-11 6:12 ` Randy Dunlap
2021-03-11 6:21 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).