* [PATCH bpf-next] tools/resolve_btfids: Fix warnings
@ 2021-03-29 16:24 Stanislav Fomichev
2021-03-29 16:39 ` sdf
0 siblings, 1 reply; 2+ messages in thread
From: Stanislav Fomichev @ 2021-03-29 16:24 UTC (permalink / raw)
To: netdev, bpf; +Cc: ast, daniel, Stanislav Fomichev
* make eprintf static, used only in main.c
* initialize ret in eprintf
* remove unused *tmp
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/bpf/resolve_btfids/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 80d966cfcaa1..a650422f7430 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -115,10 +115,10 @@ struct object {
static int verbose;
-int eprintf(int level, int var, const char *fmt, ...)
+static int eprintf(int level, int var, const char *fmt, ...)
{
va_list args;
- int ret;
+ int ret = 0;
if (var >= level) {
va_start(args, fmt);
@@ -403,7 +403,7 @@ static int symbols_collect(struct object *obj)
* __BTF_ID__* over .BTF_ids section.
*/
for (i = 0; !err && i < n; i++) {
- char *tmp, *prefix;
+ char *prefix;
struct btf_id *id;
GElf_Sym sym;
int err = -1;
--
2.31.0.291.g576ba9dcdaf-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: Fix warnings
2021-03-29 16:24 [PATCH bpf-next] tools/resolve_btfids: Fix warnings Stanislav Fomichev
@ 2021-03-29 16:39 ` sdf
0 siblings, 0 replies; 2+ messages in thread
From: sdf @ 2021-03-29 16:39 UTC (permalink / raw)
To: netdev, bpf; +Cc: ast, daniel
On 03/29, Stanislav Fomichev wrote:
> * make eprintf static, used only in main.c
> * initialize ret in eprintf
> * remove unused *tmp
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/bpf/resolve_btfids/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/tools/bpf/resolve_btfids/main.c
> b/tools/bpf/resolve_btfids/main.c
> index 80d966cfcaa1..a650422f7430 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -115,10 +115,10 @@ struct object {
> static int verbose;
> -int eprintf(int level, int var, const char *fmt, ...)
> +static int eprintf(int level, int var, const char *fmt, ...)
> {
> va_list args;
> - int ret;
> + int ret = 0;
> if (var >= level) {
> va_start(args, fmt);
> @@ -403,7 +403,7 @@ static int symbols_collect(struct object *obj)
> * __BTF_ID__* over .BTF_ids section.
> */
> for (i = 0; !err && i < n; i++) {
> - char *tmp, *prefix;
> + char *prefix;
> struct btf_id *id;
> GElf_Sym sym;
> int err = -1;
> --
> 2.31.0.291.g576ba9dcdaf-goog
Looks like that 'int err = -1' is also unused.
I'll respin, please ignore this one. Sorry for the noise.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 16:24 [PATCH bpf-next] tools/resolve_btfids: Fix warnings Stanislav Fomichev
2021-03-29 16:39 ` sdf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).