bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* OUTPUT and TEST_CUSTOM_PROGS
@ 2020-05-25  6:28 Yauheni Kaliuta
  2020-05-26 16:43 ` shuah
  0 siblings, 1 reply; 2+ messages in thread
From: Yauheni Kaliuta @ 2020-05-25  6:28 UTC (permalink / raw)
  To: Shuah Khan; +Cc: linux-kselftest, bpf

Hi!

lib.mk expects TEST_GEN_PROGS, TEST_GEN_PROGS_EXTENDED and
TEST_GEN_FILES to be in local directory and tries to handle out
of tree build adding OUTPUT to it at the beginning.

commit be16a244c199 ("selftests: lib.mk: add TEST_CUSTOM_PROGS to
allow custom test run/install") adds TEST_CUSTOM_PROGS but it
handles it differently. Should it add OUTPUT as well?

-- 
WBR,
Yauheni Kaliuta


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: OUTPUT and TEST_CUSTOM_PROGS
  2020-05-25  6:28 OUTPUT and TEST_CUSTOM_PROGS Yauheni Kaliuta
@ 2020-05-26 16:43 ` shuah
  0 siblings, 0 replies; 2+ messages in thread
From: shuah @ 2020-05-26 16:43 UTC (permalink / raw)
  To: Yauheni Kaliuta; +Cc: linux-kselftest, bpf, shuah

On 5/25/20 12:28 AM, Yauheni Kaliuta wrote:
> Hi!
> 
> lib.mk expects TEST_GEN_PROGS, TEST_GEN_PROGS_EXTENDED and
> TEST_GEN_FILES to be in local directory and tries to handle out
> of tree build adding OUTPUT to it at the beginning.
> 
> commit be16a244c199 ("selftests: lib.mk: add TEST_CUSTOM_PROGS to
> allow custom test run/install") adds TEST_CUSTOM_PROGS but it
> handles it differently. Should it add OUTPUT as well?
> 

Individual tests apply OUTPUT to TEST_CUSTOM_PROGS. lib.mk rules
can't build TEST_CUSTOM_PROGS and it is left up to tests to
handle them as custom.

So no on adding OUTPUT to TEST_CUSTOM_PROGS in lib.mk.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-26 16:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25  6:28 OUTPUT and TEST_CUSTOM_PROGS Yauheni Kaliuta
2020-05-26 16:43 ` shuah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).