* [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct
@ 2024-04-25 10:03 Christophe JAILLET
2024-04-25 11:49 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-04-25 10:03 UTC (permalink / raw)
To: Arend van Spriel, Kalle Valo
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
linux-wireless, brcm80211, brcm80211-dev-list.pdl
struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
list.")
Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
firmware list from USB driver").
Remove the structure definition now. This saves a few lines of code.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index 0ccf735316c2..9a105e6debe1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -117,13 +117,6 @@ struct bootrom_id_le {
__le32 boardrev; /* Board revision */
};
-struct brcmf_usb_image {
- struct list_head list;
- s8 *fwname;
- u8 *image;
- int image_len;
-};
-
struct brcmf_usbdev_info {
struct brcmf_usbdev bus_pub; /* MUST BE FIRST */
spinlock_t qlock;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct
2024-04-25 10:03 [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct Christophe JAILLET
@ 2024-04-25 11:49 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2024-04-25 11:49 UTC (permalink / raw)
To: Christophe JAILLET, Kalle Valo
Cc: linux-kernel, kernel-janitors, linux-wireless, brcm80211,
brcm80211-dev-list.pdl
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
On 4/25/2024 12:03 PM, Christophe JAILLET wrote:
> struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
> ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
> in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
> list.")
>
> Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
> firmware list from USB driver").
>
> Remove the structure definition now. This saves a few lines of code.
Thanks for the cleanup/
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> index 0ccf735316c2..9a105e6debe1 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> @@ -117,13 +117,6 @@ struct bootrom_id_le {
> __le32 boardrev; /* Board revision */
> };
>
> -struct brcmf_usb_image {
> - struct list_head list;
> - s8 *fwname;
> - u8 *image;
> - int image_len;
> -};
> -
> struct brcmf_usbdev_info {
> struct brcmf_usbdev bus_pub; /* MUST BE FIRST */
> spinlock_t qlock;
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct
2024-04-25 10:03 [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct Christophe JAILLET
2024-04-25 11:49 ` Arend van Spriel
@ 2024-04-26 10:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-04-26 10:36 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Arend van Spriel, linux-kernel, kernel-janitors,
Christophe JAILLET, linux-wireless, brcm80211,
brcm80211-dev-list.pdl
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
> ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
> in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
> list.")
>
> Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
> firmware list from USB driver").
>
> Remove the structure definition now. This saves a few lines of code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-next.git, thanks.
cc1380dd1882 wifi: brcmfmac: remove unused brcmf_usb_image struct
--
https://patchwork.kernel.org/project/linux-wireless/patch/23afd8c1733ad087ce2399a07a30d689aef861d5.1714039373.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 10:03 [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct Christophe JAILLET
2024-04-25 11:49 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).