* [PATCH] bridge: vlan: fix compressvlans manpage and usage
@ 2024-03-22 8:56 Date Huang
2024-03-22 9:25 ` Nikolay Aleksandrov
2024-03-22 9:40 ` Jiri Pirko
0 siblings, 2 replies; 5+ messages in thread
From: Date Huang @ 2024-03-22 8:56 UTC (permalink / raw)
To: roopa; +Cc: razor, netdev, bridge, tjjh89017
Add the missing 'compressvlans' to man page.
Fix the incorrect short opt for compressvlans and color
in usage.
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
---
bridge/bridge.c | 2 +-
man/man8/bridge.8 | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/bridge/bridge.c b/bridge/bridge.c
index f4805092..345f5b5f 100644
--- a/bridge/bridge.c
+++ b/bridge/bridge.c
@@ -39,7 +39,7 @@ static void usage(void)
"where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
" OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
" -o[neline] | -t[imestamp] | -n[etns] name |\n"
-" -c[ompressvlans] -color -p[retty] -j[son] }\n");
+" -compressvlans -c[olor] -p[retty] -j[son] }\n");
exit(-1);
}
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index eeea4073..9a023227 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
\fB\-s\fR[\fItatistics\fR] |
\fB\-n\fR[\fIetns\fR] name |
\fB\-b\fR[\fIatch\fR] filename |
+\fB\-compressvlans |
\fB\-c\fR[\fIolor\fR] |
\fB\-p\fR[\fIretty\fR] |
\fB\-j\fR[\fIson\fR] |
@@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
If there were any errors during execution of the commands, the application
return code will be non zero.
+.TP
+.BR \-compressvlans
+Show compressed vlan list
+
.TP
.BR \-c [ color ][ = { always | auto | never }
Configure color output. If parameter is omitted or
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage
2024-03-22 8:56 [PATCH] bridge: vlan: fix compressvlans manpage and usage Date Huang
@ 2024-03-22 9:25 ` Nikolay Aleksandrov
2024-03-22 12:32 ` Date Huang
2024-03-22 9:40 ` Jiri Pirko
1 sibling, 1 reply; 5+ messages in thread
From: Nikolay Aleksandrov @ 2024-03-22 9:25 UTC (permalink / raw)
To: Date Huang, roopa; +Cc: netdev, bridge
On 3/22/24 10:56, Date Huang wrote:
> Add the missing 'compressvlans' to man page.
> Fix the incorrect short opt for compressvlans and color
> in usage.
>
> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
> ---
Hi,
This should be targeted at iproute2. Nit below,
> bridge/bridge.c | 2 +-
> man/man8/bridge.8 | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/bridge/bridge.c b/bridge/bridge.c
> index f4805092..345f5b5f 100644
> --- a/bridge/bridge.c
> +++ b/bridge/bridge.c
> @@ -39,7 +39,7 @@ static void usage(void)
> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
> -" -c[ompressvlans] -color -p[retty] -j[son] }\n");
> +" -compressvlans -c[olor] -p[retty] -j[son] }\n");
> exit(-1);
> }
>
> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
> index eeea4073..9a023227 100644
> --- a/man/man8/bridge.8
> +++ b/man/man8/bridge.8
> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
> \fB\-s\fR[\fItatistics\fR] |
> \fB\-n\fR[\fIetns\fR] name |
> \fB\-b\fR[\fIatch\fR] filename |
> +\fB\-compressvlans |
> \fB\-c\fR[\fIolor\fR] |
> \fB\-p\fR[\fIretty\fR] |
> \fB\-j\fR[\fIson\fR] |
> @@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
> If there were any errors during execution of the commands, the application
> return code will be non zero.
>
> +.TP
> +.BR \-compressvlans
> +Show compressed vlan list
s/vlan/VLAN/
also the explanation is lacking, please add a little bit of details and
what the default is
> +
> .TP
> .BR \-c [ color ][ = { always | auto | never }
> Configure color output. If parameter is omitted or
Thanks,
Nik
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage
2024-03-22 8:56 [PATCH] bridge: vlan: fix compressvlans manpage and usage Date Huang
2024-03-22 9:25 ` Nikolay Aleksandrov
@ 2024-03-22 9:40 ` Jiri Pirko
2024-03-22 12:33 ` Date Huang
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Pirko @ 2024-03-22 9:40 UTC (permalink / raw)
To: Date Huang; +Cc: roopa, razor, netdev, bridge
Fri, Mar 22, 2024 at 09:56:29AM CET, tjjh89017@hotmail.com wrote:
>Add the missing 'compressvlans' to man page.
>Fix the incorrect short opt for compressvlans and color
>in usage.
Split to 2 patches please.
Please fix your prefix to be in format "[patch iproute2-next] xxx"
to properly indicate the target project and tree.
>
>Signed-off-by: Date Huang <tjjh89017@hotmail.com>
>---
> bridge/bridge.c | 2 +-
> man/man8/bridge.8 | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/bridge/bridge.c b/bridge/bridge.c
>index f4805092..345f5b5f 100644
>--- a/bridge/bridge.c
>+++ b/bridge/bridge.c
>@@ -39,7 +39,7 @@ static void usage(void)
> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
>-" -c[ompressvlans] -color -p[retty] -j[son] }\n");
>+" -compressvlans -c[olor] -p[retty] -j[son] }\n");
From how I read the code, shouldn't this be rather:
" -com[pressvlans] -c[olor] -p[retty] -j[son] }\n");
?
> exit(-1);
> }
>
>diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>index eeea4073..9a023227 100644
>--- a/man/man8/bridge.8
>+++ b/man/man8/bridge.8
>@@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
> \fB\-s\fR[\fItatistics\fR] |
> \fB\-n\fR[\fIetns\fR] name |
> \fB\-b\fR[\fIatch\fR] filename |
>+\fB\-compressvlans |
> \fB\-c\fR[\fIolor\fR] |
> \fB\-p\fR[\fIretty\fR] |
> \fB\-j\fR[\fIson\fR] |
>@@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
> If there were any errors during execution of the commands, the application
> return code will be non zero.
>
>+.TP
>+.BR \-compressvlans
>+Show compressed vlan list
>+
> .TP
> .BR \-c [ color ][ = { always | auto | never }
> Configure color output. If parameter is omitted or
>--
>2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage
2024-03-22 9:25 ` Nikolay Aleksandrov
@ 2024-03-22 12:32 ` Date Huang
0 siblings, 0 replies; 5+ messages in thread
From: Date Huang @ 2024-03-22 12:32 UTC (permalink / raw)
To: Nikolay Aleksandrov, roopa; +Cc: netdev, bridge
Hi Nikolay
On 3/22/2024 5:25 PM, Nikolay Aleksandrov wrote:
> On 3/22/24 10:56, Date Huang wrote:
>> Add the missing 'compressvlans' to man page.
>> Fix the incorrect short opt for compressvlans and color
>> in usage.
>>
>> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
>> ---
>
> Hi,
> This should be targeted at iproute2. Nit below,
Thank you, I will update this in the latest patch.
>
>> bridge/bridge.c | 2 +-
>> man/man8/bridge.8 | 5 +++++
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/bridge/bridge.c b/bridge/bridge.c
>> index f4805092..345f5b5f 100644
>> --- a/bridge/bridge.c
>> +++ b/bridge/bridge.c
>> @@ -39,7 +39,7 @@ static void usage(void)
>> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
>> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
>> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
>> -" -c[ompressvlans] -color -p[retty] -j[son] }\n");
>> +" -compressvlans -c[olor] -p[retty] -j[son] }\n");
>> exit(-1);
>> }
>> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>> index eeea4073..9a023227 100644
>> --- a/man/man8/bridge.8
>> +++ b/man/man8/bridge.8
>> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and
>> devices
>> \fB\-s\fR[\fItatistics\fR] |
>> \fB\-n\fR[\fIetns\fR] name |
>> \fB\-b\fR[\fIatch\fR] filename |
>> +\fB\-compressvlans |
>> \fB\-c\fR[\fIolor\fR] |
>> \fB\-p\fR[\fIretty\fR] |
>> \fB\-j\fR[\fIson\fR] |
>> @@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch
>> mode.
>> If there were any errors during execution of the commands, the
>> application
>> return code will be non zero.
>> +.TP
>> +.BR \-compressvlans
>> +Show compressed vlan list
>
> s/vlan/VLAN/
> also the explanation is lacking, please add a little bit of details and
> what the default is
Ok, I updated this in the latest patch v2.
>
>> +
>> .TP
>> .BR \-c [ color ][ = { always | auto | never }
>> Configure color output. If parameter is omitted or
>
> Thanks,
> Nik
>
Thanks,
Date
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage
2024-03-22 9:40 ` Jiri Pirko
@ 2024-03-22 12:33 ` Date Huang
0 siblings, 0 replies; 5+ messages in thread
From: Date Huang @ 2024-03-22 12:33 UTC (permalink / raw)
To: Jiri Pirko; +Cc: roopa, razor, netdev, bridge
Hi Jiri
On 3/22/2024 5:40 PM, Jiri Pirko wrote:
> Fri, Mar 22, 2024 at 09:56:29AM CET, tjjh89017@hotmail.com wrote:
>> Add the missing 'compressvlans' to man page.
>> Fix the incorrect short opt for compressvlans and color
>> in usage.
>
> Split to 2 patches please.
>
> Please fix your prefix to be in format "[patch iproute2-next] xxx"
> to properly indicate the target project and tree.
Thank you, I will update this in v2.
>
>
>>
>> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
>> ---
>> bridge/bridge.c | 2 +-
>> man/man8/bridge.8 | 5 +++++
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/bridge/bridge.c b/bridge/bridge.c
>> index f4805092..345f5b5f 100644
>> --- a/bridge/bridge.c
>> +++ b/bridge/bridge.c
>> @@ -39,7 +39,7 @@ static void usage(void)
>> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
>> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
>> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
>> -" -c[ompressvlans] -color -p[retty] -j[son] }\n");
>> +" -compressvlans -c[olor] -p[retty] -j[son] }\n");
>
> From how I read the code, shouldn't this be rather:
> " -com[pressvlans] -c[olor] -p[retty] -j[son] }\n");
> ?
Agree with you, I will update it in v2.
>
>> exit(-1);
>> }
>>
>> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>> index eeea4073..9a023227 100644
>> --- a/man/man8/bridge.8
>> +++ b/man/man8/bridge.8
>> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
>> \fB\-s\fR[\fItatistics\fR] |
>> \fB\-n\fR[\fIetns\fR] name |
>> \fB\-b\fR[\fIatch\fR] filename |
>> +\fB\-compressvlans |
>> \fB\-c\fR[\fIolor\fR] |
>> \fB\-p\fR[\fIretty\fR] |
>> \fB\-j\fR[\fIson\fR] |
>> @@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
>> If there were any errors during execution of the commands, the application
>> return code will be non zero.
>>
>> +.TP
>> +.BR \-compressvlans
>> +Show compressed vlan list
>> +
>> .TP
>> .BR \-c [ color ][ = { always | auto | never }
>> Configure color output. If parameter is omitted or
>> --
>> 2.34.1
>>
>>
Thanks,
Date
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-22 12:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 8:56 [PATCH] bridge: vlan: fix compressvlans manpage and usage Date Huang
2024-03-22 9:25 ` Nikolay Aleksandrov
2024-03-22 12:32 ` Date Huang
2024-03-22 9:40 ` Jiri Pirko
2024-03-22 12:33 ` Date Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).