[Buildroot] [PATCH 1/1] package/pipewire: add option to enable media-session support

[Buildroot] [PATCH 1/1] package/pipewire: add option to enable media-session support

[James Hilliard]

The example media-session pipewire session manager requires
pipewire to be built with examples enabled, add support for
enabling this while depending on examples being enabled.

To simplify adding support for additional session managers in
the future such as wireplumber we pass a comma separated list
to the -Dsession-managers meson config option. This also will
ensure that systemd services that depend on media-session are
only installed if media-session support is enabled.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/pipewire/Config.in   | 6 ++++++
 package/pipewire/pipewire.mk | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/pipewire/Config.in b/package/pipewire/Config.in
index b15bbfa8d3..506b85e856 100644
--- a/package/pipewire/Config.in
+++ b/package/pipewire/Config.in
@@ -19,6 +19,12 @@ config BR2_PACKAGE_PIPEWIRE_EXAMPLES
 	help
 	  Build pipewire examples
 
+config BR2_PACKAGE_PIPEWIRE_MEDIA_SESSION
+	bool "pipewire media-session"
+	depends on BR2_PACKAGE_PIPEWIRE_EXAMPLES
+	help
+	  Build pipewire media-session support
+
 config BR2_PACKAGE_PIPEWIRE_GSTREAMER
 	bool "pipewire gstreamer plugins"
 	depends on BR2_USE_WCHAR # libglib2
diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
index e4ea60c39c..f4f7f487cb 100644
--- a/package/pipewire/pipewire.mk
+++ b/package/pipewire/pipewire.mk
@@ -150,4 +150,10 @@ else
 PIPEWIRE_CONF_OPTS += -Decho-cancel-webrtc=disabled
 endif
 
+ifeq ($(BR2_PACKAGE_PIPEWIRE_MEDIA_SESSION),y)
+PIPEWIRE_SESSION_MANAGERS_LIST = media-session
+endif
+
+PIPEWIRE_CONF_OPTS += -Dsession-managers='$(subst $(space),$(comma),$(PIPEWIRE_SESSION_MANAGERS_LIST))'
+
 $(eval $(meson-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pipewire: add option to enable media-session support

[Arnout Vandecappelle]

On 12/09/2021 22:47, James Hilliard wrote:
> The example media-session pipewire session manager requires
> pipewire to be built with examples enabled, add support for
> enabling this while depending on examples being enabled.
> 
> To simplify adding support for additional session managers in
> the future such as wireplumber we pass a comma separated list
> to the -Dsession-managers meson config option. This also will
> ensure that systemd services that depend on media-session are
> only installed if media-session support is enabled.

  Very nice approach!

  Applied to master, thanks.

  Regards,
  Arnout

> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   package/pipewire/Config.in   | 6 ++++++
>   package/pipewire/pipewire.mk | 6 ++++++
>   2 files changed, 12 insertions(+)
> 
> diff --git a/package/pipewire/Config.in b/package/pipewire/Config.in
> index b15bbfa8d3..506b85e856 100644
> --- a/package/pipewire/Config.in
> +++ b/package/pipewire/Config.in
> @@ -19,6 +19,12 @@ config BR2_PACKAGE_PIPEWIRE_EXAMPLES
>   	help
>   	  Build pipewire examples
>   
> +config BR2_PACKAGE_PIPEWIRE_MEDIA_SESSION
> +	bool "pipewire media-session"
> +	depends on BR2_PACKAGE_PIPEWIRE_EXAMPLES
> +	help
> +	  Build pipewire media-session support
> +
>   config BR2_PACKAGE_PIPEWIRE_GSTREAMER
>   	bool "pipewire gstreamer plugins"
>   	depends on BR2_USE_WCHAR # libglib2
> diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
> index e4ea60c39c..f4f7f487cb 100644
> --- a/package/pipewire/pipewire.mk
> +++ b/package/pipewire/pipewire.mk
> @@ -150,4 +150,10 @@ else
>   PIPEWIRE_CONF_OPTS += -Decho-cancel-webrtc=disabled
>   endif
>   
> +ifeq ($(BR2_PACKAGE_PIPEWIRE_MEDIA_SESSION),y)
> +PIPEWIRE_SESSION_MANAGERS_LIST = media-session
> +endif
> +
> +PIPEWIRE_CONF_OPTS += -Dsession-managers='$(subst $(space),$(comma),$(PIPEWIRE_SESSION_MANAGERS_LIST))'
> +
>   $(eval $(meson-package))
> 
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot