[Buildroot] [PATCH v4 1/1] package/python-pyicu: fix build

[Buildroot] [PATCH v4 1/1] package/python-pyicu: fix build

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/

Set environment variables to cross-compile friendly values, this prevents
icu-config picking up host libraries:
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216

This follows the upstream build docs:
https://gitlab.pyicu.org/main/pyicu#building-pyicu

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v4: removed variable ICU_BASE (Thomas)

 package/python-pyicu/python-pyicu.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/python-pyicu/python-pyicu.mk b/package/python-pyicu/python-pyicu.mk
index 090ed51bff..213c099d07 100644
--- a/package/python-pyicu/python-pyicu.mk
+++ b/package/python-pyicu/python-pyicu.mk
@@ -12,4 +12,10 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
 PYTHON_PYICU_DEPENDENCIES = icu
 PYTHON_PYICU_SETUP_TYPE = setuptools
 
+PYTHON_PYICU_ENV += \
+	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
+	PYICU_CFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --variable=CXXFLAGS`" \
+	PYICU_LFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-L` \
+		`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-l`"
+
 $(eval $(python-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/1] package/python-pyicu: fix build

[Arnout Vandecappelle via buildroot]

On 02/07/2023 12:31, Bernd Kuhls wrote:
> Fixes:
> http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/
> 
> Set environment variables to cross-compile friendly values, this prevents
> icu-config picking up host libraries:
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216
> 
> This follows the upstream build docs:
> https://gitlab.pyicu.org/main/pyicu#building-pyicu
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
> v4: removed variable ICU_BASE (Thomas)
> 
>   package/python-pyicu/python-pyicu.mk | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/package/python-pyicu/python-pyicu.mk b/package/python-pyicu/python-pyicu.mk
> index 090ed51bff..213c099d07 100644
> --- a/package/python-pyicu/python-pyicu.mk
> +++ b/package/python-pyicu/python-pyicu.mk
> @@ -12,4 +12,10 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
>   PYTHON_PYICU_DEPENDENCIES = icu
>   PYTHON_PYICU_SETUP_TYPE = setuptools
>   
> +PYTHON_PYICU_ENV += \
> +	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
> +	PYICU_CFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --variable=CXXFLAGS`" \
> +	PYICU_LFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-L` \
> +		`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-l`"
> +
>   $(eval $(python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/1] package/python-pyicu: fix build

[Peter Korsgaard]

On 02/07/2023 12.31, Bernd Kuhls wrote:
> Fixes:
> http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/
> 
> Set environment variables to cross-compile friendly values, this prevents
> icu-config picking up host libraries:
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216
> 
> This follows the upstream build docs:
> https://gitlab.pyicu.org/main/pyicu#building-pyicu
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v4: removed variable ICU_BASE (Thomas)

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot