buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/1] NSS enable parallel building
@ 2021-08-16 17:45 Giulio Benetti
  2021-08-16 17:45 ` [Buildroot] [PATCH 1/1] package/libnss: " Giulio Benetti
  0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2021-08-16 17:45 UTC (permalink / raw)
  To: buildroot; +Cc: Joseph Kogut, Giulio Benetti

This patch is meant to retry to enable parallel build for libnss. This
upstream patch[1] seems to fix it, and I've loop-built it for 24 hours
with a script doing:
```
make libnss-dirclean libnss
```
until the return code is 0. This can't show 100% it works, but I ask you
to accept the patch and eventually deal with build failure later where I'd
have more elements to fix it(if it still fails of course).

[1]: https://hg.mozilla.org/projects/nss/rev/a5c857139b37476ca10032504ea876b97e066424

Giulio Benetti (1):
  package/libnss: enable parallel building

 package/libnss/libnss.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/libnss: enable parallel building
  2021-08-16 17:45 [Buildroot] [PATCH 0/1] NSS enable parallel building Giulio Benetti
@ 2021-08-16 17:45 ` Giulio Benetti
  2021-08-19 20:34   ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2021-08-16 17:45 UTC (permalink / raw)
  To: buildroot; +Cc: Joseph Kogut, Giulio Benetti

Parallel Makefile building has been fixed with version 3.62 on commit
[1], so enable parallel building by substituting $(MAKE1) with $(MAKE)
in libnss.mk.

[1]: https://hg.mozilla.org/projects/nss/rev/a5c857139b37476ca10032504ea876b97e066424

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libnss/libnss.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
index 0db543e34b..100ce2f8aa 100644
--- a/package/libnss/libnss.mk
+++ b/package/libnss/libnss.mk
@@ -69,12 +69,12 @@ endif
 endif
 
 define LIBNSS_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss coreconf \
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/nss coreconf \
 		SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \
 		DIST=$(@D)/$(LIBNSS_DISTDIR) \
 		CHECKLOC= \
 		$(LIBNSS_BUILD_VARS)
-	$(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss lib/dbm all \
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/nss lib/dbm all \
 		SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \
 		DIST=$(@D)/$(LIBNSS_DISTDIR) \
 		CHECKLOC= \
@@ -129,12 +129,12 @@ HOST_LIBNSS_BUILD_VARS += USE_64=1
 endif
 
 define HOST_LIBNSS_BUILD_CMDS
-	$(HOST_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss coreconf \
+	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)/nss coreconf \
 		SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \
 		DIST=$(@D)/$(LIBNSS_DISTDIR) \
 		CHECKLOC= \
 		$(HOST_LIBNSS_BUILD_VARS)
-	$(HOST_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss lib/dbm all \
+	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)/nss lib/dbm all \
 		SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \
 		DIST=$(@D)/$(LIBNSS_DISTDIR) \
 		CHECKLOC= \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libnss: enable parallel building
  2021-08-16 17:45 ` [Buildroot] [PATCH 1/1] package/libnss: " Giulio Benetti
@ 2021-08-19 20:34   ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-08-19 20:34 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Joseph Kogut, buildroot

On Mon, 16 Aug 2021 19:45:53 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Parallel Makefile building has been fixed with version 3.62 on commit
> [1], so enable parallel building by substituting $(MAKE1) with $(MAKE)
> in libnss.mk.
> 
> [1]: https://hg.mozilla.org/projects/nss/rev/a5c857139b37476ca10032504ea876b97e066424
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libnss/libnss.mk | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-19 20:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 17:45 [Buildroot] [PATCH 0/1] NSS enable parallel building Giulio Benetti
2021-08-16 17:45 ` [Buildroot] [PATCH 1/1] package/libnss: " Giulio Benetti
2021-08-19 20:34   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).