buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration
@ 2021-09-22 11:38 José Pekkarinen
  2021-09-29  7:10 ` José Pekkarinen
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: José Pekkarinen @ 2021-09-22 11:38 UTC (permalink / raw)
  To: buildroot; +Cc: José Pekkarinen

wpa_supplicant defconfig doesn't enable CONFIG_MESH
by default, and currently there is only a path to
disable it in buildroot. This patch will restore
the logic to enable it.

Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
---
[ v1 -> v2 ] s/CONFIG__MESH/CONFIG_MESH/

 package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index e9078b9f89..3c0b0c1dfc 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -104,7 +104,9 @@ else
 WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY
 endif
 
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
+WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_MESH
+else
 WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_MESH
 endif
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration
  2021-09-22 11:38 [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration José Pekkarinen
@ 2021-09-29  7:10 ` José Pekkarinen
  2021-09-29  8:37 ` Nicolas Cavallari
  2021-10-06 19:21 ` Arnout Vandecappelle
  2 siblings, 0 replies; 5+ messages in thread
From: José Pekkarinen @ 2021-09-29  7:10 UTC (permalink / raw)
  To: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1174 bytes --]

Hi,

Any impediment here?

Thanks!

José.


On Wed, Sep 22, 2021 at 2:38 PM José Pekkarinen <jose.pekkarinen@unikie.com>
wrote:

> wpa_supplicant defconfig doesn't enable CONFIG_MESH
> by default, and currently there is only a path to
> disable it in buildroot. This patch will restore
> the logic to enable it.
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> ---
> [ v1 -> v2 ] s/CONFIG__MESH/CONFIG_MESH/
>
>  package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk
> b/package/wpa_supplicant/wpa_supplicant.mk
> index e9078b9f89..3c0b0c1dfc 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -104,7 +104,9 @@ else
>  WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY
>  endif
>
> -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),)
> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
> +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_MESH
> +else
>  WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_MESH
>  endif
>
> --
> 2.25.1
>
>

-- 

José.

[-- Attachment #1.2: Type: text/html, Size: 2554 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration
  2021-09-22 11:38 [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration José Pekkarinen
  2021-09-29  7:10 ` José Pekkarinen
@ 2021-09-29  8:37 ` Nicolas Cavallari
  2021-10-06  6:28   ` José Pekkarinen
  2021-10-06 19:21 ` Arnout Vandecappelle
  2 siblings, 1 reply; 5+ messages in thread
From: Nicolas Cavallari @ 2021-09-29  8:37 UTC (permalink / raw)
  To: José Pekkarinen, buildroot

On 22/09/2021 13:38, José Pekkarinen wrote:
> wpa_supplicant defconfig doesn't enable CONFIG_MESH
> by default, and currently there is only a path to
> disable it in buildroot. This patch will restore
> the logic to enable it.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> ---
> [ v1 -> v2 ] s/CONFIG__MESH/CONFIG_MESH/
> 
>   package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index e9078b9f89..3c0b0c1dfc 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -104,7 +104,9 @@ else
>   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY
>   endif
>   
> -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),)
> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
> +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_MESH
> +else
>   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_MESH
>   endif
>   
> 

Tested-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Acked-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration
  2021-09-29  8:37 ` Nicolas Cavallari
@ 2021-10-06  6:28   ` José Pekkarinen
  0 siblings, 0 replies; 5+ messages in thread
From: José Pekkarinen @ 2021-10-06  6:28 UTC (permalink / raw)
  To: Nicolas Cavallari; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1586 bytes --]

On Wed, Sep 29, 2021 at 11:37 AM Nicolas Cavallari <
nicolas.cavallari@green-communications.fr> wrote:

> On 22/09/2021 13:38, José Pekkarinen wrote:
> > wpa_supplicant defconfig doesn't enable CONFIG_MESH
> > by default, and currently there is only a path to
> > disable it in buildroot. This patch will restore
> > the logic to enable it.
> >
> > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> > ---
> > [ v1 -> v2 ] s/CONFIG__MESH/CONFIG_MESH/
> >
> >   package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/wpa_supplicant/wpa_supplicant.mk
> b/package/wpa_supplicant/wpa_supplicant.mk
> > index e9078b9f89..3c0b0c1dfc 100644
> > --- a/package/wpa_supplicant/wpa_supplicant.mk
> > +++ b/package/wpa_supplicant/wpa_supplicant.mk
> > @@ -104,7 +104,9 @@ else
> >   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY
> >   endif
> >
> > -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),)
> > +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
> > +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_MESH
> > +else
> >   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_MESH
> >   endif
> >
> >
>
> Tested-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> Acked-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
>

Thanks Nicolas for double checking!

I haven't receive any comments nor signs

of this landing in the master, so please let me know
if you need anything to proceed with the patch.

Best regards.


José.

[-- Attachment #1.2: Type: text/html, Size: 3054 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration
  2021-09-22 11:38 [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration José Pekkarinen
  2021-09-29  7:10 ` José Pekkarinen
  2021-09-29  8:37 ` Nicolas Cavallari
@ 2021-10-06 19:21 ` Arnout Vandecappelle
  2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-10-06 19:21 UTC (permalink / raw)
  To: José Pekkarinen, buildroot



On 22/09/2021 13:38, José Pekkarinen wrote:
> wpa_supplicant defconfig doesn't enable CONFIG_MESH
> by default, and currently there is only a path to
> disable it in buildroot. This patch will restore
> the logic to enable it.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
> [ v1 -> v2 ] s/CONFIG__MESH/CONFIG_MESH/
> 
>   package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index e9078b9f89..3c0b0c1dfc 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -104,7 +104,9 @@ else
>   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY
>   endif
>   
> -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),)
> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
> +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_MESH
> +else
>   WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_MESH
>   endif
>   
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-06 19:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 11:38 [Buildroot] [PATCH v2] package/wpa_supplicant: Allow mesh configuration José Pekkarinen
2021-09-29  7:10 ` José Pekkarinen
2021-09-29  8:37 ` Nicolas Cavallari
2021-10-06  6:28   ` José Pekkarinen
2021-10-06 19:21 ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).