* [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1"
@ 2022-09-24 21:41 Cédric Le Goater
2022-09-25 12:40 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Cédric Le Goater @ 2022-09-24 21:41 UTC (permalink / raw)
To: buildroot; +Cc: Joel Stanley, Cédric Le Goater
This reverts commit 1e2fe860f3a261fc877591c056808d6fb30e25d4.
The default 2.38.x has the required fixes.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
https://gitlab.com/legoater/buildroot/-/pipelines/649723598
configs/qemu_ppc64_e5500_defconfig | 1 -
configs/qemu_ppc64_pseries_defconfig | 1 -
configs/qemu_ppc64le_powernv8_defconfig | 1 -
configs/qemu_ppc64le_pseries_defconfig | 1 -
4 files changed, 4 deletions(-)
diff --git a/configs/qemu_ppc64_e5500_defconfig b/configs/qemu_ppc64_e5500_defconfig
index 8458f2739a66..0825d0ab9b30 100644
--- a/configs/qemu_ppc64_e5500_defconfig
+++ b/configs/qemu_ppc64_e5500_defconfig
@@ -3,7 +3,6 @@ BR2_powerpc64=y
BR2_powerpc_e5500=y
# System
-BR2_BINUTILS_VERSION_2_36_X=y
BR2_SYSTEM_DHCP="eth0"
BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
diff --git a/configs/qemu_ppc64_pseries_defconfig b/configs/qemu_ppc64_pseries_defconfig
index 480ebea29d70..c45014f2ac3f 100644
--- a/configs/qemu_ppc64_pseries_defconfig
+++ b/configs/qemu_ppc64_pseries_defconfig
@@ -3,7 +3,6 @@ BR2_powerpc64=y
BR2_powerpc_power7=y
# System
-BR2_BINUTILS_VERSION_2_36_X=y
BR2_SYSTEM_DHCP="eth0"
BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
diff --git a/configs/qemu_ppc64le_powernv8_defconfig b/configs/qemu_ppc64le_powernv8_defconfig
index 8de4cf5189b5..822145e927a1 100644
--- a/configs/qemu_ppc64le_powernv8_defconfig
+++ b/configs/qemu_ppc64le_powernv8_defconfig
@@ -3,7 +3,6 @@ BR2_powerpc64le=y
BR2_powerpc_power8=y
# System
-BR2_BINUTILS_VERSION_2_36_X=y
BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
BR2_SYSTEM_DHCP="eth0"
diff --git a/configs/qemu_ppc64le_pseries_defconfig b/configs/qemu_ppc64le_pseries_defconfig
index 98c6afdf9399..5eaa3e953f78 100644
--- a/configs/qemu_ppc64le_pseries_defconfig
+++ b/configs/qemu_ppc64le_pseries_defconfig
@@ -3,7 +3,6 @@ BR2_powerpc64le=y
BR2_powerpc_power8=y
# System
-BR2_BINUTILS_VERSION_2_36_X=y
BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
BR2_SYSTEM_DHCP="eth0"
--
2.37.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1"
2022-09-24 21:41 [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1" Cédric Le Goater
@ 2022-09-25 12:40 ` Yann E. MORIN
2022-09-25 13:20 ` Cédric Le Goater
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-09-25 12:40 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: Joel Stanley, buildroot
Cédric, All,
On 2022-09-24 23:41 +0200, Cédric Le Goater spake thusly:
> This reverts commit 1e2fe860f3a261fc877591c056808d6fb30e25d4.
This is not really a revert, so I did some changes:
- explictily force binutils 2.38
- reword commit log to explain why
- reword commit log: it's not really a revert
> The default 2.38.x has the required fixes.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to master with the above changes, thanks.
Regards,
Yann E. MORIN.
> ---
>
> https://gitlab.com/legoater/buildroot/-/pipelines/649723598
>
> configs/qemu_ppc64_e5500_defconfig | 1 -
> configs/qemu_ppc64_pseries_defconfig | 1 -
> configs/qemu_ppc64le_powernv8_defconfig | 1 -
> configs/qemu_ppc64le_pseries_defconfig | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/configs/qemu_ppc64_e5500_defconfig b/configs/qemu_ppc64_e5500_defconfig
> index 8458f2739a66..0825d0ab9b30 100644
> --- a/configs/qemu_ppc64_e5500_defconfig
> +++ b/configs/qemu_ppc64_e5500_defconfig
> @@ -3,7 +3,6 @@ BR2_powerpc64=y
> BR2_powerpc_e5500=y
>
> # System
> -BR2_BINUTILS_VERSION_2_36_X=y
> BR2_SYSTEM_DHCP="eth0"
> BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
>
> diff --git a/configs/qemu_ppc64_pseries_defconfig b/configs/qemu_ppc64_pseries_defconfig
> index 480ebea29d70..c45014f2ac3f 100644
> --- a/configs/qemu_ppc64_pseries_defconfig
> +++ b/configs/qemu_ppc64_pseries_defconfig
> @@ -3,7 +3,6 @@ BR2_powerpc64=y
> BR2_powerpc_power7=y
>
> # System
> -BR2_BINUTILS_VERSION_2_36_X=y
> BR2_SYSTEM_DHCP="eth0"
> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>
> diff --git a/configs/qemu_ppc64le_powernv8_defconfig b/configs/qemu_ppc64le_powernv8_defconfig
> index 8de4cf5189b5..822145e927a1 100644
> --- a/configs/qemu_ppc64le_powernv8_defconfig
> +++ b/configs/qemu_ppc64le_powernv8_defconfig
> @@ -3,7 +3,6 @@ BR2_powerpc64le=y
> BR2_powerpc_power8=y
>
> # System
> -BR2_BINUTILS_VERSION_2_36_X=y
> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
> BR2_SYSTEM_DHCP="eth0"
>
> diff --git a/configs/qemu_ppc64le_pseries_defconfig b/configs/qemu_ppc64le_pseries_defconfig
> index 98c6afdf9399..5eaa3e953f78 100644
> --- a/configs/qemu_ppc64le_pseries_defconfig
> +++ b/configs/qemu_ppc64le_pseries_defconfig
> @@ -3,7 +3,6 @@ BR2_powerpc64le=y
> BR2_powerpc_power8=y
>
> # System
> -BR2_BINUTILS_VERSION_2_36_X=y
> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
> BR2_SYSTEM_DHCP="eth0"
>
> --
> 2.37.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1"
2022-09-25 12:40 ` Yann E. MORIN
@ 2022-09-25 13:20 ` Cédric Le Goater
2022-09-25 13:38 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Cédric Le Goater @ 2022-09-25 13:20 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Joel Stanley, buildroot
On 9/25/22 14:40, Yann E. MORIN wrote:
> Cédric, All,
>
> On 2022-09-24 23:41 +0200, Cédric Le Goater spake thusly:
>> This reverts commit 1e2fe860f3a261fc877591c056808d6fb30e25d4.
>
> This is not really a revert,
This is the result of the command :
git revert -s 1e2fe860f3a2
So it is "really" a revert :)
> so I did some changes:
>
> - explictily force binutils 2.38
I guess this is to make sure that 2.37 is not selected but when
the current 2.38 is deprecated, all defconfigs will require an
update. Since the default works fine, I don't think it is worth
adding an extra dependency (until next breakage) or we could use
a !2.37 dependency instead. I am not sure if this is possible
though.
> - reword commit log to explain why
ok but that's in commit 1e2fe860f3a2 already. As you wish.
> - reword commit log: it's not really a revert
>
>
>> The default 2.38.x has the required fixes.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>
> Applied to master with the above changes, thanks.
Thanks,
C.
> Regards,
> Yann E. MORIN.
>
>> ---
>>
>> https://gitlab.com/legoater/buildroot/-/pipelines/649723598
>>
>> configs/qemu_ppc64_e5500_defconfig | 1 -
>> configs/qemu_ppc64_pseries_defconfig | 1 -
>> configs/qemu_ppc64le_powernv8_defconfig | 1 -
>> configs/qemu_ppc64le_pseries_defconfig | 1 -
>> 4 files changed, 4 deletions(-)
>>
>> diff --git a/configs/qemu_ppc64_e5500_defconfig b/configs/qemu_ppc64_e5500_defconfig
>> index 8458f2739a66..0825d0ab9b30 100644
>> --- a/configs/qemu_ppc64_e5500_defconfig
>> +++ b/configs/qemu_ppc64_e5500_defconfig
>> @@ -3,7 +3,6 @@ BR2_powerpc64=y
>> BR2_powerpc_e5500=y
>>
>> # System
>> -BR2_BINUTILS_VERSION_2_36_X=y
>> BR2_SYSTEM_DHCP="eth0"
>> BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
>>
>> diff --git a/configs/qemu_ppc64_pseries_defconfig b/configs/qemu_ppc64_pseries_defconfig
>> index 480ebea29d70..c45014f2ac3f 100644
>> --- a/configs/qemu_ppc64_pseries_defconfig
>> +++ b/configs/qemu_ppc64_pseries_defconfig
>> @@ -3,7 +3,6 @@ BR2_powerpc64=y
>> BR2_powerpc_power7=y
>>
>> # System
>> -BR2_BINUTILS_VERSION_2_36_X=y
>> BR2_SYSTEM_DHCP="eth0"
>> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>>
>> diff --git a/configs/qemu_ppc64le_powernv8_defconfig b/configs/qemu_ppc64le_powernv8_defconfig
>> index 8de4cf5189b5..822145e927a1 100644
>> --- a/configs/qemu_ppc64le_powernv8_defconfig
>> +++ b/configs/qemu_ppc64le_powernv8_defconfig
>> @@ -3,7 +3,6 @@ BR2_powerpc64le=y
>> BR2_powerpc_power8=y
>>
>> # System
>> -BR2_BINUTILS_VERSION_2_36_X=y
>> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>> BR2_SYSTEM_DHCP="eth0"
>>
>> diff --git a/configs/qemu_ppc64le_pseries_defconfig b/configs/qemu_ppc64le_pseries_defconfig
>> index 98c6afdf9399..5eaa3e953f78 100644
>> --- a/configs/qemu_ppc64le_pseries_defconfig
>> +++ b/configs/qemu_ppc64le_pseries_defconfig
>> @@ -3,7 +3,6 @@ BR2_powerpc64le=y
>> BR2_powerpc_power8=y
>>
>> # System
>> -BR2_BINUTILS_VERSION_2_36_X=y
>> BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>> BR2_SYSTEM_DHCP="eth0"
>>
>> --
>> 2.37.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1"
2022-09-25 13:20 ` Cédric Le Goater
@ 2022-09-25 13:38 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-09-25 13:38 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: Joel Stanley, buildroot
Cédric, All,
On 2022-09-25 15:20 +0200, Cédric Le Goater spake thusly:
> On 9/25/22 14:40, Yann E. MORIN wrote:
> >On 2022-09-24 23:41 +0200, Cédric Le Goater spake thusly:
> >>This reverts commit 1e2fe860f3a261fc877591c056808d6fb30e25d4.
> >This is not really a revert,
> This is the result of the command :
> git revert -s 1e2fe860f3a2
> So it is "really" a revert :)
Yes, it is a git-revert, i.e. ity is a tchnical revert.
However, a git-revert really means "that commit was wrong back at the
time, undo it". But in this case, the commit was correct, so we do not
want to git-revert it; at least, we do not want to inscribe in our git
log that this is a revert.
Instead, the conditions around have changed, which allows using the old
"code" (defconfig values in this case) again.
> >so I did some changes:
> > - explictily force binutils 2.38
> I guess this is to make sure that 2.37 is not selected but when
> the current 2.38 is deprecated, all defconfigs will require an
> update. Since the default works fine, I don't think it is worth
> adding an extra dependency (until next breakage) or we could use
> a !2.37 dependency instead. I am not sure if this is possible
> though.
When we drop 2.38, having it referenced in the defconfig will help us
notice that something must be taken care of, and looking at the git log
will help us take a decision (keep the version around, bump the
defconfig, etc..)
In the defconfigs, we do not want to use the defaults; we want to use
explicit versions.
Granted, this is not always enforced, and the defconfigs we have are of
variable level of using explicit versions even if the default; this is
mostly the case for the kernel headers, though.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-25 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-24 21:41 [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1" Cédric Le Goater
2022-09-25 12:40 ` Yann E. MORIN
2022-09-25 13:20 ` Cédric Le Goater
2022-09-25 13:38 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).