* [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled
@ 2023-07-16 13:55 Bernd Kuhls
2023-07-22 21:28 ` Thomas Petazzoni via buildroot
2023-08-29 20:00 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2023-07-16 13:55 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Ezequiel Garcia
The wiiuse code force an out-of-tree build:
https://github.com/supertuxkart/stk-code/blob/master/lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake#L41
Fixes a build error not yet caught by the autobuilders:
-- Configuring WiiUse version 0.15.5
CMake Error at lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake:41 (message):
You must set a binary directory that is different from your source
directory. You might consider
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
package/supertuxkart/supertuxkart.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/supertuxkart/supertuxkart.mk b/package/supertuxkart/supertuxkart.mk
index 1f9ad4102b..6bdd512eac 100644
--- a/package/supertuxkart/supertuxkart.mk
+++ b/package/supertuxkart/supertuxkart.mk
@@ -44,6 +44,7 @@ SUPERTUXKART_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF \
ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
SUPERTUXKART_DEPENDENCIES += bluez5_utils
SUPERTUXKART_CONF_OPTS += -DUSE_WIIUSE=ON -DUSE_SYSTEM_WIIUSE=ON
+SUPERTUXKART_SUPPORTS_IN_SOURCE_BUILD = NO
else
# Wiimote support relies on bluez5.
SUPERTUXKART_CONF_OPTS += -DUSE_WIIUSE=OFF
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled
2023-07-16 13:55 [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled Bernd Kuhls
@ 2023-07-22 21:28 ` Thomas Petazzoni via buildroot
2023-08-29 20:00 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-22 21:28 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Romain Naour, Ezequiel Garcia, buildroot
Hello Bernd,
On Sun, 16 Jul 2023 15:55:57 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> The wiiuse code force an out-of-tree build:
> https://github.com/supertuxkart/stk-code/blob/master/lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake#L41
>
> Fixes a build error not yet caught by the autobuilders:
>
> -- Configuring WiiUse version 0.15.5
> CMake Error at lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake:41 (message):
> You must set a binary directory that is different from your source
> directory. You might consider
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/supertuxkart/supertuxkart.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/supertuxkart/supertuxkart.mk b/package/supertuxkart/supertuxkart.mk
> index 1f9ad4102b..6bdd512eac 100644
> --- a/package/supertuxkart/supertuxkart.mk
> +++ b/package/supertuxkart/supertuxkart.mk
> @@ -44,6 +44,7 @@ SUPERTUXKART_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF \
> ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
> SUPERTUXKART_DEPENDENCIES += bluez5_utils
> SUPERTUXKART_CONF_OPTS += -DUSE_WIIUSE=ON -DUSE_SYSTEM_WIIUSE=ON
> +SUPERTUXKART_SUPPORTS_IN_SOURCE_BUILD = NO
I was not really sure if putting this variable within a conditional was
a good idea. Normally a package either requires out-of-tree build or
doesn't care, and it's probably the first time we have a package that
sometimes requires it, sometimes doesn't. But as it reflects the
reality, I've applied your patch as-is. We'll see if other maintainers
disagree, which I would totally understand.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled
2023-07-16 13:55 [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled Bernd Kuhls
2023-07-22 21:28 ` Thomas Petazzoni via buildroot
@ 2023-08-29 20:00 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-08-29 20:00 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Romain Naour, Ezequiel Garcia, buildroot
>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:
> The wiiuse code force an out-of-tree build:
> https://github.com/supertuxkart/stk-code/blob/master/lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake#L41
> Fixes a build error not yet caught by the autobuilders:
> -- Configuring WiiUse version 0.15.5
> CMake Error at lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake:41 (message):
> You must set a binary directory that is different from your source
> directory. You might consider
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-29 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-16 13:55 [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled Bernd Kuhls
2023-07-22 21:28 ` Thomas Petazzoni via buildroot
2023-08-29 20:00 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).