[Buildroot] [PATCH 1/1] package/libmad: force arm mode instead of Thumb mode

[Buildroot] [PATCH 1/1] package/libmad: force arm mode instead of Thumb mode

[Fabrice Fontaine]

Fix the following build failure:

/tmp/ccv8mDeW.s:93: Error: selected processor does not support `smull r6,r7,r3,r1' in Thumb mode

Fixes:
 - http://autobuild.buildroot.org/results/92a3f19b4fa12a7724f9e3d99284da4ad2beecb2

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libmad/libmad.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libmad/libmad.mk b/package/libmad/libmad.mk
index 684b8a2261..5555bf5a36 100644
--- a/package/libmad/libmad.mk
+++ b/package/libmad/libmad.mk
@@ -32,6 +32,13 @@ LIBMAD_IGNORE_CVES += CVE-2017-8374
 # is able to properly behave in the face of a missing C++ compiler.
 LIBMAD_AUTORECONF = YES
 
+# libmad has some assembly function that is not present in Thumb mode:
+# Error: selected processor does not support `smull r6,r7,r3,r1' in Thumb mode
+# so, we desactivate Thumb mode
+ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
+LIBMAD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
+endif
+
 define LIBMAD_INSTALL_STAGING_PC
 	$(INSTALL) -D package/libmad/mad.pc \
 		$(STAGING_DIR)/usr/lib/pkgconfig/mad.pc
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmad: force arm mode instead of Thumb mode

[Arnout Vandecappelle]

On 23/02/2023 23:25, Fabrice Fontaine wrote:
> Fix the following build failure:
> 
> /tmp/ccv8mDeW.s:93: Error: selected processor does not support `smull r6,r7,r3,r1' in Thumb mode
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/92a3f19b4fa12a7724f9e3d99284da4ad2beecb2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/libmad/libmad.mk | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/package/libmad/libmad.mk b/package/libmad/libmad.mk
> index 684b8a2261..5555bf5a36 100644
> --- a/package/libmad/libmad.mk
> +++ b/package/libmad/libmad.mk
> @@ -32,6 +32,13 @@ LIBMAD_IGNORE_CVES += CVE-2017-8374
>   # is able to properly behave in the face of a missing C++ compiler.
>   LIBMAD_AUTORECONF = YES
>   
> +# libmad has some assembly function that is not present in Thumb mode:
> +# Error: selected processor does not support `smull r6,r7,r3,r1' in Thumb mode
> +# so, we desactivate Thumb mode
> +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> +LIBMAD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
> +endif

  Applied to master, thanks.

  Regards,
  Arnout

> +
>   define LIBMAD_INSTALL_STAGING_PC
>   	$(INSTALL) -D package/libmad/mad.pc \
>   		$(STAGING_DIR)/usr/lib/pkgconfig/mad.pc
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmad: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure:
 > /tmp/ccv8mDeW.s:93: Error: selected processor does not support `smull r6,r7,r3,r1' in Thumb mode

 > Fixes:
 >  - http://autobuild.buildroot.org/results/92a3f19b4fa12a7724f9e3d99284da4ad2beecb2

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot