* [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options
@ 2022-09-11 19:57 Giulio Benetti
2022-09-11 20:18 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2022-09-11 19:57 UTC (permalink / raw)
To: buildroot; +Cc: Louis Aussedat, Giulio Benetti
This driver requires CONFIG_CFG80211 and CONFIG_MMC to build so let's add
them to RTL8189ES_LINUX_CONFIG_FIXUPS.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8189es/rtl8189es.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/rtl8189es/rtl8189es.mk b/package/rtl8189es/rtl8189es.mk
index 51477ccc97..a283852a11 100644
--- a/package/rtl8189es/rtl8189es.mk
+++ b/package/rtl8189es/rtl8189es.mk
@@ -13,5 +13,10 @@ RTL8189ES_MODULE_MAKE_OPTS = \
KVER=$(LINUX_VERSION_PROBED) \
KSRC=$(LINUX_DIR)
+define RTL8189ES_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+endef
+
$(eval $(kernel-module))
$(eval $(generic-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options
2022-09-11 19:57 [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options Giulio Benetti
@ 2022-09-11 20:18 ` Yann E. MORIN
2022-09-11 20:36 ` Giulio Benetti
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-09-11 20:18 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Louis Aussedat, buildroot
Giulio, All,
On 2022-09-11 21:57 +0200, Giulio Benetti spake thusly:
> This driver requires CONFIG_CFG80211 and CONFIG_MMC to build so let's add
> them to RTL8189ES_LINUX_CONFIG_FIXUPS.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/rtl8189es/rtl8189es.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/rtl8189es/rtl8189es.mk b/package/rtl8189es/rtl8189es.mk
> index 51477ccc97..a283852a11 100644
> --- a/package/rtl8189es/rtl8189es.mk
> +++ b/package/rtl8189es/rtl8189es.mk
> @@ -13,5 +13,10 @@ RTL8189ES_MODULE_MAKE_OPTS = \
> KVER=$(LINUX_VERSION_PROBED) \
> KSRC=$(LINUX_DIR)
>
> +define RTL8189ES_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
Symbol: CFG80211 [=m]
Type : tristate
Defined at net/wireless/Kconfig:20
Prompt: cfg80211 - wireless configuration API
Depends on: NET [=y] && WIRELESS [=y] && (RFKILL [=y] || !RFKILL [=y])
So we need NET and WIRELESS (RFKILL is just to avoid it as a module).
WIRELESS depends on !s390, so rtl8189es should also not be available for
BR2_s390x, but that's rthogonal to this change.
> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
MMC, for a wireless driver? I've loked at the code, and MMC is not
required. It can be used, yes, but it is not required, i.e. the code is
springled with "#ifdef CONFIG_MMC", so it does not look like mandatory
at all.
Regards,
Yann E. MORIN.
> +endef
> +
> $(eval $(kernel-module))
> $(eval $(generic-package))
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options
2022-09-11 20:18 ` Yann E. MORIN
@ 2022-09-11 20:36 ` Giulio Benetti
2022-09-11 21:42 ` [Buildroot] [PATCH v2] " Giulio Benetti
0 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2022-09-11 20:36 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Louis Aussedat, buildroot
Hi Yann,
On 11/09/22 22:18, Yann E. MORIN wrote:
> Giulio, All,
>
> On 2022-09-11 21:57 +0200, Giulio Benetti spake thusly:
>> This driver requires CONFIG_CFG80211 and CONFIG_MMC to build so let's add
>> them to RTL8189ES_LINUX_CONFIG_FIXUPS.
>>
I've forgotten the
Fixes:
http://autobuild.buildroot.net/results/4b7/4b7b5bbf5b3839d99397eb2597dd7be79f403233/
that gives more context
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/rtl8189es/rtl8189es.mk | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/package/rtl8189es/rtl8189es.mk b/package/rtl8189es/rtl8189es.mk
>> index 51477ccc97..a283852a11 100644
>> --- a/package/rtl8189es/rtl8189es.mk
>> +++ b/package/rtl8189es/rtl8189es.mk
>> @@ -13,5 +13,10 @@ RTL8189ES_MODULE_MAKE_OPTS = \
>> KVER=$(LINUX_VERSION_PROBED) \
>> KSRC=$(LINUX_DIR)
>>
>> +define RTL8189ES_LINUX_CONFIG_FIXUPS
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
>
> Symbol: CFG80211 [=m]
> Type : tristate
> Defined at net/wireless/Kconfig:20
> Prompt: cfg80211 - wireless configuration API
> Depends on: NET [=y] && WIRELESS [=y] && (RFKILL [=y] || !RFKILL [=y])
>
> So we need NET and WIRELESS (RFKILL is just to avoid it as a module).
Aaah right!
So here I need:
```
CONFIG_NET
CONFIG_WIRELESS
```
and
> WIRELESS depends on !s390, so rtl8189es should also not be available for
> BR2_s390x, but that's rthogonal to this change.
>
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
>
> MMC, for a wireless driver? I've loked at the code, and MMC is not
> required. It can be used, yes, but it is not required, i.e. the code is
> springled with "#ifdef CONFIG_MMC", so it does not look like mandatory
> at all.
CONFIG_MMC is needed for SDIO interface and rtl8189es is driven with SDIO:
https://www.realtek.com/en/products/communications-network-ics/item/rtl8189es
And all the sdio_() APIs not found are enabled enabling CONFIG_MMC:
https://elixir.bootlin.com/linux/latest/source/drivers/mmc/core/Makefile#L7
```
obj-$(CONFIG_MMC) += mmc_core.o
mmc_core-y := sdio.o sdio_ops.o ...
```
The upstream driver also covers other Realtek chips, that's why
CONFIG_MMC is optional.
So the result should be:
```
CONFIG_NET
CONFIG_WIRELESS
CONFIG_MMC
```
Right?
Best regards
--
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/rtl8189es: fix build failure due to missing Linux options
2022-09-11 20:36 ` Giulio Benetti
@ 2022-09-11 21:42 ` Giulio Benetti
2022-09-17 15:27 ` Thomas Petazzoni
2022-09-25 20:46 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Giulio Benetti @ 2022-09-11 21:42 UTC (permalink / raw)
To: buildroot; +Cc: Louis Aussedat, Giulio Benetti, Yann E . MORIN
This driver requires:
CONFIG_NET
CONFIG_WIRELESS
CONFIG_CFG80211
CONFIG_MMC
to build so let's add them to RTL8189ES_LINUX_CONFIG_FIXUPS.
Fixes:
http://autobuild.buildroot.net/results/4b7/4b7b5bbf5b3839d99397eb2597dd7be79f403233/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add also CONFIG_NET and CONFIG_WIRELESS to be sure CONFIG_CFG80211 is
selectable
* add Fixes: in commit log
---
package/rtl8189es/rtl8189es.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/rtl8189es/rtl8189es.mk b/package/rtl8189es/rtl8189es.mk
index 51477ccc97..2fa6a3a483 100644
--- a/package/rtl8189es/rtl8189es.mk
+++ b/package/rtl8189es/rtl8189es.mk
@@ -13,5 +13,12 @@ RTL8189ES_MODULE_MAKE_OPTS = \
KVER=$(LINUX_VERSION_PROBED) \
KSRC=$(LINUX_DIR)
+define RTL8189ES_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+endef
+
$(eval $(kernel-module))
$(eval $(generic-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2] package/rtl8189es: fix build failure due to missing Linux options
2022-09-11 21:42 ` [Buildroot] [PATCH v2] " Giulio Benetti
@ 2022-09-17 15:27 ` Thomas Petazzoni
2022-09-25 20:46 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2022-09-17 15:27 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Louis Aussedat, Yann E . MORIN, buildroot
On Sun, 11 Sep 2022 23:42:06 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> This driver requires:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_MMC
> to build so let's add them to RTL8189ES_LINUX_CONFIG_FIXUPS.
>
> Fixes:
> http://autobuild.buildroot.net/results/4b7/4b7b5bbf5b3839d99397eb2597dd7be79f403233/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add also CONFIG_NET and CONFIG_WIRELESS to be sure CONFIG_CFG80211 is
> selectable
> * add Fixes: in commit log
> ---
> package/rtl8189es/rtl8189es.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2] package/rtl8189es: fix build failure due to missing Linux options
2022-09-11 21:42 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-09-17 15:27 ` Thomas Petazzoni
@ 2022-09-25 20:46 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-09-25 20:46 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Louis Aussedat, Yann E . MORIN, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> This driver requires:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_MMC
> to build so let's add them to RTL8189ES_LINUX_CONFIG_FIXUPS.
> Fixes:
> http://autobuild.buildroot.net/results/4b7/4b7b5bbf5b3839d99397eb2597dd7be79f403233/
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
V1-> V2:
> * add also CONFIG_NET and CONFIG_WIRELESS to be sure CONFIG_CFG80211 is
> selectable
> * add Fixes: in commit log
Committed to 2022.02.x, 2022.05.x and 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-25 20:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11 19:57 [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options Giulio Benetti
2022-09-11 20:18 ` Yann E. MORIN
2022-09-11 20:36 ` Giulio Benetti
2022-09-11 21:42 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-09-17 15:27 ` Thomas Petazzoni
2022-09-25 20:46 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).