* [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup
@ 2021-06-14 10:42 John Keeping
2021-07-20 21:49 ` Thomas Petazzoni
2021-08-04 15:17 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: John Keeping @ 2021-06-14 10:42 UTC (permalink / raw)
To: buildroot
The configure script uses pkg-config to detect the location of
tmpfiles.d but imposes an unspecified ordering dependency with systemd.
Instead of relying on systemd being built before cryptsetup, set the
directory path explcitly, and ensure it is not set when systemd-tmpfiles
is disabled.
Signed-off-by: John Keeping <john@metanate.com>
---
package/cryptsetup/cryptsetup.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk
index cd5883d0b4..eee84a7958 100644
--- a/package/cryptsetup/cryptsetup.mk
+++ b/package/cryptsetup/cryptsetup.mk
@@ -33,6 +33,12 @@ else
CRYPTSETUP_CONF_OPTS += --with-crypto_backend=kernel
endif
+ifeq ($(BR2_PACKAGE_SYSTEMD_TMPFILES),y)
+CRYPTSETUP_CONF_OPTS += --with-tmpfilesdir=/usr/lib/tmpfiles.d
+else
+CRYPTSETUP_CONF_OPTS += --with-tmpfilesdir=no
+endif
+
HOST_CRYPTSETUP_DEPENDENCIES = \
host-pkgconf \
host-lvm2 \
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup
2021-06-14 10:42 [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup John Keeping
@ 2021-07-20 21:49 ` Thomas Petazzoni
2021-07-20 21:49 ` Thomas Petazzoni
2021-08-04 15:17 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2021-07-20 21:49 UTC (permalink / raw)
To: buildroot
On Mon, 14 Jun 2021 11:42:10 +0100
John Keeping <john@metanate.com> wrote:
> The configure script uses pkg-config to detect the location of
> tmpfiles.d but imposes an unspecified ordering dependency with systemd.
> Instead of relying on systemd being built before cryptsetup, set the
> directory path explcitly, and ensure it is not set when systemd-tmpfiles
> is disabled.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> package/cryptsetup/cryptsetup.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup
2021-07-20 21:49 ` Thomas Petazzoni
@ 2021-07-20 21:49 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2021-07-20 21:49 UTC (permalink / raw)
To: John Keeping; +Cc: buildroot
On Mon, 14 Jun 2021 11:42:10 +0100
John Keeping <john@metanate.com> wrote:
> The configure script uses pkg-config to detect the location of
> tmpfiles.d but imposes an unspecified ordering dependency with systemd.
> Instead of relying on systemd being built before cryptsetup, set the
> directory path explcitly, and ensure it is not set when systemd-tmpfiles
> is disabled.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> package/cryptsetup/cryptsetup.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup
2021-06-14 10:42 [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup John Keeping
2021-07-20 21:49 ` Thomas Petazzoni
@ 2021-08-04 15:17 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-08-04 15:17 UTC (permalink / raw)
To: John Keeping; +Cc: buildroot
>>>>> "John" == John Keeping <john@metanate.com> writes:
> The configure script uses pkg-config to detect the location of
> tmpfiles.d but imposes an unspecified ordering dependency with systemd.
> Instead of relying on systemd being built before cryptsetup, set the
> directory path explcitly, and ensure it is not set when systemd-tmpfiles
> is disabled.
> Signed-off-by: John Keeping <john@metanate.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-04 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 10:42 [Buildroot] [PATCH] package/cryptsetup: fix tmpfiles.d setup John Keeping
2021-07-20 21:49 ` Thomas Petazzoni
2021-07-20 21:49 ` Thomas Petazzoni
2021-08-04 15:17 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).