buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/luarocks: fix buildroot addon vs 3.3.x
@ 2020-02-08 14:27 Francois Perrad
  2020-02-08 18:55 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Francois Perrad @ 2020-02-08 14:27 UTC (permalink / raw)
  To: buildroot

an internal API change introduced by version 3.3.0 causes the following failure:
```
Error: LuaRocks 3.3.1 bug (please report at https://github.com/luarocks/luarocks/issues).
Arch.: linux-x86_64
.../user/build/qarm/host/share/lua/5.3/luarocks/queries.lua:55: assertion failed!
stack traceback:
	[C]: in function 'assert'
	.../user/build/qarm/host/share/lua/5.3/luarocks/queries.lua:55: in function 'luarocks.queries.new'
	...m/host/share/lua/5.3/luarocks/cmd/external/buildroot.lua:322: in function 'luarocks.cmd.external.buildroot.command'
	(...tail calls...)
	[C]: in function 'xpcall'
	/home/user/build/qarm/host/share/lua/5.3/luarocks/cmd.lua:620: in function 'luarocks.cmd.run_command'
	/home/user/build/qarm/host/bin/luarocks:38: in main chunk
	[C]: in ?
```

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luarocks/buildroot.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/luarocks/buildroot.lua b/package/luarocks/buildroot.lua
index e829b6db0..67dac33aa 100644
--- a/package/luarocks/buildroot.lua
+++ b/package/luarocks/buildroot.lua
@@ -319,7 +319,7 @@ function buildroot.command(args)
    local rockname = assert(args.rockname)
    local fsname = args.brname or rockname
 
-   local query = queries.new(rockname:lower(), nil, false, 'src')
+   local query = queries.new(rockname:lower(), nil, nil, false, 'src')
    local url, err = search.find_suitable_rock(query)
    if not url then
       return nil, "Could not find a result named " .. tostring(query) .. ": " .. err
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/luarocks: fix buildroot addon vs 3.3.x
  2020-02-08 14:27 [Buildroot] [PATCH] package/luarocks: fix buildroot addon vs 3.3.x Francois Perrad
@ 2020-02-08 18:55 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2020-02-08 18:55 UTC (permalink / raw)
  To: buildroot

>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:

 > an internal API change introduced by version 3.3.0 causes the following failure:
 > ```
 > Error: LuaRocks 3.3.1 bug (please report at https://github.com/luarocks/luarocks/issues).
 > Arch.: linux-x86_64
 > .../user/build/qarm/host/share/lua/5.3/luarocks/queries.lua:55: assertion failed!
 > stack traceback:
 > 	[C]: in function 'assert'
 > 	.../user/build/qarm/host/share/lua/5.3/luarocks/queries.lua:55: in function 'luarocks.queries.new'
 > 	...m/host/share/lua/5.3/luarocks/cmd/external/buildroot.lua:322: in function 'luarocks.cmd.external.buildroot.command'
 > 	(...tail calls...)
 > 	[C]: in function 'xpcall'
 > 	/home/user/build/qarm/host/share/lua/5.3/luarocks/cmd.lua:620: in function 'luarocks.cmd.run_command'
 > 	/home/user/build/qarm/host/bin/luarocks:38: in main chunk
 > 	[C]: in ?
 > ```

 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-08 18:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 14:27 [Buildroot] [PATCH] package/luarocks: fix buildroot addon vs 3.3.x Francois Perrad
2020-02-08 18:55 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).