* [Buildroot] [git commit] package/nodejs: don't install nodejs host-tools
@ 2022-09-25 8:19 Thomas Petazzoni
2022-10-11 18:48 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2022-09-25 8:19 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=ec5589611ad79664bc5bf238cc786a65458f3c93
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
The target nodejs package is building those tools, and running them
under Qemu, so it is not necessary for the host variant to install
them.
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/nodejs/nodejs.mk | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 3154dcd7ec..92a9493e25 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -102,13 +102,6 @@ define HOST_NODEJS_CONFIGURE_CMDS
--ninja
endef
-NODEJS_HOST_TOOLS_V8 = \
- torque \
- gen-regexp-special-case \
- bytecode_builtins_list_generator
-NODEJS_HOST_TOOLS_NODE = mkcodecache
-NODEJS_HOST_TOOLS = $(NODEJS_HOST_TOOLS_V8) $(NODEJS_HOST_TOOLS_NODE)
-
HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS)
define HOST_NODEJS_BUILD_CMDS
@@ -121,10 +114,6 @@ define HOST_NODEJS_INSTALL_CMDS
$(HOST_MAKE_ENV) PYTHON=$(HOST_DIR)/bin/python3 \
$(MAKE) -C $(@D) install \
$(HOST_NODEJS_MAKE_OPTS)
-
- $(foreach f,$(NODEJS_HOST_TOOLS), \
- $(INSTALL) -m755 -D $(@D)/out/Release/$(f) $(HOST_DIR)/bin/$(f)
- )
endef
ifeq ($(BR2_i386),y)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [git commit] package/nodejs: don't install nodejs host-tools
2022-09-25 8:19 [Buildroot] [git commit] package/nodejs: don't install nodejs host-tools Thomas Petazzoni
@ 2022-10-11 18:48 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2022-10-11 18:48 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=ec5589611ad79664bc5bf238cc786a65458f3c93
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> The target nodejs package is building those tools, and running them
> under Qemu, so it is not necessary for the host variant to install
> them.
> Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 8:19 [Buildroot] [git commit] package/nodejs: don't install nodejs host-tools Thomas Petazzoni
2022-10-11 18:48 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).