buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/pistache: fix libressl build
@ 2023-02-25 17:28 Fabrice Fontaine
  2023-02-25 21:02 ` Thomas Petazzoni via buildroot
  2023-03-14  8:25 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-02-25 17:28 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

Fix the following libressl build failure which is probably raised since
the addition of the package in commit
65d891efc2fb069f9cf707f47302776f7076b80c:

../src/server/listener.cc: In member function 'void Pistache::Tcp::Listener::setupSSLAuth(const std::string&, const std::string&, int (*)(int, void*))':
../src/server/listener.cc:582:29: error: 'SSL_verify_cb' was not declared in this scope; did you mean 'RSA_verify'?
  582 |                            (SSL_verify_cb)cb
      |                             ^~~~~~~~~~~~~
      |                             RSA_verify

Fixes:
 - http://autobuild.buildroot.org/results/066fc078980e5216f38411eee455088e15fa1101

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...erver-listener.cc-fix-libressl-build.patch | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/pistache/0002-src-server-listener.cc-fix-libressl-build.patch

diff --git a/package/pistache/0002-src-server-listener.cc-fix-libressl-build.patch b/package/pistache/0002-src-server-listener.cc-fix-libressl-build.patch
new file mode 100644
index 0000000000..f2fe2183ae
--- /dev/null
+++ b/package/pistache/0002-src-server-listener.cc-fix-libressl-build.patch
@@ -0,0 +1,38 @@
+From 656bff21c1d20b25058da9dbc27d28ad2ac7ae6e Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sat, 25 Feb 2023 18:09:39 +0100
+Subject: [PATCH] src/server/listener.cc: fix libressl build
+
+Fix the following libressl build failure:
+
+../src/server/listener.cc: In member function 'void Pistache::Tcp::Listener::setupSSLAuth(const std::string&, const std::string&, int (*)(int, void*))':
+../src/server/listener.cc:582:29: error: 'SSL_verify_cb' was not declared in this scope; did you mean 'RSA_verify'?
+  582 |                            (SSL_verify_cb)cb
+      |                             ^~~~~~~~~~~~~
+      |                             RSA_verify
+
+Fixes:
+ - http://autobuild.buildroot.org/results/066fc078980e5216f38411eee455088e15fa1101
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/pistacheio/pistache/pull/1124]
+---
+ src/server/listener.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/server/listener.cc b/src/server/listener.cc
+index 38d2661..c09cb36 100644
+--- a/src/server/listener.cc
++++ b/src/server/listener.cc
+@@ -609,7 +609,7 @@ namespace Pistache::Tcp
+         SSL_CTX_set_verify(GetSSLContext(ssl_ctx_),
+                            SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT | SSL_VERIFY_CLIENT_ONCE,
+ /* Callback type did change in 1.0.1 */
+-#if OPENSSL_VERSION_NUMBER < 0x10100000L
++#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)
+                            (int (*)(int, X509_STORE_CTX*))cb
+ #else
+                            (SSL_verify_cb)cb
+-- 
+2.39.1
+
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/pistache: fix libressl build
  2023-02-25 17:28 [Buildroot] [PATCH 1/1] package/pistache: fix libressl build Fabrice Fontaine
@ 2023-02-25 21:02 ` Thomas Petazzoni via buildroot
  2023-03-14  8:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-25 21:02 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

On Sat, 25 Feb 2023 18:28:06 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following libressl build failure which is probably raised since
> the addition of the package in commit
> 65d891efc2fb069f9cf707f47302776f7076b80c:
> 
> ../src/server/listener.cc: In member function 'void Pistache::Tcp::Listener::setupSSLAuth(const std::string&, const std::string&, int (*)(int, void*))':
> ../src/server/listener.cc:582:29: error: 'SSL_verify_cb' was not declared in this scope; did you mean 'RSA_verify'?
>   582 |                            (SSL_verify_cb)cb
>       |                             ^~~~~~~~~~~~~
>       |                             RSA_verify
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/066fc078980e5216f38411eee455088e15fa1101
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...erver-listener.cc-fix-libressl-build.patch | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 package/pistache/0002-src-server-listener.cc-fix-libressl-build.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/pistache: fix libressl build
  2023-02-25 17:28 [Buildroot] [PATCH 1/1] package/pistache: fix libressl build Fabrice Fontaine
  2023-02-25 21:02 ` Thomas Petazzoni via buildroot
@ 2023-03-14  8:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-03-14  8:25 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following libressl build failure which is probably raised since
 > the addition of the package in commit
 > 65d891efc2fb069f9cf707f47302776f7076b80c:

 > ../src/server/listener.cc: In member function 'void
 > Pistache::Tcp::Listener::setupSSLAuth(const std::string&, const
 > std::string&, int (*)(int, void*))':
 > ../src/server/listener.cc:582:29: error: 'SSL_verify_cb' was not declared in this scope; did you mean 'RSA_verify'?
 >   582 |                            (SSL_verify_cb)cb
 >       |                             ^~~~~~~~~~~~~
 >       |                             RSA_verify

 > Fixes:
 >  - http://autobuild.buildroot.org/results/066fc078980e5216f38411eee455088e15fa1101

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-14  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-25 17:28 [Buildroot] [PATCH 1/1] package/pistache: fix libressl build Fabrice Fontaine
2023-02-25 21:02 ` Thomas Petazzoni via buildroot
2023-03-14  8:25 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).