[Buildroot] [PATCH 1/1] package/network-manager: needs gcc >= 4.9

[Buildroot] [PATCH 1/1] package/network-manager: needs gcc >= 4.9

[Fabrice Fontaine]

network-manager needs gcc >= 4.9 since bump to version 1.32.2 in commit
360d1aad84449c6a1993d8c7e469dc0cd35339a2 to avoid the following build
failure:

src/libnm-core-impl/nm-setting-bond.c: At top level:
src/libnm-core-impl/nm-setting-bond.c:149:5: error: array initialized from non-constant array expression
     NM_MAKE_STRV("stable", "bandwidth", "count");
     ^

Fixes:
 - http://autobuild.buildroot.org/results/dc270ead82707f89d47616a0c18629715c6ea1a5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/network-manager/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
index 7d44768460..38ab43740f 100644
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_NETWORK_MANAGER
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_MMU # dbus
 	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	# Tested with 3.2, but may even work with earlier versions
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
 	depends on BR2_TOOLCHAIN_USES_GLIBC # CLOCK_BOOTTIME, IPTOS_CLASS_*
@@ -61,9 +62,10 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
 
 endif
 
-comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library, wchar, threads"
+comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library, wchar, threads, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_HAS_UDEV || \
 		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
 		!BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \
-		!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+		!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/network-manager: needs gcc >= 4.9

[Arnout Vandecappelle]

On 05/08/2021 10:33, Fabrice Fontaine wrote:
> network-manager needs gcc >= 4.9 since bump to version 1.32.2 in commit
> 360d1aad84449c6a1993d8c7e469dc0cd35339a2 to avoid the following build
> failure:
> 
> src/libnm-core-impl/nm-setting-bond.c: At top level:
> src/libnm-core-impl/nm-setting-bond.c:149:5: error: array initialized from non-constant array expression
>      NM_MAKE_STRV("stable", "bandwidth", "count");
>      ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/dc270ead82707f89d47616a0c18629715c6ea1a5
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/network-manager/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
> index 7d44768460..38ab43740f 100644
> --- a/package/network-manager/Config.in
> +++ b/package/network-manager/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_NETWORK_MANAGER
>  	depends on !BR2_STATIC_LIBS # gnutls
>  	depends on BR2_USE_MMU # dbus
>  	depends on BR2_PACKAGE_HAS_UDEV
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>  	# Tested with 3.2, but may even work with earlier versions
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # CLOCK_BOOTTIME, IPTOS_CLASS_*
> @@ -61,9 +62,10 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
>  
>  endif
>  
> -comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library, wchar, threads"
> +comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library, wchar, threads, gcc >= 4.9"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_PACKAGE_HAS_UDEV || \
>  		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
>  		!BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \
> -		!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +		!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot