buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM
@ 2021-08-24  7:01 Fabrice Fontaine
  2021-08-24 17:23 ` Romain Naour
  2021-08-28 15:54 ` Arnout Vandecappelle
  0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-08-24  7:01 UTC (permalink / raw)
  To: buildroot; +Cc: Bernd Kuhls, Spenser Gilliland, Romain Naour, Fabrice Fontaine

Use BR2_PACKAGE_MESA3D_GBM introduced by commit
b6c051acf787c804e732bc58ba8d7e440701a168

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mesa3d-demos/mesa3d-demos.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mesa3d-demos/mesa3d-demos.mk b/package/mesa3d-demos/mesa3d-demos.mk
index 4289acfffb..6b5262a2e9 100644
--- a/package/mesa3d-demos/mesa3d-demos.mk
+++ b/package/mesa3d-demos/mesa3d-demos.mk
@@ -43,7 +43,7 @@ else
 MESA3D_DEMOS_CONF_OPTS += --disable-vg
 endif
 
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
+ifeq ($(BR2_PACKAGE_MESA3D_GBM),y)
 MESA3D_DEMOS_DEPENDENCIES += mesa3d
 MESA3D_DEMOS_CONF_OPTS += --enable-gbm
 else
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM
  2021-08-24  7:01 [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM Fabrice Fontaine
@ 2021-08-24 17:23 ` Romain Naour
  2021-08-24 19:26   ` Fabrice Fontaine
  2021-08-28 15:54 ` Arnout Vandecappelle
  1 sibling, 1 reply; 4+ messages in thread
From: Romain Naour @ 2021-08-24 17:23 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Bernd Kuhls, Spenser Gilliland

Hello Fabrice,

Le 24/08/2021 à 09:01, Fabrice Fontaine a écrit :
> Use BR2_PACKAGE_MESA3D_GBM introduced by commit
> b6c051acf787c804e732bc58ba8d7e440701a168
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mesa3d-demos/mesa3d-demos.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mesa3d-demos/mesa3d-demos.mk b/package/mesa3d-demos/mesa3d-demos.mk
> index 4289acfffb..6b5262a2e9 100644
> --- a/package/mesa3d-demos/mesa3d-demos.mk
> +++ b/package/mesa3d-demos/mesa3d-demos.mk
> @@ -43,7 +43,7 @@ else
>  MESA3D_DEMOS_CONF_OPTS += --disable-vg
>  endif
>  
> -ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
> +ifeq ($(BR2_PACKAGE_MESA3D_GBM),y)

BR2_PACKAGE_MESA3D_OPENGL_EGL select BR2_PACKAGE_MESA3D_GBM, but
BR2_PACKAGE_MESA3D_GBM can be used without BR2_PACKAGE_MESA3D_OPENGL_EGL.

Have you checked without BR2_PACKAGE_MESA3D_OPENGL_EGL enabled ?

Best regards,
Romain


>  MESA3D_DEMOS_DEPENDENCIES += mesa3d
>  MESA3D_DEMOS_CONF_OPTS += --enable-gbm
>  else
> 

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM
  2021-08-24 17:23 ` Romain Naour
@ 2021-08-24 19:26   ` Fabrice Fontaine
  0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-08-24 19:26 UTC (permalink / raw)
  To: Romain Naour; +Cc: Bernd Kuhls, Spenser Gilliland, Buildroot Mailing List

Hello Romain,

Le mar. 24 août 2021 à 19:23, Romain Naour <romain.naour@gmail.com> a écrit :
>
> Hello Fabrice,
>
> Le 24/08/2021 à 09:01, Fabrice Fontaine a écrit :
> > Use BR2_PACKAGE_MESA3D_GBM introduced by commit
> > b6c051acf787c804e732bc58ba8d7e440701a168
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/mesa3d-demos/mesa3d-demos.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/mesa3d-demos/mesa3d-demos.mk b/package/mesa3d-demos/mesa3d-demos.mk
> > index 4289acfffb..6b5262a2e9 100644
> > --- a/package/mesa3d-demos/mesa3d-demos.mk
> > +++ b/package/mesa3d-demos/mesa3d-demos.mk
> > @@ -43,7 +43,7 @@ else
> >  MESA3D_DEMOS_CONF_OPTS += --disable-vg
> >  endif
> >
> > -ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
> > +ifeq ($(BR2_PACKAGE_MESA3D_GBM),y)
>
> BR2_PACKAGE_MESA3D_OPENGL_EGL select BR2_PACKAGE_MESA3D_GBM, but
> BR2_PACKAGE_MESA3D_GBM can be used without BR2_PACKAGE_MESA3D_OPENGL_EGL.
>
> Have you checked without BR2_PACKAGE_MESA3D_OPENGL_EGL enabled ?
Yes,  mesa3d-demos is building fine with a DRI driver (i.e. with
BR2_PACKAGE_MESA3D_GBM but without BR2_PACKAGE_MESA3D_OPENGL_EGL).
However, I would advise to apply this commit for next instead of master.
>
> Best regards,
> Romain
>
>
> >  MESA3D_DEMOS_DEPENDENCIES += mesa3d
> >  MESA3D_DEMOS_CONF_OPTS += --enable-gbm
> >  else
> >
>
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM
  2021-08-24  7:01 [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM Fabrice Fontaine
  2021-08-24 17:23 ` Romain Naour
@ 2021-08-28 15:54 ` Arnout Vandecappelle
  1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-08-28 15:54 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Bernd Kuhls, Spenser Gilliland, Romain Naour



On 24/08/2021 09:01, Fabrice Fontaine wrote:
> Use BR2_PACKAGE_MESA3D_GBM introduced by commit
> b6c051acf787c804e732bc58ba8d7e440701a168
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to next, and the other two similar commits as well.

 There are a bunch of other packages still with a similar situation: kmscube,
qt5base, waffle, weston, xdriver_xf86-video-amdgpu. Of course, all of them
should be tested with DRI as well...

 Regards,
 Arnout

> ---
>  package/mesa3d-demos/mesa3d-demos.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mesa3d-demos/mesa3d-demos.mk b/package/mesa3d-demos/mesa3d-demos.mk
> index 4289acfffb..6b5262a2e9 100644
> --- a/package/mesa3d-demos/mesa3d-demos.mk
> +++ b/package/mesa3d-demos/mesa3d-demos.mk
> @@ -43,7 +43,7 @@ else
>  MESA3D_DEMOS_CONF_OPTS += --disable-vg
>  endif
>  
> -ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
> +ifeq ($(BR2_PACKAGE_MESA3D_GBM),y)
>  MESA3D_DEMOS_DEPENDENCIES += mesa3d
>  MESA3D_DEMOS_CONF_OPTS += --enable-gbm
>  else
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-28 15:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24  7:01 [Buildroot] [PATCH 1/1] package/mesa3d-demos: use BR2_PACKAGE_MESA3D_GBM Fabrice Fontaine
2021-08-24 17:23 ` Romain Naour
2021-08-24 19:26   ` Fabrice Fontaine
2021-08-28 15:54 ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).