* [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency
@ 2021-08-04 20:44 Fabrice Fontaine
2021-08-05 3:46 ` Petr Vorel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-08-04 20:44 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
gobject-introspection is an optional dependency (enabled by default)
since the addition of the package in commit
ea64e05a1bfbe3b258a69013462f94d7db7a9c0b
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libqrtr-glib/libqrtr-glib.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/libqrtr-glib/libqrtr-glib.mk b/package/libqrtr-glib/libqrtr-glib.mk
index b9fc5cf3ba..6ab8335417 100644
--- a/package/libqrtr-glib/libqrtr-glib.mk
+++ b/package/libqrtr-glib/libqrtr-glib.mk
@@ -12,4 +12,11 @@ LIBQRTR_GLIB_LICENSE_FILES = COPYING.LIB
LIBQRTR_GLIB_INSTALL_STAGING = YES
LIBQRTR_GLIB_DEPENDENCIES = libglib2
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+LIBQRTR_GLIB_CONF_OPTS += --enable-introspection
+LIBQRTR_GLIB_DEPENDENCIES += gobject-introspection
+else
+LIBQRTR_GLIB_CONF_OPTS += --disable-introspection
+endif
+
$(eval $(autotools-package))
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency
2021-08-04 20:44 [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency Fabrice Fontaine
@ 2021-08-05 3:46 ` Petr Vorel
2021-08-05 21:46 ` Thomas Petazzoni
2021-08-08 19:13 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-08-05 3:46 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Hi Fabrice,
> gobject-introspection is an optional dependency (enabled by default)
> since the addition of the package in commit
> ea64e05a1bfbe3b258a69013462f94d7db7a9c0b
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libqrtr-glib/libqrtr-glib.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/package/libqrtr-glib/libqrtr-glib.mk b/package/libqrtr-glib/libqrtr-glib.mk
> index b9fc5cf3ba..6ab8335417 100644
> --- a/package/libqrtr-glib/libqrtr-glib.mk
> +++ b/package/libqrtr-glib/libqrtr-glib.mk
> @@ -12,4 +12,11 @@ LIBQRTR_GLIB_LICENSE_FILES = COPYING.LIB
> LIBQRTR_GLIB_INSTALL_STAGING = YES
> LIBQRTR_GLIB_DEPENDENCIES = libglib2
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +LIBQRTR_GLIB_CONF_OPTS += --enable-introspection
> +LIBQRTR_GLIB_DEPENDENCIES += gobject-introspection
> +else
> +LIBQRTR_GLIB_CONF_OPTS += --disable-introspection
> +endif
> +
> $(eval $(autotools-package))
Thanks a lot for fixing it!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency
2021-08-04 20:44 [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency Fabrice Fontaine
2021-08-05 3:46 ` Petr Vorel
@ 2021-08-05 21:46 ` Thomas Petazzoni
2021-08-08 19:13 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2021-08-05 21:46 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Wed, 4 Aug 2021 22:44:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> gobject-introspection is an optional dependency (enabled by default)
> since the addition of the package in commit
> ea64e05a1bfbe3b258a69013462f94d7db7a9c0b
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libqrtr-glib/libqrtr-glib.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency
2021-08-04 20:44 [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency Fabrice Fontaine
2021-08-05 3:46 ` Petr Vorel
2021-08-05 21:46 ` Thomas Petazzoni
@ 2021-08-08 19:13 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-08-08 19:13 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> gobject-introspection is an optional dependency (enabled by default)
> since the addition of the package in commit
> ea64e05a1bfbe3b258a69013462f94d7db7a9c0b
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-08 19:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 20:44 [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency Fabrice Fontaine
2021-08-05 3:46 ` Petr Vorel
2021-08-05 21:46 ` Thomas Petazzoni
2021-08-08 19:13 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).