* [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32
@ 2021-08-05 11:21 Fabrice Fontaine
2021-08-05 19:18 ` Arnout Vandecappelle
2021-08-08 9:52 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-08-05 11:21 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Romain Naour, Fabrice Fontaine
xlib_libxshmfence unconditionally uses SYS_futex which raises the
following build failure on riscv32:
xshmfence_futex.h:58:17: error: 'SYS_futex' undeclared (first use in this function); did you mean 'sys_futex'?
58 | return syscall(SYS_futex, addr1, op, val1, timeout, addr2, val3);
| ^~~~~~~~~
| sys_futex
Fixes:
- http://autobuild.buildroot.org/results/b3523e35fde0fac04b96a6278cbc6ffdfe56f7d1
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/mesa3d/Config.in | 3 ++-
package/x11r7/xlib_libxshmfence/Config.in | 1 +
package/x11r7/xserver_xorg-server/Config.in | 3 ++-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 41c90c49af..eb7c1eef46 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -65,7 +65,8 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER
!BR2_PACKAGE_MESA3D_OPENGL_GLX && \
!BR2_PACKAGE_MESA3D_OPENGL_EGL
select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
- (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)
+ (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4 && \
+ !BR2_RISCV_32)
config BR2_PACKAGE_MESA3D_VULKAN_DRIVER
bool
diff --git a/package/x11r7/xlib_libxshmfence/Config.in b/package/x11r7/xlib_libxshmfence/Config.in
index 710476b357..55cd91d1e4 100644
--- a/package/x11r7/xlib_libxshmfence/Config.in
+++ b/package/x11r7/xlib_libxshmfence/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_XLIB_LIBXSHMFENCE
bool "libxshmfence"
+ depends on !BR2_RISCV_32
depends on BR2_TOOLCHAIN_HAS_SYNC_4
select BR2_PACKAGE_XORGPROTO
help
diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index fcd3d0ae00..4dc15435a8 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -53,7 +53,8 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
depends on BR2_INSTALL_LIBSTDCPP
select BR2_PACKAGE_LIBDRM
select BR2_PACKAGE_LIBPCIACCESS
- select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_TOOLCHAIN_HAS_SYNC_4
+ select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
+ (BR2_TOOLCHAIN_HAS_SYNC_4 && !BR2_RISCV_32)
help
This variant of the X.org server is the full-blown variant,
as used by desktop GNU/Linux distributions. The drivers (for
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32
2021-08-05 11:21 [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32 Fabrice Fontaine
@ 2021-08-05 19:18 ` Arnout Vandecappelle
2021-08-08 9:52 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-08-05 19:18 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Bernd Kuhls, Romain Naour
On 05/08/2021 13:21, Fabrice Fontaine wrote:
> xlib_libxshmfence unconditionally uses SYS_futex which raises the
> following build failure on riscv32:
>
> xshmfence_futex.h:58:17: error: 'SYS_futex' undeclared (first use in this function); did you mean 'sys_futex'?
> 58 | return syscall(SYS_futex, addr1, op, val1, timeout, addr2, val3);
> | ^~~~~~~~~
> | sys_futex
The proper way is to add support for futex64, but:
- that's a bit complicated so better for upstream to do;
- Linux on RISCV32 doesn't have much of a future, except on FPGAs which aren't
very likely to run X;
- X itself doesn't have much of a future either;
- we're in the stabilization period so risky patches are to be avoided.
Therefore, applied to master, thanks.
>
> Fixes:
> - http://autobuild.buildroot.org/results/b3523e35fde0fac04b96a6278cbc6ffdfe56f7d1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mesa3d/Config.in | 3 ++-
> package/x11r7/xlib_libxshmfence/Config.in | 1 +
> package/x11r7/xserver_xorg-server/Config.in | 3 ++-
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 41c90c49af..eb7c1eef46 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -65,7 +65,8 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER
> !BR2_PACKAGE_MESA3D_OPENGL_GLX && \
> !BR2_PACKAGE_MESA3D_OPENGL_EGL
> select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
> - (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)
> + (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4 && \
> + !BR2_RISCV_32)
>
> config BR2_PACKAGE_MESA3D_VULKAN_DRIVER
> bool
> diff --git a/package/x11r7/xlib_libxshmfence/Config.in b/package/x11r7/xlib_libxshmfence/Config.in
> index 710476b357..55cd91d1e4 100644
> --- a/package/x11r7/xlib_libxshmfence/Config.in
> +++ b/package/x11r7/xlib_libxshmfence/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_XLIB_LIBXSHMFENCE
> bool "libxshmfence"
> + depends on !BR2_RISCV_32
I added a comment to make it explicit that it can be removed when upstream adds
support for futex64.
Regards,
Arnout
> depends on BR2_TOOLCHAIN_HAS_SYNC_4
> select BR2_PACKAGE_XORGPROTO
> help
> diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
> index fcd3d0ae00..4dc15435a8 100644
> --- a/package/x11r7/xserver_xorg-server/Config.in
> +++ b/package/x11r7/xserver_xorg-server/Config.in
> @@ -53,7 +53,8 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
> depends on BR2_INSTALL_LIBSTDCPP
> select BR2_PACKAGE_LIBDRM
> select BR2_PACKAGE_LIBPCIACCESS
> - select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_TOOLCHAIN_HAS_SYNC_4
> + select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
> + (BR2_TOOLCHAIN_HAS_SYNC_4 && !BR2_RISCV_32)
> help
> This variant of the X.org server is the full-blown variant,
> as used by desktop GNU/Linux distributions. The drivers (for
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32
2021-08-05 11:21 [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32 Fabrice Fontaine
2021-08-05 19:18 ` Arnout Vandecappelle
@ 2021-08-08 9:52 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-08-08 9:52 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, Romain Naour, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> xlib_libxshmfence unconditionally uses SYS_futex which raises the
> following build failure on riscv32:
> xshmfence_futex.h:58:17: error: 'SYS_futex' undeclared (first use in
> this function); did you mean 'sys_futex'?
> 58 | return syscall(SYS_futex, addr1, op, val1, timeout, addr2, val3);
> | ^~~~~~~~~
> | sys_futex
> Fixes:
> - http://autobuild.buildroot.org/results/b3523e35fde0fac04b96a6278cbc6ffdfe56f7d1
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-08 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 11:21 [Buildroot] [PATCH 1/1] package/x11r7/xlib_libxshmfence: disable on riscv32 Fabrice Fontaine
2021-08-05 19:18 ` Arnout Vandecappelle
2021-08-08 9:52 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).