Re: [Buildroot] [PATCH v3 05/11] package/pkg-cargo.mk: introduce the cargo package infrastructure

[Romain Naour <romain.naour@smile.fr>]

Le 07/01/2022 à 11:44, Yann E. MORIN a écrit :
> Romain, All,
> 
> On 2022-01-07 11:26 +0100, Romain Naour spake thusly:
>> Le 06/01/2022 à 21:59, Thomas Petazzoni a écrit :
>>> From: Patrick Havelange <patrick.havelange@essensium.com>
>>> In order to be package agnostic, the install phase is now using cargo
>>> instead of install. TARGET_CONFIGURE_OPTS is now also set when running
>>> cargo in order to support cross compiling C code within cargo.
>>>
>>> This commit also adds support/download/cargo-post-process to perform
>>> the vendoring on Cargo packages.
>>
>> Download post-processing does't work when we use _OVERRIDE_SRCDIR.
> 
> This is indeed expected: _OVERRIDE_SRCDIR is skipping all the download,
> extract and patch steps.
> 
> Developers that are using an _OVERRIDE_SRCDIR are responsible for
> providing an source tree that is ready to be configured.
> 
> So, this is probably something that should be added to the manual, if it
> is not already there, or to emphasise it if already there:
> 
>     When you are using OVERRIDE_SRCDIR, you are responsible for
>     providing a source tree that is ready to be configured.

I did a try, It's not just adding vendor sources into package sources (in my
case "bat" package).

We have to execute "cargo vendor" from "bat" sources and use CARGO_HOME used by
Buildroot:

CARGO_HOME=$HOST_DIR/share/cargo cargo vendor

Do we want to document this method ?

Best regards,
Romain

> 
> Care to send a patch, please?
> 
> Regards,
> Yann E. MORIN.
> 
>> Maybe we have to make sure that all download of vendor modules are already
>> present in the source directory used by _OVERRIDE_SRCDIR.
>>
>> Best regards,
>> Romain
>>
>>>
>>> The <pkg>_LICENSE variable of cargo packages is expanded with ",
>>> vendored dependencies licenses probably not listed" as currently for
>>> all packages, the licenses of the vendored dependencies are not taken
>>> into account.
>>>
>>> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
>>> [Thomas: add support for host-cargo-package and vendoring]
>>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot