* [Buildroot] [Bug 15745] New: Adding custom user account does nothing when the user table text file dose not have a terminating newline
@ 2023-08-30 22:05 bugzilla
2023-08-31 7:24 ` [Buildroot] [Bug 15745] " bugzilla
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: bugzilla @ 2023-08-30 22:05 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=15745
Bug ID: 15745
Summary: Adding custom user account does nothing when the user
table text file dose not have a terminating newline
Product: buildroot
Version: 2023.02.2
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned@buildroot.uclibc.org
Reporter: yanghao.cheng@aioi-atg.com
CC: buildroot@uclibc.org
Target Milestone: ---
As title
For example,
```text @ package/bar/users_table.txt
foo -2 foo -2 =foo /home/foo /bin/bash - Foo user
```
When configure buildroot to use this user table according to the manual, log
shows that the content is being copied to the master user table:
_________________________________________________________________________
> cat package/bar/users_table.txt >> /home/yanghao/open-source/buildroot/buildroot/output/build/buildroot-fs/full_users_table.txt
>
> /yanghao/open-source/buildroot/buildroot/support/scripts/mkusers /home/yanghao/open-source/buildroot/buildroot/output/build/buildroot-fs/full_users_table.txt /home/yanghao/open-source/buildroot/buildroot/output/build/buildroot-fs/ext2/target >> /home/yanghao/open-source/buildroot/buildroot/output/build/buildroot-fs/ext2/fakeroot
__________________________________________________________________________
However, no user is created in the resulting filesystem.
Adding a newline at the end fixes it and works as expected.
```text
foo -2 foo -2 =foo /home/foo /bin/bash - Foo user
```
In the end, I think this is a bug because it is not mentioned in the manual
Chapter 26. Makeusers syntax documentation and 9.6. Adding custom user
accounts.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 15745] Adding custom user account does nothing when the user table text file dose not have a terminating newline
2023-08-30 22:05 [Buildroot] [Bug 15745] New: Adding custom user account does nothing when the user table text file dose not have a terminating newline bugzilla
@ 2023-08-31 7:24 ` bugzilla
2023-08-31 17:48 ` bugzilla
2023-08-31 17:49 ` bugzilla
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla @ 2023-08-31 7:24 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=15745
--- Comment #1 from Edgar Bonet <bonet@grenoble.cnrs.fr> ---
> Adding a newline at the end fixes it and works as expected.
Do you mean that the file should end with *two* newline characters?
Note that, in a Unix environment, a text file is by definition a
sequence of LF-terminated lines of text. This implies that a non-empty
file that does not end with an LF character is not a valid text file.
The manual does mention that users tables are “regular text files”. If
the user account creation fails to parse an invalid text file, I would
not consider it a bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 15745] Adding custom user account does nothing when the user table text file dose not have a terminating newline
2023-08-30 22:05 [Buildroot] [Bug 15745] New: Adding custom user account does nothing when the user table text file dose not have a terminating newline bugzilla
2023-08-31 7:24 ` [Buildroot] [Bug 15745] " bugzilla
@ 2023-08-31 17:48 ` bugzilla
2023-08-31 17:49 ` bugzilla
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla @ 2023-08-31 17:48 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=15745
--- Comment #2 from yanghao.cheng@aioi-atg.com ---
Okay... I meant only one LF is needed.
I've to admit that I don't know the definition exactly although I have seen
software that marks non-LF terminated files as questionable.
Thank you for letting me know and I will close this ticket.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 15745] Adding custom user account does nothing when the user table text file dose not have a terminating newline
2023-08-30 22:05 [Buildroot] [Bug 15745] New: Adding custom user account does nothing when the user table text file dose not have a terminating newline bugzilla
2023-08-31 7:24 ` [Buildroot] [Bug 15745] " bugzilla
2023-08-31 17:48 ` bugzilla
@ 2023-08-31 17:49 ` bugzilla
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla @ 2023-08-31 17:49 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=15745
yanghao.cheng@aioi-atg.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-31 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 22:05 [Buildroot] [Bug 15745] New: Adding custom user account does nothing when the user table text file dose not have a terminating newline bugzilla
2023-08-31 7:24 ` [Buildroot] [Bug 15745] " bugzilla
2023-08-31 17:48 ` bugzilla
2023-08-31 17:49 ` bugzilla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).