All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, sudeep.holla@arm.com,
	cristian.marussi@arm.com, rjw@rjwysocki.net,
	nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed
Date: Wed, 4 Aug 2021 11:51:56 +0100	[thread overview]
Message-ID: <c0679032-6405-1eab-9e2c-ae58faa88e6b@arm.com> (raw)
In-Reply-To: <20210804040237.ssrba26jpe572mjf@vireshk-i7>



On 8/4/21 5:02 AM, Viresh Kumar wrote:
> On 03-08-21, 10:07, Lukasz Luba wrote:
>> Stop the initialization when cpumask allocation failed and return an
>> error.
>>
>> Fixes: 80a064dbd556 ("scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM")
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>> changes:
>> v2:
>> - removed dev_warn() since it's not needed in this case
>> - adjusted the patch description
>>
>>   drivers/cpufreq/scmi-cpufreq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
>> index ec9a87ca2dbb..75f818d04b48 100644
>> --- a/drivers/cpufreq/scmi-cpufreq.c
>> +++ b/drivers/cpufreq/scmi-cpufreq.c
>> @@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
>>   	}
>>   
>>   	if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL))
>> -		ret = -ENOMEM;
>> +		return -ENOMEM;
>>   
>>   	/* Obtain CPUs that share SCMI performance controls */
>>   	ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);
> 
> Applied. Thanks.
> 

Thank you for taking it.

WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, sudeep.holla@arm.com,
	cristian.marussi@arm.com, rjw@rjwysocki.net,
	nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed
Date: Wed, 4 Aug 2021 11:51:56 +0100	[thread overview]
Message-ID: <c0679032-6405-1eab-9e2c-ae58faa88e6b@arm.com> (raw)
In-Reply-To: <20210804040237.ssrba26jpe572mjf@vireshk-i7>



On 8/4/21 5:02 AM, Viresh Kumar wrote:
> On 03-08-21, 10:07, Lukasz Luba wrote:
>> Stop the initialization when cpumask allocation failed and return an
>> error.
>>
>> Fixes: 80a064dbd556 ("scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM")
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>> changes:
>> v2:
>> - removed dev_warn() since it's not needed in this case
>> - adjusted the patch description
>>
>>   drivers/cpufreq/scmi-cpufreq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
>> index ec9a87ca2dbb..75f818d04b48 100644
>> --- a/drivers/cpufreq/scmi-cpufreq.c
>> +++ b/drivers/cpufreq/scmi-cpufreq.c
>> @@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
>>   	}
>>   
>>   	if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL))
>> -		ret = -ENOMEM;
>> +		return -ENOMEM;
>>   
>>   	/* Obtain CPUs that share SCMI performance controls */
>>   	ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);
> 
> Applied. Thanks.
> 

Thank you for taking it.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-04 10:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  9:07 [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed Lukasz Luba
2021-08-03  9:07 ` Lukasz Luba
2021-08-03 22:41 ` Sudeep Holla
2021-08-03 22:41   ` Sudeep Holla
2021-08-04 10:51   ` Lukasz Luba
2021-08-04 10:51     ` Lukasz Luba
2021-08-04  4:02 ` Viresh Kumar
2021-08-04  4:02   ` Viresh Kumar
2021-08-04 10:51   ` Lukasz Luba [this message]
2021-08-04 10:51     ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0679032-6405-1eab-9e2c-ae58faa88e6b@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nicola.mazzucato@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.