From: Neil Armstrong <narmstrong@baylibre.com> To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org> Subject: Re: [PATCH 03/52] drm: add managed resources tied to drm_device Date: Wed, 19 Feb 2020 13:31:40 +0100 [thread overview] Message-ID: <c0f9e1b4-bb3d-b0ae-d5af-53b9121baa6c@baylibre.com> (raw) In-Reply-To: <20200219102122.1607365-4-daniel.vetter@ffwll.ch> Hi, On 19/02/2020 11:20, Daniel Vetter wrote: > We have lots of these. And the cleanup code tends to be of dubious > quality. The biggest wrong pattern is that developers use devm_, which > ties the release action to the underlying struct device, whereas > all the userspace visible stuff attached to a drm_device can long > outlive that one (e.g. after a hotunplug while userspace has open > files and mmap'ed buffers). Give people what they want, but with more > correctness. > > Mostly copied from devres.c, with types adjusted to fit drm_device and > a few simplifications - I didn't (yet) copy over everything. Since > the types don't match code sharing looked like a hopeless endeavour. > > For now it's only super simplified, no groups, you can't remove > actions (but kfree exists, we'll need that soon). Plus all specific to > drm_device ofc, including the logging. Which I didn't bother to make > compile-time optional, since none of the other drm logging is compile > time optional either. > > One tricky bit here is the chicken&egg between allocating your > drm_device structure and initiliazing it with drm_dev_init. For > perfect onion unwinding we'd need to have the action to kfree the > allocation registered before drm_dev_init registers any of its own > release handlers. But drm_dev_init doesn't know where exactly the > drm_device is emebedded into the overall structure, and by the time it > returns it'll all be too late. And forcing drivers to be able clean up > everything except the one kzalloc is silly. > > Work around this by having a very special final_kfree pointer. This > also avoids troubles with the list head possibly disappearing from > underneath us when we release all resources attached to the > drm_device. > > v2: Do all the kerneldoc at the end, to avoid lots of fairly pointless > shuffling while getting everything into shape. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > Documentation/gpu/drm-internals.rst | 6 + > drivers/gpu/drm/Makefile | 3 +- > drivers/gpu/drm/drm_drv.c | 13 ++- > drivers/gpu/drm/drm_internal.h | 3 + > drivers/gpu/drm/drm_managed.c | 173 ++++++++++++++++++++++++++++ > include/drm/drm_device.h | 12 ++ > include/drm/drm_managed.h | 25 ++++ > include/drm/drm_print.h | 6 + > 8 files changed, 239 insertions(+), 2 deletions(-) > create mode 100644 drivers/gpu/drm/drm_managed.c > create mode 100644 include/drm/drm_managed.h > > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst > index a73320576ca9..a6b6145fda78 100644 > --- a/Documentation/gpu/drm-internals.rst > +++ b/Documentation/gpu/drm-internals.rst > @@ -132,6 +132,12 @@ be unmapped; on many devices, the ROM address decoder is shared with > other BARs, so leaving it mapped could cause undesired behaviour like > hangs or memory corruption. > > +Managed Resources > +----------------- > + > +.. kernel-doc:: drivers/gpu/drm/drm_managed.c > + :doc: managed resources > + > Bus-specific Device Registration and PCI Support > ------------------------------------------------ > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index ca0ca775d37f..53d8fa170143 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -17,7 +17,8 @@ drm-y := drm_auth.o drm_cache.o \ > drm_plane.o drm_color_mgmt.o drm_print.o \ > drm_dumb_buffers.o drm_mode_config.o drm_vblank.o \ > drm_syncobj.o drm_lease.o drm_writeback.o drm_client.o \ > - drm_client_modeset.o drm_atomic_uapi.o drm_hdcp.o > + drm_client_modeset.o drm_atomic_uapi.o drm_hdcp.o \ > + drm_managed.o > > drm-$(CONFIG_DRM_LEGACY) += drm_legacy_misc.o drm_bufs.o drm_context.o drm_dma.o drm_scatter.o drm_lock.o > drm-$(CONFIG_DRM_LIB_RANDOM) += lib/drm_random.o > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 9fcd6ab3c154..3e5627d6eba6 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -629,6 +629,9 @@ int drm_dev_init(struct drm_device *dev, > dev->dev = get_device(parent); > dev->driver = driver; > > + INIT_LIST_HEAD(&dev->managed.resources); > + spin_lock_init(&dev->managed.lock); > + > /* no per-device feature limits by default */ > dev->driver_features = ~0u; > > @@ -828,8 +831,16 @@ static void drm_dev_release(struct kref *ref) > dev->driver->release(dev); > } else { > drm_dev_fini(dev); > - kfree(dev); > + if (!dev->managed.final_kfree) { > + WARN_ON(!list_empty(&dev->managed.resources)); > + kfree(dev); > + } > } > + > + drm_managed_release(dev); > + > + if (dev->managed.final_kfree) > + kfree(dev->managed.final_kfree); > } > > /** > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index aeec2e68d772..8c2628dfc6c7 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -89,6 +89,9 @@ void drm_prime_remove_buf_handle_locked(struct drm_prime_file_private *prime_fpr > struct drm_minor *drm_minor_acquire(unsigned int minor_id); > void drm_minor_release(struct drm_minor *minor); > > +/* drm_managed.c */ > +void drm_managed_release(struct drm_device *dev); > + > /* drm_vblank.c */ > void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe); > void drm_vblank_cleanup(struct drm_device *dev); > diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c > new file mode 100644 > index 000000000000..ee7c7253af61 > --- /dev/null > +++ b/drivers/gpu/drm/drm_managed.c > @@ -0,0 +1,173 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 Intel > + * > + * Based on drivers/base/devres.c > + */ > + > +#include <drm/drm_managed.h> > + > +#include <linux/list.h> > +#include <linux/slab.h> > +#include <linux/spinlock.h> > + > +#include <drm/drm_device.h> > +#include <drm/drm_print.h> > + > +/** > + * DOC: managed resources > + * > + * Inspired by sturct &device managed resources, but tied to the lifetime of --------------------/\ struct > + * struct &drm_device, which can outlive the underlying physical device, usually > + * when userspace has some open files and other handles to resources still open. > + */ > +struct drmres_node { > + struct list_head entry; > + drmres_release_t release; > + const char *name; > + size_t size; > +}; > + > +struct drmres { > + struct drmres_node node; > + /* > + * Some archs want to perform DMA into kmalloc caches > + * and need a guaranteed alignment larger than > + * the alignment of a 64-bit integer. > + * Thus we use ARCH_KMALLOC_MINALIGN here and get exactly the same > + * buffer alignment as if it was allocated by plain kmalloc(). > + */ > + u8 __aligned(ARCH_KMALLOC_MINALIGN) data[]; > +}; > + > +void drm_managed_release(struct drm_device *dev) > +{ > + > + struct drmres *dr, *tmp; > + > + drm_dbg_drmres(dev, "drmres release begin\n"); > + list_for_each_entry_safe(dr, tmp, &dev->managed.resources, node.entry) { > + drm_dbg_drmres(dev, "REL %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > + > + if (dr->node.release) > + dr->node.release(dev, dr->node.size ? dr->data : NULL); > + > + list_del(&dr->node.entry); > + kfree(dr); > + } > + drm_dbg_drmres(dev, "drmres release end\n"); > +} > + > +static __always_inline struct drmres * alloc_dr(drmres_release_t release, > + size_t size, gfp_t gfp, int nid) > +{ > + size_t tot_size; > + struct drmres *dr; > + > + /* We must catch any near-SIZE_MAX cases that could overflow. */ > + if (unlikely(check_add_overflow(sizeof(*dr), size, &tot_size))) > + return NULL; > + > + dr = kmalloc_node_track_caller(tot_size, gfp, nid); > + if (unlikely(!dr)) > + return NULL; > + > + memset(dr, 0, offsetof(struct drmres, data)); > + > + INIT_LIST_HEAD(&dr->node.entry); > + dr->node.release = release; > + dr->node.size = size; > + > + return dr; > +} > + > +void del_dr(struct drm_device *dev, struct drmres *dr) > +{ > + list_del_init(&dr->node.entry); > + > + drm_dbg_drmres(dev, "DEL %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > +} > + > +void add_dr(struct drm_device *dev, struct drmres *dr) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&dev->managed.lock, flags); > + list_add(&dr->node.entry, &dev->managed.resources); > + spin_unlock_irqrestore(&dev->managed.lock, flags); > + > + drm_dbg_drmres(dev, "ADD %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > +} Maybe del_dr/add_dr as static ? > + > +void drmm_add_final_kfree(struct drm_device *dev, void *parent) > +{ > + WARN_ON(dev->managed.final_kfree); > + dev->managed.final_kfree = parent; > +} > +EXPORT_SYMBOL(drmm_add_final_kfree); > + > +int __drmm_add_action(struct drm_device *dev, > + drmres_release_t action, > + void *data, const char *name) > +{ > + struct drmres *dr; > + void **void_ptr; > + > + dr = alloc_dr(action, data ? sizeof(void*) : 0, > + GFP_KERNEL | __GFP_ZERO, > + dev_to_node(dev->dev)); > + if (!dr) > + return -ENOMEM; > + dr->node.name = name; > + void_ptr = (void **) dr->data; > + *void_ptr = data; > + > + add_dr(dev, dr); > + > + return 0; > + > +} > +EXPORT_SYMBOL(__drmm_add_action); > + > +void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) > +{ > + struct drmres *dr; > + > + dr = alloc_dr(NULL, size, gfp, dev_to_node(dev->dev)); > + if (!dr) > + return NULL; > + dr->node.name = "kmalloc"; > + > + add_dr(dev, dr); > + > + return dr->data; > +} > +EXPORT_SYMBOL(drmm_kmalloc); > + > +void drmm_kfree(struct drm_device *dev, void *data) > +{ > + struct drmres *dr = NULL, *tmp; > + unsigned long flags; > + > + if (!data) > + return; > + > + spin_lock_irqsave(&dev->managed.lock, flags); > + list_for_each_entry(tmp, &dev->managed.resources, node.entry) { > + if (tmp->data == data) { > + dr = tmp; > + del_dr(dev, dr); > + break; > + } > + } > + spin_unlock_irqrestore(&dev->managed.lock, flags); > + > + if (WARN_ON(!dr)) > + return; > + > + kfree(dr); > +} > +EXPORT_SYMBOL(drmm_kfree); > diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h > index bb60a949f416..2790c9ed614e 100644 > --- a/include/drm/drm_device.h > +++ b/include/drm/drm_device.h > @@ -67,6 +67,18 @@ struct drm_device { > /** @dev: Device structure of bus-device */ > struct device *dev; > > + /** > + * @managed: > + * > + * Managed resources linked to the lifetime of this &drm_device as > + * tracked by @ref. > + */ > + struct { > + struct list_head resources; > + void *final_kfree; > + spinlock_t lock; > + } managed; > + > /** @driver: DRM driver managing the device */ > struct drm_driver *driver; > > diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h > new file mode 100644 > index 000000000000..75f2c8932c69 > --- /dev/null > +++ b/include/drm/drm_managed.h > @@ -0,0 +1,25 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include <linux/types.h> > +#include <linux/gfp.h> > + > +struct drm_device; > + > +typedef void (*drmres_release_t)(struct drm_device *dev, void *res); > + > +#define drmm_add_action(dev, action, data) \ > + __drmm_add_action(dev, action, data, #action) > + > +int __must_check __drmm_add_action(struct drm_device *dev, > + drmres_release_t action, > + void *data, const char *name); > + > +void drmm_add_final_kfree(struct drm_device *dev, void *parent); > + > +void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc; > +static inline void *drmm_kzalloc(struct drm_device *dev, size_t size, gfp_t gfp) > +{ > + return drmm_kmalloc(dev, size, gfp | __GFP_ZERO); > +} > + > +void drmm_kfree(struct drm_device *dev, void *data); > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index ca7cee8e728a..1c9417430d08 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -313,6 +313,10 @@ enum drm_debug_category { > * @DRM_UT_DP: Used in the DP code. > */ > DRM_UT_DP = 0x100, > + /** > + * @DRM_UT_DRMRES: Used in the drm managed resources code. > + */ > + DRM_UT_DRMRES = 0x200, > }; > > static inline bool drm_debug_enabled(enum drm_debug_category category) > @@ -442,6 +446,8 @@ void drm_dev_dbg(const struct device *dev, enum drm_debug_category category, > drm_dev_dbg((drm)->dev, DRM_UT_LEASE, fmt, ##__VA_ARGS__) > #define drm_dbg_dp(drm, fmt, ...) \ > drm_dev_dbg((drm)->dev, DRM_UT_DP, fmt, ##__VA_ARGS__) > +#define drm_dbg_drmres(drm, fmt, ...) \ > + drm_dev_dbg((drm)->dev, DRM_UT_DRMRES, fmt, ##__VA_ARGS__) > > > /* > Neil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com> To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org> Subject: Re: [Intel-gfx] [PATCH 03/52] drm: add managed resources tied to drm_device Date: Wed, 19 Feb 2020 13:31:40 +0100 [thread overview] Message-ID: <c0f9e1b4-bb3d-b0ae-d5af-53b9121baa6c@baylibre.com> (raw) In-Reply-To: <20200219102122.1607365-4-daniel.vetter@ffwll.ch> Hi, On 19/02/2020 11:20, Daniel Vetter wrote: > We have lots of these. And the cleanup code tends to be of dubious > quality. The biggest wrong pattern is that developers use devm_, which > ties the release action to the underlying struct device, whereas > all the userspace visible stuff attached to a drm_device can long > outlive that one (e.g. after a hotunplug while userspace has open > files and mmap'ed buffers). Give people what they want, but with more > correctness. > > Mostly copied from devres.c, with types adjusted to fit drm_device and > a few simplifications - I didn't (yet) copy over everything. Since > the types don't match code sharing looked like a hopeless endeavour. > > For now it's only super simplified, no groups, you can't remove > actions (but kfree exists, we'll need that soon). Plus all specific to > drm_device ofc, including the logging. Which I didn't bother to make > compile-time optional, since none of the other drm logging is compile > time optional either. > > One tricky bit here is the chicken&egg between allocating your > drm_device structure and initiliazing it with drm_dev_init. For > perfect onion unwinding we'd need to have the action to kfree the > allocation registered before drm_dev_init registers any of its own > release handlers. But drm_dev_init doesn't know where exactly the > drm_device is emebedded into the overall structure, and by the time it > returns it'll all be too late. And forcing drivers to be able clean up > everything except the one kzalloc is silly. > > Work around this by having a very special final_kfree pointer. This > also avoids troubles with the list head possibly disappearing from > underneath us when we release all resources attached to the > drm_device. > > v2: Do all the kerneldoc at the end, to avoid lots of fairly pointless > shuffling while getting everything into shape. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > Documentation/gpu/drm-internals.rst | 6 + > drivers/gpu/drm/Makefile | 3 +- > drivers/gpu/drm/drm_drv.c | 13 ++- > drivers/gpu/drm/drm_internal.h | 3 + > drivers/gpu/drm/drm_managed.c | 173 ++++++++++++++++++++++++++++ > include/drm/drm_device.h | 12 ++ > include/drm/drm_managed.h | 25 ++++ > include/drm/drm_print.h | 6 + > 8 files changed, 239 insertions(+), 2 deletions(-) > create mode 100644 drivers/gpu/drm/drm_managed.c > create mode 100644 include/drm/drm_managed.h > > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst > index a73320576ca9..a6b6145fda78 100644 > --- a/Documentation/gpu/drm-internals.rst > +++ b/Documentation/gpu/drm-internals.rst > @@ -132,6 +132,12 @@ be unmapped; on many devices, the ROM address decoder is shared with > other BARs, so leaving it mapped could cause undesired behaviour like > hangs or memory corruption. > > +Managed Resources > +----------------- > + > +.. kernel-doc:: drivers/gpu/drm/drm_managed.c > + :doc: managed resources > + > Bus-specific Device Registration and PCI Support > ------------------------------------------------ > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index ca0ca775d37f..53d8fa170143 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -17,7 +17,8 @@ drm-y := drm_auth.o drm_cache.o \ > drm_plane.o drm_color_mgmt.o drm_print.o \ > drm_dumb_buffers.o drm_mode_config.o drm_vblank.o \ > drm_syncobj.o drm_lease.o drm_writeback.o drm_client.o \ > - drm_client_modeset.o drm_atomic_uapi.o drm_hdcp.o > + drm_client_modeset.o drm_atomic_uapi.o drm_hdcp.o \ > + drm_managed.o > > drm-$(CONFIG_DRM_LEGACY) += drm_legacy_misc.o drm_bufs.o drm_context.o drm_dma.o drm_scatter.o drm_lock.o > drm-$(CONFIG_DRM_LIB_RANDOM) += lib/drm_random.o > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 9fcd6ab3c154..3e5627d6eba6 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -629,6 +629,9 @@ int drm_dev_init(struct drm_device *dev, > dev->dev = get_device(parent); > dev->driver = driver; > > + INIT_LIST_HEAD(&dev->managed.resources); > + spin_lock_init(&dev->managed.lock); > + > /* no per-device feature limits by default */ > dev->driver_features = ~0u; > > @@ -828,8 +831,16 @@ static void drm_dev_release(struct kref *ref) > dev->driver->release(dev); > } else { > drm_dev_fini(dev); > - kfree(dev); > + if (!dev->managed.final_kfree) { > + WARN_ON(!list_empty(&dev->managed.resources)); > + kfree(dev); > + } > } > + > + drm_managed_release(dev); > + > + if (dev->managed.final_kfree) > + kfree(dev->managed.final_kfree); > } > > /** > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index aeec2e68d772..8c2628dfc6c7 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -89,6 +89,9 @@ void drm_prime_remove_buf_handle_locked(struct drm_prime_file_private *prime_fpr > struct drm_minor *drm_minor_acquire(unsigned int minor_id); > void drm_minor_release(struct drm_minor *minor); > > +/* drm_managed.c */ > +void drm_managed_release(struct drm_device *dev); > + > /* drm_vblank.c */ > void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe); > void drm_vblank_cleanup(struct drm_device *dev); > diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c > new file mode 100644 > index 000000000000..ee7c7253af61 > --- /dev/null > +++ b/drivers/gpu/drm/drm_managed.c > @@ -0,0 +1,173 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 Intel > + * > + * Based on drivers/base/devres.c > + */ > + > +#include <drm/drm_managed.h> > + > +#include <linux/list.h> > +#include <linux/slab.h> > +#include <linux/spinlock.h> > + > +#include <drm/drm_device.h> > +#include <drm/drm_print.h> > + > +/** > + * DOC: managed resources > + * > + * Inspired by sturct &device managed resources, but tied to the lifetime of --------------------/\ struct > + * struct &drm_device, which can outlive the underlying physical device, usually > + * when userspace has some open files and other handles to resources still open. > + */ > +struct drmres_node { > + struct list_head entry; > + drmres_release_t release; > + const char *name; > + size_t size; > +}; > + > +struct drmres { > + struct drmres_node node; > + /* > + * Some archs want to perform DMA into kmalloc caches > + * and need a guaranteed alignment larger than > + * the alignment of a 64-bit integer. > + * Thus we use ARCH_KMALLOC_MINALIGN here and get exactly the same > + * buffer alignment as if it was allocated by plain kmalloc(). > + */ > + u8 __aligned(ARCH_KMALLOC_MINALIGN) data[]; > +}; > + > +void drm_managed_release(struct drm_device *dev) > +{ > + > + struct drmres *dr, *tmp; > + > + drm_dbg_drmres(dev, "drmres release begin\n"); > + list_for_each_entry_safe(dr, tmp, &dev->managed.resources, node.entry) { > + drm_dbg_drmres(dev, "REL %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > + > + if (dr->node.release) > + dr->node.release(dev, dr->node.size ? dr->data : NULL); > + > + list_del(&dr->node.entry); > + kfree(dr); > + } > + drm_dbg_drmres(dev, "drmres release end\n"); > +} > + > +static __always_inline struct drmres * alloc_dr(drmres_release_t release, > + size_t size, gfp_t gfp, int nid) > +{ > + size_t tot_size; > + struct drmres *dr; > + > + /* We must catch any near-SIZE_MAX cases that could overflow. */ > + if (unlikely(check_add_overflow(sizeof(*dr), size, &tot_size))) > + return NULL; > + > + dr = kmalloc_node_track_caller(tot_size, gfp, nid); > + if (unlikely(!dr)) > + return NULL; > + > + memset(dr, 0, offsetof(struct drmres, data)); > + > + INIT_LIST_HEAD(&dr->node.entry); > + dr->node.release = release; > + dr->node.size = size; > + > + return dr; > +} > + > +void del_dr(struct drm_device *dev, struct drmres *dr) > +{ > + list_del_init(&dr->node.entry); > + > + drm_dbg_drmres(dev, "DEL %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > +} > + > +void add_dr(struct drm_device *dev, struct drmres *dr) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&dev->managed.lock, flags); > + list_add(&dr->node.entry, &dev->managed.resources); > + spin_unlock_irqrestore(&dev->managed.lock, flags); > + > + drm_dbg_drmres(dev, "ADD %p %s (%lu bytes)\n", > + dr, dr->node.name, (unsigned long) dr->node.size); > +} Maybe del_dr/add_dr as static ? > + > +void drmm_add_final_kfree(struct drm_device *dev, void *parent) > +{ > + WARN_ON(dev->managed.final_kfree); > + dev->managed.final_kfree = parent; > +} > +EXPORT_SYMBOL(drmm_add_final_kfree); > + > +int __drmm_add_action(struct drm_device *dev, > + drmres_release_t action, > + void *data, const char *name) > +{ > + struct drmres *dr; > + void **void_ptr; > + > + dr = alloc_dr(action, data ? sizeof(void*) : 0, > + GFP_KERNEL | __GFP_ZERO, > + dev_to_node(dev->dev)); > + if (!dr) > + return -ENOMEM; > + dr->node.name = name; > + void_ptr = (void **) dr->data; > + *void_ptr = data; > + > + add_dr(dev, dr); > + > + return 0; > + > +} > +EXPORT_SYMBOL(__drmm_add_action); > + > +void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) > +{ > + struct drmres *dr; > + > + dr = alloc_dr(NULL, size, gfp, dev_to_node(dev->dev)); > + if (!dr) > + return NULL; > + dr->node.name = "kmalloc"; > + > + add_dr(dev, dr); > + > + return dr->data; > +} > +EXPORT_SYMBOL(drmm_kmalloc); > + > +void drmm_kfree(struct drm_device *dev, void *data) > +{ > + struct drmres *dr = NULL, *tmp; > + unsigned long flags; > + > + if (!data) > + return; > + > + spin_lock_irqsave(&dev->managed.lock, flags); > + list_for_each_entry(tmp, &dev->managed.resources, node.entry) { > + if (tmp->data == data) { > + dr = tmp; > + del_dr(dev, dr); > + break; > + } > + } > + spin_unlock_irqrestore(&dev->managed.lock, flags); > + > + if (WARN_ON(!dr)) > + return; > + > + kfree(dr); > +} > +EXPORT_SYMBOL(drmm_kfree); > diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h > index bb60a949f416..2790c9ed614e 100644 > --- a/include/drm/drm_device.h > +++ b/include/drm/drm_device.h > @@ -67,6 +67,18 @@ struct drm_device { > /** @dev: Device structure of bus-device */ > struct device *dev; > > + /** > + * @managed: > + * > + * Managed resources linked to the lifetime of this &drm_device as > + * tracked by @ref. > + */ > + struct { > + struct list_head resources; > + void *final_kfree; > + spinlock_t lock; > + } managed; > + > /** @driver: DRM driver managing the device */ > struct drm_driver *driver; > > diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h > new file mode 100644 > index 000000000000..75f2c8932c69 > --- /dev/null > +++ b/include/drm/drm_managed.h > @@ -0,0 +1,25 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include <linux/types.h> > +#include <linux/gfp.h> > + > +struct drm_device; > + > +typedef void (*drmres_release_t)(struct drm_device *dev, void *res); > + > +#define drmm_add_action(dev, action, data) \ > + __drmm_add_action(dev, action, data, #action) > + > +int __must_check __drmm_add_action(struct drm_device *dev, > + drmres_release_t action, > + void *data, const char *name); > + > +void drmm_add_final_kfree(struct drm_device *dev, void *parent); > + > +void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc; > +static inline void *drmm_kzalloc(struct drm_device *dev, size_t size, gfp_t gfp) > +{ > + return drmm_kmalloc(dev, size, gfp | __GFP_ZERO); > +} > + > +void drmm_kfree(struct drm_device *dev, void *data); > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index ca7cee8e728a..1c9417430d08 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -313,6 +313,10 @@ enum drm_debug_category { > * @DRM_UT_DP: Used in the DP code. > */ > DRM_UT_DP = 0x100, > + /** > + * @DRM_UT_DRMRES: Used in the drm managed resources code. > + */ > + DRM_UT_DRMRES = 0x200, > }; > > static inline bool drm_debug_enabled(enum drm_debug_category category) > @@ -442,6 +446,8 @@ void drm_dev_dbg(const struct device *dev, enum drm_debug_category category, > drm_dev_dbg((drm)->dev, DRM_UT_LEASE, fmt, ##__VA_ARGS__) > #define drm_dbg_dp(drm, fmt, ...) \ > drm_dev_dbg((drm)->dev, DRM_UT_DP, fmt, ##__VA_ARGS__) > +#define drm_dbg_drmres(drm, fmt, ...) \ > + drm_dev_dbg((drm)->dev, DRM_UT_DRMRES, fmt, ##__VA_ARGS__) > > > /* > Neil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-19 12:31 UTC|newest] Thread overview: 310+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 10:20 [PATCH 00/52] drm_device managed resources Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 01/52] mm/sl[uo]b: export __kmalloc_track(_node)_caller Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-19 19:42 ` Andrew Morton 2020-02-19 19:42 ` [Intel-gfx] " Andrew Morton 2020-02-19 19:42 ` Andrew Morton 2020-02-22 3:42 ` Christopher Lameter 2020-02-22 3:42 ` [Intel-gfx] " Christopher Lameter 2020-02-22 3:42 ` Christopher Lameter 2020-02-19 10:20 ` [PATCH 02/52] drm/i915: Don't clear drvdata in ->release Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 03/52] drm: add managed resources tied to drm_device Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:31 ` Neil Armstrong [this message] 2020-02-19 12:31 ` Neil Armstrong 2020-02-19 13:24 ` Daniel Vetter 2020-02-19 13:24 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:28 ` Laurent Pinchart 2020-02-19 13:28 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:33 ` Greg Kroah-Hartman 2020-02-19 13:33 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 14:22 ` Daniel Vetter 2020-02-19 14:22 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:09 ` Emil Velikov 2020-02-19 16:09 ` Emil Velikov 2020-02-19 16:22 ` Daniel Vetter 2020-02-19 16:22 ` Daniel Vetter 2020-02-19 16:41 ` Emil Velikov 2020-02-19 16:41 ` Emil Velikov 2020-02-19 16:46 ` Laurent Pinchart 2020-02-19 16:46 ` Laurent Pinchart 2020-02-19 16:53 ` Daniel Vetter 2020-02-19 16:53 ` Daniel Vetter 2020-02-19 17:02 ` Laurent Pinchart 2020-02-19 17:02 ` Laurent Pinchart 2020-02-19 17:06 ` Daniel Vetter 2020-02-19 17:06 ` Daniel Vetter 2020-02-19 17:00 ` Greg Kroah-Hartman 2020-02-19 17:00 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 17:36 ` Laurent Pinchart 2020-02-19 17:36 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 18:19 ` Greg Kroah-Hartman 2020-02-19 18:19 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 19:57 ` Daniel Vetter 2020-02-19 19:57 ` [Intel-gfx] " Daniel Vetter 2020-02-20 14:58 ` Laurent Pinchart 2020-02-20 14:58 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:57 ` Daniel Vetter 2020-02-19 13:57 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 04/52] drm: Set final_kfree in drm_dev_alloc Daniel Vetter 2020-02-19 10:20 ` [Xen-devel] " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:03 ` Oleksandr Andrushchenko 2020-02-19 12:03 ` [Xen-devel] " Oleksandr Andrushchenko 2020-02-19 12:03 ` [Intel-gfx] " Oleksandr Andrushchenko 2020-02-19 13:39 ` Laurent Pinchart 2020-02-19 13:39 ` [Xen-devel] " Laurent Pinchart 2020-02-19 13:39 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:41 ` Daniel Vetter 2020-02-19 14:41 ` [Xen-devel] " Daniel Vetter 2020-02-19 14:41 ` [Intel-gfx] " Daniel Vetter 2020-02-21 19:07 ` Daniel Vetter 2020-02-21 19:07 ` [Xen-devel] " Daniel Vetter 2020-02-21 19:07 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 11:47 ` Thomas Zimmermann 2020-02-19 11:47 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 12:45 ` Thomas Zimmermann 2020-02-19 12:45 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 13:23 ` Daniel Vetter 2020-02-19 13:23 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:29 ` Thomas Zimmermann 2020-02-19 13:29 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 14:32 ` Daniel Vetter 2020-02-19 14:32 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:18 ` Noralf Trønnes 2020-02-20 16:18 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:20 ` [PATCH 06/52] drm/udl: Use drmm_add_final_kfree Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 07/52] " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:42 ` Laurent Pinchart 2020-02-19 13:42 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:43 ` Daniel Vetter 2020-02-19 14:43 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 08/52] drm/qxl: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-19 10:20 ` [PATCH 09/52] drm/i915: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 10/52] drm/cirrus: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-24 8:13 ` Gerd Hoffmann 2020-02-24 8:13 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:13 ` Gerd Hoffmann 2020-02-19 10:20 ` [PATCH 11/52] drm/v3d: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 18:43 ` Eric Anholt 2020-02-19 18:43 ` [Intel-gfx] " Eric Anholt 2020-02-19 10:20 ` [PATCH 12/52] drm/tidss: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 13/52] drm/mcde: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:12 ` Linus Walleij 2020-02-19 16:12 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:20 ` [PATCH 14/52] drm/vgem: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 15/52] drm/vkms: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 16/52] drm/repaper: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:18 ` Noralf Trønnes 2020-02-20 16:18 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:20 ` [PATCH 17/52] drm/inigenic: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 18/52] drm/gm12u320: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 19/52] drm/<drivers>: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:11 ` Laurent Pinchart 2020-02-19 14:11 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:30 ` Daniel Vetter 2020-02-19 14:30 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:39 ` Laurent Pinchart 2020-02-19 14:39 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:29 ` Daniel Vetter 2020-02-19 15:29 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 20/52] drm: Cleanups after drmm_add_final_kfree rollout Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 21/52] drm: Handle dev->unique with drmm_ Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:28 ` Laurent Pinchart 2020-02-19 14:28 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:24 ` Daniel Vetter 2020-02-19 15:24 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:35 ` Laurent Pinchart 2020-02-19 14:35 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:27 ` Daniel Vetter 2020-02-19 15:27 ` [Intel-gfx] " Daniel Vetter 2020-02-19 15:37 ` Laurent Pinchart 2020-02-19 15:37 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:44 ` Daniel Vetter 2020-02-19 15:44 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 23/52] drm: manage drm_minor cleanup with drmm_ Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:47 ` Laurent Pinchart 2020-02-19 14:47 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:34 ` Daniel Vetter 2020-02-19 15:34 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 24/52] drm: Manage drm_gem_init " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:22 ` Laurent Pinchart 2020-02-19 14:22 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:37 ` Daniel Vetter 2020-02-19 14:37 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:52 ` Laurent Pinchart 2020-02-19 14:52 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:56 ` Daniel Vetter 2020-02-19 14:56 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 25/52] drm: Manage drm_vblank_cleanup " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 26/52] drm: Garbage collect drm_dev_fini Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 27/52] drm: Manage drm_mode_config_init with drmm_ Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:49 ` Laurent Pinchart 2020-02-19 13:49 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:47 ` Daniel Vetter 2020-02-19 15:47 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:07 ` Laurent Pinchart 2020-02-19 16:07 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 16:23 ` Daniel Vetter 2020-02-19 16:23 ` [Intel-gfx] " Daniel Vetter 2020-02-19 17:30 ` Noralf Trønnes 2020-02-19 17:30 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 18:12 ` Daniel Vetter 2020-02-19 18:12 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 28/52] drm/bochs: Remove leftover drm_atomic_helper_shutdown Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-24 8:14 ` Gerd Hoffmann 2020-02-24 8:14 ` [Intel-gfx] " Gerd Hoffmann 2020-02-19 10:20 ` [PATCH 29/52] drm/bochs: Drop explicit drm_mode_config_cleanup Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-24 8:15 ` Gerd Hoffmann 2020-02-24 8:15 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:15 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 30/52] drm/cirrus: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-24 8:16 ` Gerd Hoffmann 2020-02-24 8:16 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:16 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 31/52] drm/cirrus: Fully embrace devm_ Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-24 8:18 ` Gerd Hoffmann 2020-02-24 8:18 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:18 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 32/52] drm/ingenic: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 33/52] drm/mcde: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:12 ` Linus Walleij 2020-02-19 16:12 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:21 ` [PATCH 34/52] drm/mcde: More devm_drm_dev_init Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:13 ` Linus Walleij 2020-02-19 16:13 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:21 ` [PATCH 35/52] drm/meson: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:39 ` [Intel-gfx] " Neil Armstrong 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:21 ` [PATCH 36/52] drm/pl111: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 37/52] drm/rcar-du: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:30 ` Geert Uytterhoeven 2020-02-19 10:30 ` [Intel-gfx] " Geert Uytterhoeven 2020-02-19 10:30 ` Geert Uytterhoeven 2020-02-19 10:56 ` Daniel Vetter 2020-02-19 10:56 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:56 ` Daniel Vetter 2020-02-19 11:10 ` Geert Uytterhoeven 2020-02-19 11:10 ` [Intel-gfx] " Geert Uytterhoeven 2020-02-19 11:10 ` Geert Uytterhoeven 2020-02-19 12:17 ` Laurent Pinchart 2020-02-19 12:17 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 12:17 ` Laurent Pinchart 2020-02-19 12:40 ` Daniel Vetter 2020-02-19 12:40 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:40 ` Daniel Vetter 2020-02-19 13:53 ` Laurent Pinchart 2020-02-19 13:53 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:53 ` Laurent Pinchart 2020-02-19 14:29 ` Daniel Vetter 2020-02-19 14:29 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:29 ` Daniel Vetter [not found] ` <20200219102122.1607365-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> 2020-02-19 10:21 ` [PATCH 38/52] drm/rockchip: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` [PATCH 39/52] drm/stm: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-20 14:18 ` Philippe CORNU 2020-02-20 14:18 ` [Intel-gfx] " Philippe CORNU 2020-02-20 14:18 ` Philippe CORNU 2020-02-20 16:12 ` Daniel Vetter 2020-02-20 16:12 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:12 ` Daniel Vetter 2020-02-19 10:21 ` [PATCH 40/52] drm/shmob: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 13:57 ` Laurent Pinchart 2020-02-19 13:57 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:57 ` Laurent Pinchart 2020-02-19 10:21 ` [PATCH 41/52] drm/mtk: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 42/52] drm/tidss: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 43/52] drm/gm12u320: More drmm_ Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 44/52] drm/gm12u320: Use devm_drm_dev_init Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 45/52] drm/gm12u320: Use helpers for shutdown/suspend/resume Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 46/52] drm/gm12u320: Simplify upload work Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 47/52] drm/repaper: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:21 ` Noralf Trønnes 2020-02-20 16:21 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 48/52] drm/mipi-dbi: Move drm_mode_config_init into mipi library Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:22 ` Noralf Trønnes 2020-02-20 16:22 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 49/52] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:22 ` Noralf Trønnes 2020-02-20 16:22 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 50/52] drm/udl: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 51/52] drm/udl: drop drm_driver.release hook Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 52/52] drm: Add docs for managed resources Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 15:08 ` Laurent Pinchart 2020-02-19 15:08 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:40 ` Daniel Vetter 2020-02-19 15:40 ` [Intel-gfx] " Daniel Vetter 2020-02-21 20:23 ` Sam Ravnborg 2020-02-21 20:23 ` [Intel-gfx] " Sam Ravnborg 2020-02-21 21:13 ` Sam Ravnborg 2020-02-21 21:13 ` [Intel-gfx] " Sam Ravnborg 2020-02-19 11:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device " Patchwork 2020-02-19 11:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-02-19 11:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-02-21 1:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c0f9e1b4-bb3d-b0ae-d5af-53b9121baa6c@baylibre.com \ --to=narmstrong@baylibre.com \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=rafael@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.