From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Neal Liu <neal_liu@aspeedtech.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Randy Dunlap <rdunlap@infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Dhananjay Phadke <dhphadke@microsoft.com>,
Johnny Huang <johnny_huang@aspeedtech.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
BMC-SW@aspeedtech.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition
Date: Wed, 29 Jun 2022 04:49:32 -0700 [thread overview]
Message-ID: <c24d0e6d-d9ba-68c5-b1c8-13ad31d39ec8@linux.microsoft.com> (raw)
In-Reply-To: <20220629094426.1930589-3-neal_liu@aspeedtech.com>
On 6/29/2022 2:44 AM, Neal Liu wrote:
> Add HACE reset bit definition for AST2500/AST2600.
>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
> ---
> include/dt-bindings/clock/aspeed-clock.h | 1 +
> include/dt-bindings/clock/ast2600-clock.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> index 9ff4f6e4558c..06d568382c77 100644
> --- a/include/dt-bindings/clock/aspeed-clock.h
> +++ b/include/dt-bindings/clock/aspeed-clock.h
> @@ -52,5 +52,6 @@
> #define ASPEED_RESET_I2C 7
> #define ASPEED_RESET_AHB 8
> #define ASPEED_RESET_CRT1 9
> +#define ASPEED_RESET_HACE 10
NAK.
I replied to older v5 of this patch, but this v6 also looks incorrect
as per HW manual.
https://lore.kernel.org/linux-arm-kernel/20220629032008.1579899-1-neal_liu@aspeedtech.com/T/#m000bd3388b3e41117aa0eef10bf6f8a6a3a85cce
For both AST2400 and AST2500:
SCU04[10] = PECI.
It will be best to refactor/split aspeed-clock.h into separate files.
Regards,
Dhananjay
WARNING: multiple messages have this Message-ID (diff)
From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Neal Liu <neal_liu@aspeedtech.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Randy Dunlap <rdunlap@infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Dhananjay Phadke <dhphadke@microsoft.com>,
Johnny Huang <johnny_huang@aspeedtech.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
BMC-SW@aspeedtech.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition
Date: Wed, 29 Jun 2022 04:49:32 -0700 [thread overview]
Message-ID: <c24d0e6d-d9ba-68c5-b1c8-13ad31d39ec8@linux.microsoft.com> (raw)
In-Reply-To: <20220629094426.1930589-3-neal_liu@aspeedtech.com>
On 6/29/2022 2:44 AM, Neal Liu wrote:
> Add HACE reset bit definition for AST2500/AST2600.
>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
> ---
> include/dt-bindings/clock/aspeed-clock.h | 1 +
> include/dt-bindings/clock/ast2600-clock.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> index 9ff4f6e4558c..06d568382c77 100644
> --- a/include/dt-bindings/clock/aspeed-clock.h
> +++ b/include/dt-bindings/clock/aspeed-clock.h
> @@ -52,5 +52,6 @@
> #define ASPEED_RESET_I2C 7
> #define ASPEED_RESET_AHB 8
> #define ASPEED_RESET_CRT1 9
> +#define ASPEED_RESET_HACE 10
NAK.
I replied to older v5 of this patch, but this v6 also looks incorrect
as per HW manual.
https://lore.kernel.org/linux-arm-kernel/20220629032008.1579899-1-neal_liu@aspeedtech.com/T/#m000bd3388b3e41117aa0eef10bf6f8a6a3a85cce
For both AST2400 and AST2500:
SCU04[10] = PECI.
It will be best to refactor/split aspeed-clock.h into separate files.
Regards,
Dhananjay
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 11:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:44 [PATCH v6 0/5] Add Aspeed crypto driver for hardware acceleration Neal Liu
2022-06-29 9:44 ` Neal Liu
2022-06-29 9:44 ` [PATCH v6 1/5] crypto: aspeed: Add HACE hash driver Neal Liu
2022-06-29 9:44 ` Neal Liu
2022-06-29 12:36 ` Corentin Labbe
2022-06-29 12:36 ` Corentin Labbe
2022-06-30 3:41 ` Neal Liu
2022-06-30 3:41 ` Neal Liu
2022-06-29 9:44 ` [PATCH v6 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Neal Liu
2022-06-29 9:44 ` Neal Liu
2022-06-29 11:13 ` Krzysztof Kozlowski
2022-06-29 11:13 ` Krzysztof Kozlowski
2022-06-29 11:49 ` Dhananjay Phadke [this message]
2022-06-29 11:49 ` Dhananjay Phadke
2022-06-30 3:17 ` Neal Liu
2022-06-30 3:17 ` Neal Liu
2022-06-30 3:32 ` Dhananjay Phadke
2022-06-30 3:32 ` Dhananjay Phadke
2022-06-30 7:12 ` Neal Liu
2022-06-30 7:12 ` Neal Liu
2022-06-29 9:44 ` [PATCH v6 3/5] ARM: dts: aspeed: Add HACE device controller node Neal Liu
2022-06-29 9:44 ` Neal Liu
2022-06-29 9:44 ` [PATCH v6 4/5] dt-bindings: crypto: add documentation for aspeed hace Neal Liu
2022-06-29 9:44 ` Neal Liu
2022-06-29 9:44 ` [PATCH v6 5/5] crypto: aspeed: add HACE crypto driver Neal Liu
2022-06-29 9:44 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24d0e6d-d9ba-68c5-b1c8-13ad31d39ec8@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dhphadke@microsoft.com \
--cc=herbert@gondor.apana.org.au \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.