Re: [PATCH -next 1/7] drm/amdkfd: Remove unnecessary NULL values

From: "Christian König" <christian.koenig@amd.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>,
	Felix.Kuehling@amd.com, alexander.deucher@amd.com,
	Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
	harry.wentland@amd.com, sunpeng.li@amd.com,
	Rodrigo.Siqueira@amd.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, inki.dae@samsung.com,
	sw0312.kim@samsung.com, kyungmin.park@samsung.com,
	krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
	robdclark@gmail.com, quic_abhinavk@quicinc.com,
	dmitry.baryshkov@linaro.org, sean@poorly.run,
	marijn.suijten@somainline.org, bskeggs@redhat.com,
	kherbst@redhat.com, lyude@redhat.com, kraxel@redhat.com,
	gurchetansingh@chromium.org, olvaffe@gmail.com,
	paulo.miguel.almeida.rodenas@gmail.com, wenjing.liu@amd.com,
	haoping.liu@amd.com, Charlene.Liu@amd.com,
	chiahsuan.chung@amd.com, george.shen@amd.com, sancchen@amd.com,
	tony.tascioglu@amd.com, jaehyun.chung@amd.com,
	tales.aparecida@gmail.com, drv@mailo.com,
	aurabindo.pillai@amd.com, quic_vpolimer@quicinc.com,
	jiasheng@iscas.ac.cn, noralf@tronnes.org,
	jose.exposito89@gmail.com, javierm@redhat.com,
	mairacanal@riseup.net, davidgow@google.com,
	arthurgrillo@riseup.net, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH -next 1/7] drm/amdkfd: Remove unnecessary NULL values
Date: Wed, 9 Aug 2023 08:15:23 +0200	[thread overview]
Message-ID: <c2b0d96e-b768-b295-c672-3ae52e14b10b@amd.com> (raw)
In-Reply-To: <20230809034445.434902-2-ruanjinjie@huawei.com>

Am 09.08.23 um 05:44 schrieb Ruan Jinjie:
> The NULL initialization of the pointers assigned by kzalloc() first is
> not necessary, because if the kzalloc() failed, the pointers will be
> assigned NULL, otherwise it works as usual. so remove it.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for this one, 
the amd display code and the radeon stuff.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c
> index 863cf060af48..d01bb57733b3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c
> @@ -48,7 +48,7 @@ int pipe_priority_map[] = {
>   
>   struct kfd_mem_obj *allocate_hiq_mqd(struct kfd_node *dev, struct queue_properties *q)
>   {
> -	struct kfd_mem_obj *mqd_mem_obj = NULL;
> +	struct kfd_mem_obj *mqd_mem_obj;
>   
>   	mqd_mem_obj = kzalloc(sizeof(struct kfd_mem_obj), GFP_KERNEL);
>   	if (!mqd_mem_obj)
> @@ -64,7 +64,7 @@ struct kfd_mem_obj *allocate_hiq_mqd(struct kfd_node *dev, struct queue_properti
>   struct kfd_mem_obj *allocate_sdma_mqd(struct kfd_node *dev,
>   					struct queue_properties *q)
>   {
> -	struct kfd_mem_obj *mqd_mem_obj = NULL;
> +	struct kfd_mem_obj *mqd_mem_obj;
>   	uint64_t offset;
>   
>   	mqd_mem_obj = kzalloc(sizeof(struct kfd_mem_obj), GFP_KERNEL);