Re: [PATCH 1/2] spi: cadence-quadspi: use macro SIMPLE_DEV_PM_OPS

From: "Gole, Dhruva" <d-gole@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Vaishnav Achath <vaishnav.a@ti.com>, Vignesh <vigneshr@ti.com>,
	Apurva Nandan <a-nandan@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-spi@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: cadence-quadspi: use macro SIMPLE_DEV_PM_OPS
Date: Tue, 18 Apr 2023 19:47:57 +0530	[thread overview]
Message-ID: <c2cc4f31-97e0-fa1a-befd-f0dfad751022@ti.com> (raw)
In-Reply-To: <e65683c1-9f1b-4cfb-8e14-087ef7d69595@sirena.org.uk>

Hi Mark, Thanks for going through my patch.

On 4/18/2023 6:22 PM, Mark Brown wrote:
> On Mon, Apr 17, 2023 at 02:40:26PM +0530, Dhruva Gole wrote:
>
>> -static const struct dev_pm_ops cqspi__dev_pm_ops = {
>> -	.suspend = cqspi_suspend,
>> -	.resume = cqspi_resume,
>> -};
>> +static SIMPLE_DEV_PM_OPS(cqspi__dev_pm_ops, cqspi_suspend, cqspi_resume);
>>  
>>  #define CQSPI_DEV_PM_OPS	(&cqspi__dev_pm_ops)
>>  #else
> These days you should use DEFINE_SIMPLE_DEV_PM_OPS() instead.

Sure, I can respin this series with this macro instead,

https://elixir.bootlin.com/linux/v6.1/source/include/linux/pm.h#L399

So essentially it will look like,

static DEFINE_SIMPLE_DEV_PM_OPS(cqspi__dev_pm_ops, cqspi_suspend, cqspi_resume);

Are there any other improvements you'd like me to make in my next revision of this series?

-- 
Regards,
Dhruva Gole <d-gole@ti.com>