From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: linux-clk@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: [PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()
Date: Tue, 12 Dec 2023 18:26:39 +0100 [thread overview]
Message-ID: <c39cc382fcceca0166440367307260c10de7200d.1702400947.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1702400947.git.u.kleine-koenig@pengutronix.de>
clk_rate_exclusive_get() returns 0 unconditionally. So remove error
handling. This prepares making clk_rate_exclusive_get() return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
btw, the driver fails to call clk_rate_exclusive_put() in the error
paths of dw_mipi_dsi_phy_init().
Best regards
Uwe
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
index a6bc1bdb3d0d..49571f1ed88a 100644
--- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
+++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
@@ -88,15 +88,9 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
}
/* Make sure the rate of the bit clock is not modified by someone else */
- ret = clk_rate_exclusive_get(mipi_dsi->bit_clk);
- if (ret) {
- dev_err(mipi_dsi->dev,
- "Failed to set the exclusivity on the bit clock rate (ret %d)\n", ret);
- return ret;
- }
+ clk_rate_exclusive_get(mipi_dsi->bit_clk);
ret = clk_set_rate(mipi_dsi->px_clk, mipi_dsi->mode->clock * 1000);
-
if (ret) {
dev_err(mipi_dsi->dev, "Failed to set DSI Pixel clock rate %u (%d)\n",
mipi_dsi->mode->clock * 1000, ret);
--
2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: kernel@pengutronix.de, Neil Armstrong <neil.armstrong@linaro.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: [PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()
Date: Tue, 12 Dec 2023 18:26:39 +0100 [thread overview]
Message-ID: <c39cc382fcceca0166440367307260c10de7200d.1702400947.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1702400947.git.u.kleine-koenig@pengutronix.de>
clk_rate_exclusive_get() returns 0 unconditionally. So remove error
handling. This prepares making clk_rate_exclusive_get() return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
btw, the driver fails to call clk_rate_exclusive_put() in the error
paths of dw_mipi_dsi_phy_init().
Best regards
Uwe
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
index a6bc1bdb3d0d..49571f1ed88a 100644
--- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
+++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
@@ -88,15 +88,9 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
}
/* Make sure the rate of the bit clock is not modified by someone else */
- ret = clk_rate_exclusive_get(mipi_dsi->bit_clk);
- if (ret) {
- dev_err(mipi_dsi->dev,
- "Failed to set the exclusivity on the bit clock rate (ret %d)\n", ret);
- return ret;
- }
+ clk_rate_exclusive_get(mipi_dsi->bit_clk);
ret = clk_set_rate(mipi_dsi->px_clk, mipi_dsi->mode->clock * 1000);
-
if (ret) {
dev_err(mipi_dsi->dev, "Failed to set DSI Pixel clock rate %u (%d)\n",
mipi_dsi->mode->clock * 1000, ret);
--
2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: linux-clk@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: [PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()
Date: Tue, 12 Dec 2023 18:26:39 +0100 [thread overview]
Message-ID: <c39cc382fcceca0166440367307260c10de7200d.1702400947.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1702400947.git.u.kleine-koenig@pengutronix.de>
clk_rate_exclusive_get() returns 0 unconditionally. So remove error
handling. This prepares making clk_rate_exclusive_get() return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
btw, the driver fails to call clk_rate_exclusive_put() in the error
paths of dw_mipi_dsi_phy_init().
Best regards
Uwe
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
index a6bc1bdb3d0d..49571f1ed88a 100644
--- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
+++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
@@ -88,15 +88,9 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
}
/* Make sure the rate of the bit clock is not modified by someone else */
- ret = clk_rate_exclusive_get(mipi_dsi->bit_clk);
- if (ret) {
- dev_err(mipi_dsi->dev,
- "Failed to set the exclusivity on the bit clock rate (ret %d)\n", ret);
- return ret;
- }
+ clk_rate_exclusive_get(mipi_dsi->bit_clk);
ret = clk_set_rate(mipi_dsi->px_clk, mipi_dsi->mode->clock * 1000);
-
if (ret) {
dev_err(mipi_dsi->dev, "Failed to set DSI Pixel clock rate %u (%d)\n",
mipi_dsi->mode->clock * 1000, ret);
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: linux-clk@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: [PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()
Date: Tue, 12 Dec 2023 18:26:39 +0100 [thread overview]
Message-ID: <c39cc382fcceca0166440367307260c10de7200d.1702400947.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1702400947.git.u.kleine-koenig@pengutronix.de>
clk_rate_exclusive_get() returns 0 unconditionally. So remove error
handling. This prepares making clk_rate_exclusive_get() return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
btw, the driver fails to call clk_rate_exclusive_put() in the error
paths of dw_mipi_dsi_phy_init().
Best regards
Uwe
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
index a6bc1bdb3d0d..49571f1ed88a 100644
--- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
+++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
@@ -88,15 +88,9 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
}
/* Make sure the rate of the bit clock is not modified by someone else */
- ret = clk_rate_exclusive_get(mipi_dsi->bit_clk);
- if (ret) {
- dev_err(mipi_dsi->dev,
- "Failed to set the exclusivity on the bit clock rate (ret %d)\n", ret);
- return ret;
- }
+ clk_rate_exclusive_get(mipi_dsi->bit_clk);
ret = clk_set_rate(mipi_dsi->px_clk, mipi_dsi->mode->clock * 1000);
-
if (ret) {
dev_err(mipi_dsi->dev, "Failed to set DSI Pixel clock rate %u (%d)\n",
mipi_dsi->mode->clock * 1000, ret);
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-12-12 17:26 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:26 [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` [PATCH 1/5] PM / devfreq: sun8i-a33-mbus: Simplify usage of clk_rate_exclusive_get() Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 18:16 ` Andre Przywara
2023-12-12 18:16 ` Andre Przywara
2023-12-12 17:26 ` Uwe Kleine-König [this message]
2023-12-12 17:26 ` [PATCH 2/5] drm/meson: " Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` [PATCH 3/5] memory: tegra210-emc: " Uwe Kleine-König
2023-12-13 6:11 ` Krzysztof Kozlowski
2023-12-15 12:50 ` kernel test robot
2023-12-12 17:26 ` [PATCH 4/5] memory: tegra30-emc: " Uwe Kleine-König
2023-12-13 6:11 ` Krzysztof Kozlowski
2023-12-15 14:20 ` kernel test robot
2023-12-12 17:26 ` [PATCH 5/5] clk: Make clk_rate_exclusive_get() return void Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-12 17:26 ` Uwe Kleine-König
2023-12-13 7:16 ` [PATCH 0/5] " Maxime Ripard
2023-12-13 7:16 ` Maxime Ripard
2023-12-13 7:16 ` Maxime Ripard
2023-12-13 7:16 ` Maxime Ripard
2023-12-13 7:43 ` Uwe Kleine-König
2023-12-13 7:43 ` Uwe Kleine-König
2023-12-13 7:43 ` Uwe Kleine-König
2023-12-13 7:43 ` Uwe Kleine-König
2023-12-13 8:36 ` Maxime Ripard
2023-12-13 8:36 ` Maxime Ripard
2023-12-13 8:36 ` Maxime Ripard
2023-12-13 8:36 ` Maxime Ripard
2023-12-13 11:08 ` Uwe Kleine-König
2023-12-13 11:08 ` Uwe Kleine-König
2023-12-13 11:08 ` Uwe Kleine-König
2023-12-13 11:08 ` Uwe Kleine-König
2023-12-13 11:54 ` Maxime Ripard
2023-12-13 11:54 ` Maxime Ripard
2023-12-13 11:54 ` Maxime Ripard
2023-12-13 11:54 ` Maxime Ripard
2023-12-13 15:52 ` Uwe Kleine-König
2023-12-13 15:52 ` Uwe Kleine-König
2023-12-13 15:52 ` Uwe Kleine-König
2023-12-13 15:52 ` Uwe Kleine-König
2023-12-15 12:34 ` Maxime Ripard
2023-12-15 12:34 ` Maxime Ripard
2023-12-15 12:34 ` Maxime Ripard
2023-12-15 12:34 ` Maxime Ripard
2023-12-15 15:15 ` Uwe Kleine-König
2023-12-15 15:15 ` Uwe Kleine-König
2023-12-15 15:15 ` Uwe Kleine-König
2023-12-15 15:15 ` Uwe Kleine-König
2023-12-15 18:49 ` Uwe Kleine-König
2023-12-15 18:49 ` Uwe Kleine-König
2023-12-15 18:49 ` Uwe Kleine-König
2023-12-15 18:49 ` Uwe Kleine-König
2023-12-13 16:44 ` Neil Armstrong
2023-12-13 16:44 ` Neil Armstrong
2023-12-13 16:44 ` Neil Armstrong
2023-12-13 16:44 ` Neil Armstrong
2023-12-15 9:11 ` Maxime Ripard
2023-12-15 9:11 ` Maxime Ripard
2023-12-15 9:11 ` Maxime Ripard
2023-12-15 9:11 ` Maxime Ripard
2023-12-15 9:46 ` Jerome Brunet
2023-12-15 9:46 ` Jerome Brunet
2023-12-15 9:46 ` Jerome Brunet
2023-12-15 9:46 ` Jerome Brunet
2023-12-15 8:41 ` Jerome Brunet
2023-12-15 8:41 ` Jerome Brunet
2023-12-15 8:41 ` Jerome Brunet
2023-12-15 8:41 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c39cc382fcceca0166440367307260c10de7200d.1702400947.git.u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.