From: Philipp Rossak <embed3d@gmail.com> To: Samuel Holland <samuel@sholland.org>, lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, davem@davemloft.net, hans.verkuil@cisco.com, mchehab@kernel.org, rask@formelder.dk, clabbe.montjoie@gmail.com, sean@mess.org, krzk@kernel.org, quentin.schulz@free-electrons.com, icenowy@aosc.io, edu.molinas@gmail.com, singhalsimran0@gmail.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] [PATCH 16/16] arm: dts: sun8i: a83t: add thermal zone to A83T Date: Fri, 26 Jan 2018 18:35:38 +0100 [thread overview] Message-ID: <c4153c3b-ff8d-0607-f3f4-3a7827f23348@gmail.com> (raw) In-Reply-To: <6ee10c04-6602-b927-5f47-64d6beb10625@sholland.org> On 26.01.2018 17:25, Samuel Holland wrote: > On 01/26/18 09:19, Philipp Rossak wrote: >> This patch adds the thermal zones to the A83T. Sensor 0 is located in the >> cpu cluster 0. Sensor 1 is located in cluster 1 and Sensor 3 is located >> in the gpu. > > You mention sensor 3 here, but have sensor 2 in the device tree. That is a typo/wrong counting error. This should be sensor 2. I will fix that in the next version of this patch series. >> Signed-off-by: Philipp Rossak <embed3d@gmail.com> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 9e53ff5ac4ed..4259a8726031 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -747,4 +747,24 @@ >> #size-cells = <0>; >> }; >> }; >> + >> + thermal-zones { >> + cpu0_thermal: cpu0-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 0>; >> + }; >> + >> + cpu1_thermal: cpu1-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 1>; >> + }; >> + >> + gpu_thermal: gpu-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 2>; > > ^^^^ here > >> + }; >> + }; >> }; >> > > Thanks, > Samuel > Thanks, Philipp
WARNING: multiple messages have this Message-ID (diff)
From: embed3d@gmail.com (Philipp Rossak) To: linux-arm-kernel@lists.infradead.org Subject: [linux-sunxi] [PATCH 16/16] arm: dts: sun8i: a83t: add thermal zone to A83T Date: Fri, 26 Jan 2018 18:35:38 +0100 [thread overview] Message-ID: <c4153c3b-ff8d-0607-f3f4-3a7827f23348@gmail.com> (raw) In-Reply-To: <6ee10c04-6602-b927-5f47-64d6beb10625@sholland.org> On 26.01.2018 17:25, Samuel Holland wrote: > On 01/26/18 09:19, Philipp Rossak wrote: >> This patch adds the thermal zones to the A83T. Sensor 0 is located in the >> cpu cluster 0. Sensor 1 is located in cluster 1 and Sensor 3 is located >> in the gpu. > > You mention sensor 3 here, but have sensor 2 in the device tree. That is a typo/wrong counting error. This should be sensor 2. I will fix that in the next version of this patch series. >> Signed-off-by: Philipp Rossak <embed3d@gmail.com> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 9e53ff5ac4ed..4259a8726031 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -747,4 +747,24 @@ >> #size-cells = <0>; >> }; >> }; >> + >> + thermal-zones { >> + cpu0_thermal: cpu0-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 0>; >> + }; >> + >> + cpu1_thermal: cpu1-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 1>; >> + }; >> + >> + gpu_thermal: gpu-thermal { >> + polling-delay-passive = <1000>; >> + polling-delay = <5000>; >> + thermal-sensors = <&ths 2>; > > ^^^^ here > >> + }; >> + }; >> }; >> > > Thanks, > Samuel > Thanks, Philipp
next prev parent reply other threads:[~2018-01-26 17:35 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-26 15:19 [PATCH 00/16] IIO-based thermal sensor driver for Allwinner H3 and A83T SoC Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 01/16] dt-bindings: update the Allwinner GPADC device tree binding for H3 & A83T Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 02/16] arm: config: sunxi_defconfig: enable SUN4I_GPADC Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 03/16] iio: adc: sun4i-gpadc-iio: rename A33-specified registers to contain A33 Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 8:34 ` Jonathan Cameron 2018-01-28 8:34 ` Jonathan Cameron 2018-01-28 8:34 ` Jonathan Cameron 2018-01-26 15:19 ` [PATCH 04/16] iio: adc: sun4i-gpadc-iio: rework: sampling start/end code readout reg Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 8:43 ` Jonathan Cameron 2018-01-28 8:43 ` Jonathan Cameron 2018-01-28 13:34 ` Philipp Rossak 2018-01-28 13:34 ` Philipp Rossak 2018-01-28 13:34 ` Philipp Rossak 2018-01-28 13:37 ` Icenowy Zheng 2018-01-28 13:37 ` Icenowy Zheng 2018-01-28 14:32 ` Philipp Rossak 2018-01-28 14:32 ` Philipp Rossak 2018-01-28 14:32 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 05/16] iio: adc: sun4i-gpadc-iio: rework: support clocks and reset Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 8:50 ` Jonathan Cameron 2018-01-28 8:50 ` Jonathan Cameron 2018-01-28 11:34 ` Philipp Rossak 2018-01-28 11:34 ` Philipp Rossak 2018-01-28 11:34 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 06/16] iio: adc: sun4i-gpadc-iio: rework: support multible sensors Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 9:08 ` Jonathan Cameron 2018-01-28 9:08 ` Jonathan Cameron 2018-01-28 9:08 ` Jonathan Cameron 2018-01-28 14:10 ` Philipp Rossak 2018-01-28 14:10 ` Philipp Rossak 2018-01-28 14:10 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 07/16] iio: adc: sun4i-gpadc-iio: rework: support nvmem calibration data Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 9:02 ` Jonathan Cameron 2018-01-28 9:02 ` Jonathan Cameron 2018-01-28 9:02 ` Jonathan Cameron 2018-01-28 13:46 ` Philipp Rossak 2018-01-28 13:46 ` Philipp Rossak 2018-01-28 13:46 ` Philipp Rossak 2018-01-28 13:52 ` Icenowy Zheng 2018-01-28 13:52 ` Icenowy Zheng 2018-01-28 13:52 ` Icenowy Zheng 2018-01-28 14:39 ` Philipp Rossak 2018-01-28 14:39 ` Philipp Rossak 2018-01-28 14:39 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 08/16] iio: adc: sun4i-gpadc-iio: rework: add interrupt support Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-28 9:06 ` Jonathan Cameron 2018-01-28 9:06 ` Jonathan Cameron 2018-01-28 9:06 ` Jonathan Cameron 2018-01-28 13:48 ` Philipp Rossak 2018-01-28 13:48 ` Philipp Rossak 2018-01-28 13:48 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 09/16] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 10/16] iio: adc: sun4i-gpadc-iio: add support for A83T " Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 17:46 ` [linux-sunxi] " Ondřej Jirman 2018-01-26 17:46 ` Ondřej Jirman 2018-01-26 17:46 ` Ondřej Jirman 2018-01-27 4:30 ` Philipp Rossak 2018-01-27 4:30 ` Philipp Rossak 2018-01-27 4:30 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 11/16] arm: dts: sunxi-h3-h5: add support for the thermal sensor in H3 and H5 Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 12/16] arm: dts: sun8i: h3: add support for the thermal sensor in H3 Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 13/16] arm: dts: sun8i: h3: add thermal zone to H3 Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 16:26 ` [linux-sunxi] " Samuel Holland 2018-01-26 16:26 ` Samuel Holland 2018-01-26 16:26 ` Samuel Holland 2018-01-26 17:48 ` [linux-sunxi] " Philipp Rossak 2018-01-26 17:48 ` Philipp Rossak 2018-01-26 17:48 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 14/16] arm: dts: sun8i: h3: enable H3 sid controller Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 15/16] arm: dts: sun8i: a83t: add support for the thermal sensor in A83T Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` [PATCH 16/16] arm: dts: sun8i: a83t: add thermal zone to A83T Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 15:19 ` Philipp Rossak 2018-01-26 16:25 ` [linux-sunxi] " Samuel Holland 2018-01-26 16:25 ` Samuel Holland 2018-01-26 16:25 ` Samuel Holland 2018-01-26 17:35 ` Philipp Rossak [this message] 2018-01-26 17:35 ` [linux-sunxi] " Philipp Rossak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c4153c3b-ff8d-0607-f3f4-3a7827f23348@gmail.com \ --to=embed3d@gmail.com \ --cc=clabbe.montjoie@gmail.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edu.molinas@gmail.com \ --cc=hans.verkuil@cisco.com \ --cc=icenowy@aosc.io \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=krzk@kernel.org \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@free-electrons.com \ --cc=mchehab@kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=quentin.schulz@free-electrons.com \ --cc=rask@formelder.dk \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=sean@mess.org \ --cc=singhalsimran0@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.