From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-s390x@nongnu.org
Cc: alex.williamson@redhat.com, schnelle@linux.ibm.com,
cohuck@redhat.com, farman@linux.ibm.com, pmorel@linux.ibm.com,
richard.henderson@linaro.org, david@redhat.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com, mst@redhat.com,
pbonzini@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 4/9] s390x/pci: enable for load/store intepretation
Date: Tue, 18 Jan 2022 13:14:20 -0500 [thread overview]
Message-ID: <c4332e29-755d-378f-1e10-de8cc75f0387@linux.ibm.com> (raw)
In-Reply-To: <9f55cf89-9d58-b1c5-0d97-d0730498b62f@redhat.com>
On 1/17/22 10:38 AM, Thomas Huth wrote:
> On 14/01/2022 21.38, Matthew Rosato wrote:
>> Use the associated vfio feature ioctl to enable interpretation for
>> devices
>> when requested. As part of this process, we must use the host function
>> handle rather than a QEMU-generated one -- this is provided as part of
>> the
>> ioctl payload.
>>
>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>> ---
>> hw/s390x/s390-pci-bus.c | 70 +++++++++++++++++++++++++++++++-
>> hw/s390x/s390-pci-inst.c | 63 +++++++++++++++++++++++++++-
>> hw/s390x/s390-pci-vfio.c | 52 ++++++++++++++++++++++++
>> include/hw/s390x/s390-pci-bus.h | 1 +
>> include/hw/s390x/s390-pci-vfio.h | 15 +++++++
>> 5 files changed, 199 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
>> index 01b58ebc70..a39ccfee05 100644
>> --- a/hw/s390x/s390-pci-bus.c
>> +++ b/hw/s390x/s390-pci-bus.c
> ...
>> @@ -1360,6 +1427,7 @@ static Property s390_pci_device_properties[] = {
>> DEFINE_PROP_UINT16("uid", S390PCIBusDevice, uid, UID_UNDEFINED),
>> DEFINE_PROP_S390_PCI_FID("fid", S390PCIBusDevice, fid),
>> DEFINE_PROP_STRING("target", S390PCIBusDevice, target),
>> + DEFINE_PROP_BOOL("interp", S390PCIBusDevice, interp, true),
>> DEFINE_PROP_END_OF_LIST(),
>> };
>
> Since this is something that the user can see, would it maybe make sense
> to provide a full word instead of an abbreviation here? I.e. "interpret"
> or "interpretation" instead of "interp" ?
I'll go with "interpret" unless someone else has a strong opinion on it.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-s390x@nongnu.org
Cc: farman@linux.ibm.com, kvm@vger.kernel.org, pmorel@linux.ibm.com,
schnelle@linux.ibm.com, cohuck@redhat.com,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
pasic@linux.ibm.com, alex.williamson@redhat.com, mst@redhat.com,
pbonzini@redhat.com, david@redhat.com, borntraeger@linux.ibm.com
Subject: Re: [PATCH v2 4/9] s390x/pci: enable for load/store intepretation
Date: Tue, 18 Jan 2022 13:14:20 -0500 [thread overview]
Message-ID: <c4332e29-755d-378f-1e10-de8cc75f0387@linux.ibm.com> (raw)
In-Reply-To: <9f55cf89-9d58-b1c5-0d97-d0730498b62f@redhat.com>
On 1/17/22 10:38 AM, Thomas Huth wrote:
> On 14/01/2022 21.38, Matthew Rosato wrote:
>> Use the associated vfio feature ioctl to enable interpretation for
>> devices
>> when requested. As part of this process, we must use the host function
>> handle rather than a QEMU-generated one -- this is provided as part of
>> the
>> ioctl payload.
>>
>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>> ---
>> hw/s390x/s390-pci-bus.c | 70 +++++++++++++++++++++++++++++++-
>> hw/s390x/s390-pci-inst.c | 63 +++++++++++++++++++++++++++-
>> hw/s390x/s390-pci-vfio.c | 52 ++++++++++++++++++++++++
>> include/hw/s390x/s390-pci-bus.h | 1 +
>> include/hw/s390x/s390-pci-vfio.h | 15 +++++++
>> 5 files changed, 199 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
>> index 01b58ebc70..a39ccfee05 100644
>> --- a/hw/s390x/s390-pci-bus.c
>> +++ b/hw/s390x/s390-pci-bus.c
> ...
>> @@ -1360,6 +1427,7 @@ static Property s390_pci_device_properties[] = {
>> DEFINE_PROP_UINT16("uid", S390PCIBusDevice, uid, UID_UNDEFINED),
>> DEFINE_PROP_S390_PCI_FID("fid", S390PCIBusDevice, fid),
>> DEFINE_PROP_STRING("target", S390PCIBusDevice, target),
>> + DEFINE_PROP_BOOL("interp", S390PCIBusDevice, interp, true),
>> DEFINE_PROP_END_OF_LIST(),
>> };
>
> Since this is something that the user can see, would it maybe make sense
> to provide a full word instead of an abbreviation here? I.e. "interpret"
> or "interpretation" instead of "interp" ?
I'll go with "interpret" unless someone else has a strong opinion on it.
next prev parent reply other threads:[~2022-01-18 18:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 20:38 [PATCH v2 0/9] s390x/pci: zPCI interpretation support Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 1/9] Update linux headers Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 2/9] target/s390x: add zpci-interp to cpu models Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 3/9] fixup: force interp off for QEMU machine 6.2 and older Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 21:04 ` Matthew Rosato
2022-01-14 21:04 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 4/9] s390x/pci: enable for load/store intepretation Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-17 14:51 ` Thomas Huth
2022-01-17 14:51 ` Thomas Huth
2022-01-18 18:08 ` Matthew Rosato
2022-01-18 18:08 ` Matthew Rosato
2022-01-17 15:38 ` Thomas Huth
2022-01-17 15:38 ` Thomas Huth
2022-01-18 18:14 ` Matthew Rosato [this message]
2022-01-18 18:14 ` Matthew Rosato
2022-01-31 9:37 ` Pierre Morel
2022-01-31 9:37 ` Pierre Morel
2022-01-31 14:46 ` Pierre Morel
2022-01-31 17:11 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 5/9] s390x/pci: don't fence interpreted devices without MSI-X Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 6/9] s390x/pci: enable adapter event notification for interpreted devices Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-31 15:10 ` Pierre Morel
2022-01-31 15:10 ` Pierre Morel
2022-01-31 17:08 ` Matthew Rosato
2022-01-31 17:08 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 7/9] s390x/pci: use I/O Address Translation assist when interpreting Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 8/9] s390x/pci: use dtsm provided from vfio capabilities for interpreted devices Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-14 20:38 ` [PATCH v2 9/9] s390x/pci: let intercept devices have separate PCI groups Matthew Rosato
2022-01-14 20:38 ` Matthew Rosato
2022-01-17 15:23 ` [PATCH v2 0/9] s390x/pci: zPCI interpretation support Thomas Huth
2022-01-17 15:23 ` Thomas Huth
2022-01-18 18:32 ` Matthew Rosato
2022-01-18 18:32 ` Matthew Rosato
2022-02-04 12:39 ` Michael S. Tsirkin
2022-02-04 12:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4332e29-755d-378f-1e10-de8cc75f0387@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.