From: Joshua Kinard <kumba@gentoo.org>
To: Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Ulf Hansson <ulf.hansson@linaro.org>,
Yangbo Lu <yangbo.lu@nxp.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>,
linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff
Date: Mon, 31 Jul 2023 11:08:41 -0400 [thread overview]
Message-ID: <c545bc4f-6fe9-eca4-535e-2380fd639ea3@gentoo.org> (raw)
In-Reply-To: <20230731083806.453036-4-hch@lst.de>
On 7/31/2023 04:38, Christoph Hellwig wrote:
> ds1685_rtc_poweroff is only used externally via symbol_get, which was
> only ever intended for very internal symbols like this one. Use
> EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used
> on EXPORT_SYMBOL_GPL symbols.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/rtc/rtc-ds1685.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 0f707be0eb87fa..04dbf35cf3b706 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
> unreachable();
> }
> }
> -EXPORT_SYMBOL(ds1685_rtc_poweroff);
> +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff);
> /* ----------------------------------------------------------------------- */
>
>
Acked-by: Joshua Kinard <kumba@gentoo.org>
WARNING: multiple messages have this Message-ID (diff)
From: Joshua Kinard <kumba@gentoo.org>
To: Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Ulf Hansson <ulf.hansson@linaro.org>,
Yangbo Lu <yangbo.lu@nxp.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>,
linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff
Date: Mon, 31 Jul 2023 11:08:41 -0400 [thread overview]
Message-ID: <c545bc4f-6fe9-eca4-535e-2380fd639ea3@gentoo.org> (raw)
In-Reply-To: <20230731083806.453036-4-hch@lst.de>
On 7/31/2023 04:38, Christoph Hellwig wrote:
> ds1685_rtc_poweroff is only used externally via symbol_get, which was
> only ever intended for very internal symbols like this one. Use
> EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used
> on EXPORT_SYMBOL_GPL symbols.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/rtc/rtc-ds1685.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 0f707be0eb87fa..04dbf35cf3b706 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
> unreachable();
> }
> }
> -EXPORT_SYMBOL(ds1685_rtc_poweroff);
> +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff);
> /* ----------------------------------------------------------------------- */
>
>
Acked-by: Joshua Kinard <kumba@gentoo.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-31 15:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 8:38 require EXPORT_SYMBOL_GPL symbols for symbol_get Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 8:38 ` [PATCH 1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 16:12 ` Arnd Bergmann
2023-07-31 16:12 ` Arnd Bergmann
2023-07-31 16:26 ` Christoph Hellwig
2023-07-31 16:26 ` Christoph Hellwig
2023-07-31 8:38 ` [PATCH 2/5] net: enetc: use EXPORT_SYMBOL_GPL for enetc_phc_index Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 18:19 ` Jakub Kicinski
2023-07-31 18:19 ` Jakub Kicinski
2023-07-31 8:38 ` [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 15:08 ` Joshua Kinard [this message]
2023-07-31 15:08 ` Joshua Kinard
2023-07-31 8:38 ` [PATCH 4/5] mmc: use EXPORT_SYMBOL_GPL for mmc_detect_change Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 16:57 ` Christoph Hellwig
2023-07-31 16:57 ` Christoph Hellwig
2023-07-31 8:38 ` [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules Christoph Hellwig
2023-07-31 8:38 ` Christoph Hellwig
2023-07-31 11:05 ` Greg Kroah-Hartman
2023-07-31 11:05 ` Greg Kroah-Hartman
2023-07-31 18:11 ` Simon Horman
2023-07-31 18:11 ` Simon Horman
2023-07-31 20:38 ` Luis Chamberlain
2023-07-31 20:38 ` Luis Chamberlain
2023-07-31 11:05 ` require EXPORT_SYMBOL_GPL symbols for symbol_get Greg Kroah-Hartman
2023-07-31 11:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c545bc4f-6fe9-eca4-535e-2380fd639ea3@gentoo.org \
--to=kumba@gentoo.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=ulf.hansson@linaro.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.