From: Alex Shi <alex.shi@linux.alibaba.com> To: Johannes Weiner <hannes@cmpxchg.org>, Joonsoo Kim <js1304@gmail.com> Cc: Shakeel Butt <shakeelb@google.com>, Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Roman Gushchin <guro@fb.com>, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 01/18] mm: fix NUMA node file count error in replace_page_cache() Date: Tue, 21 Apr 2020 16:28:10 +0800 [thread overview] Message-ID: <c5c379d5-d580-58ec-c9d1-f05d6cdc57b4@linux.alibaba.com> (raw) In-Reply-To: <20200420221126.341272-2-hannes@cmpxchg.org> 在 2020/4/21 上午6:11, Johannes Weiner 写道: > When replacing one page with another one in the cache, we have to > decrease the file count of the old page's NUMA node and increase the > one of the new NUMA node, otherwise the old node leaks the count and > the new node eventually underflows its counter. > > Fixes: 74d609585d8b ("page cache: Add and replace pages using the XArray") > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com> > --- > mm/filemap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23a051a7ef0f..49e3b5da0216 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -808,11 +808,11 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask) > old->mapping = NULL; > /* hugetlb pages do not participate in page cache accounting. */ > if (!PageHuge(old)) > - __dec_node_page_state(new, NR_FILE_PAGES); > + __dec_node_page_state(old, NR_FILE_PAGES); > if (!PageHuge(new)) > __inc_node_page_state(new, NR_FILE_PAGES); > if (PageSwapBacked(old)) > - __dec_node_page_state(new, NR_SHMEM); > + __dec_node_page_state(old, NR_SHMEM); > if (PageSwapBacked(new)) > __inc_node_page_state(new, NR_SHMEM); > xas_unlock_irqrestore(&xas, flags); >
WARNING: multiple messages have this Message-ID (diff)
From: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Joonsoo Kim <js1304-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>, "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>, Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org Subject: Re: [PATCH 01/18] mm: fix NUMA node file count error in replace_page_cache() Date: Tue, 21 Apr 2020 16:28:10 +0800 [thread overview] Message-ID: <c5c379d5-d580-58ec-c9d1-f05d6cdc57b4@linux.alibaba.com> (raw) In-Reply-To: <20200420221126.341272-2-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> ÔÚ 2020/4/21 ÉÏÎç6:11, Johannes Weiner дµÀ: > When replacing one page with another one in the cache, we have to > decrease the file count of the old page's NUMA node and increase the > one of the new NUMA node, otherwise the old node leaks the count and > the new node eventually underflows its counter. > > Fixes: 74d609585d8b ("page cache: Add and replace pages using the XArray") > Signed-off-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Reviewed-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> > --- > mm/filemap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23a051a7ef0f..49e3b5da0216 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -808,11 +808,11 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask) > old->mapping = NULL; > /* hugetlb pages do not participate in page cache accounting. */ > if (!PageHuge(old)) > - __dec_node_page_state(new, NR_FILE_PAGES); > + __dec_node_page_state(old, NR_FILE_PAGES); > if (!PageHuge(new)) > __inc_node_page_state(new, NR_FILE_PAGES); > if (PageSwapBacked(old)) > - __dec_node_page_state(new, NR_SHMEM); > + __dec_node_page_state(old, NR_SHMEM); > if (PageSwapBacked(new)) > __inc_node_page_state(new, NR_SHMEM); > xas_unlock_irqrestore(&xas, flags); >
next prev parent reply other threads:[~2020-04-21 8:29 UTC|newest] Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-20 22:11 [PATCH 00/18] mm: memcontrol: charge swapin pages on instantiation Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-20 22:11 ` [PATCH 01/18] mm: fix NUMA node file count error in replace_page_cache() Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-21 8:28 ` Alex Shi [this message] 2020-04-21 8:28 ` Alex Shi 2020-04-21 19:13 ` Shakeel Butt 2020-04-21 19:13 ` Shakeel Butt 2020-04-21 19:13 ` Shakeel Butt 2020-04-22 6:34 ` Joonsoo Kim 2020-04-22 6:34 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 02/18] mm: memcontrol: fix theoretical race in charge moving Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-22 6:36 ` Joonsoo Kim 2020-04-22 6:36 ` Joonsoo Kim 2020-04-22 16:51 ` Shakeel Butt 2020-04-22 16:51 ` Shakeel Butt 2020-04-22 16:51 ` Shakeel Butt 2020-04-22 17:42 ` Johannes Weiner 2020-04-22 17:42 ` Johannes Weiner 2020-04-22 18:01 ` Shakeel Butt 2020-04-22 18:01 ` Shakeel Butt 2020-04-22 18:01 ` Shakeel Butt 2020-04-22 18:02 ` Shakeel Butt 2020-04-22 18:02 ` Shakeel Butt 2020-04-20 22:11 ` [PATCH 03/18] mm: memcontrol: drop @compound parameter from memcg charging API Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-21 9:11 ` Alex Shi 2020-04-21 9:11 ` Alex Shi 2020-04-22 6:37 ` Joonsoo Kim 2020-04-22 6:37 ` Joonsoo Kim 2020-04-22 17:30 ` Shakeel Butt 2020-04-22 17:30 ` Shakeel Butt 2020-04-22 17:30 ` Shakeel Butt 2020-04-20 22:11 ` [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling Johannes Weiner 2020-04-21 9:11 ` Alex Shi 2020-04-21 9:11 ` Alex Shi 2020-04-22 6:37 ` Joonsoo Kim 2020-04-22 6:37 ` Joonsoo Kim 2020-04-22 22:20 ` Shakeel Butt 2020-04-22 22:20 ` Shakeel Butt 2020-04-22 22:20 ` Shakeel Butt 2020-04-20 22:11 ` [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-21 9:12 ` Alex Shi 2020-04-21 9:12 ` Alex Shi 2020-04-22 6:40 ` Joonsoo Kim 2020-04-22 6:40 ` Joonsoo Kim 2020-04-22 12:09 ` Johannes Weiner 2020-04-22 12:09 ` Johannes Weiner 2020-04-23 5:25 ` Joonsoo Kim 2020-05-08 16:01 ` Johannes Weiner 2020-05-11 1:57 ` Joonsoo Kim 2020-05-11 7:38 ` Hugh Dickins 2020-05-11 7:38 ` Hugh Dickins 2020-05-11 7:38 ` Hugh Dickins 2020-05-11 15:06 ` Johannes Weiner 2020-05-11 16:32 ` Hugh Dickins 2020-05-11 16:32 ` Hugh Dickins 2020-05-11 16:32 ` Hugh Dickins 2020-05-11 18:10 ` Johannes Weiner 2020-05-11 18:10 ` Johannes Weiner 2020-05-11 18:12 ` Johannes Weiner 2020-05-11 18:44 ` Hugh Dickins 2020-05-11 18:44 ` Hugh Dickins 2020-05-11 18:44 ` Hugh Dickins 2020-04-20 22:11 ` [PATCH 06/18] mm: memcontrol: prepare uncharging for removal of private page type counters Johannes Weiner 2020-04-21 9:12 ` Alex Shi 2020-04-21 9:12 ` Alex Shi 2020-04-22 6:41 ` Joonsoo Kim 2020-04-22 6:41 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 07/18] mm: memcontrol: prepare move_account " Johannes Weiner 2020-04-21 9:13 ` Alex Shi 2020-04-21 9:13 ` Alex Shi 2020-04-22 6:41 ` Joonsoo Kim 2020-04-22 6:41 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 08/18] mm: memcontrol: prepare cgroup vmstat infrastructure for native anon counters Johannes Weiner 2020-04-22 6:42 ` Joonsoo Kim 2020-04-22 6:42 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 09/18] mm: memcontrol: switch to native NR_FILE_PAGES and NR_SHMEM counters Johannes Weiner 2020-04-22 6:42 ` Joonsoo Kim 2020-04-22 6:42 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 10/18] mm: memcontrol: switch to native NR_ANON_MAPPED counter Johannes Weiner 2020-04-22 6:51 ` Joonsoo Kim 2020-04-22 12:28 ` Johannes Weiner 2020-04-23 5:27 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 11/18] mm: memcontrol: switch to native NR_ANON_THPS counter Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-24 0:29 ` Joonsoo Kim 2020-04-24 0:29 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 12/18] mm: memcontrol: convert anon and file-thp to new mem_cgroup_charge() API Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-24 0:29 ` Joonsoo Kim 2020-04-24 0:29 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 13/18] mm: memcontrol: drop unused try/commit/cancel charge API Johannes Weiner 2020-04-24 0:30 ` Joonsoo Kim 2020-04-24 0:30 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 14/18] mm: memcontrol: prepare swap controller setup for integration Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-24 0:30 ` Joonsoo Kim 2020-04-24 0:30 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 15/18] mm: memcontrol: make swap tracking an integral part of memory control Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-21 9:27 ` Alex Shi 2020-04-21 9:27 ` Alex Shi 2020-04-21 14:39 ` Johannes Weiner 2020-04-21 14:39 ` Johannes Weiner 2020-04-22 3:14 ` Alex Shi 2020-04-22 3:14 ` Alex Shi 2020-04-22 13:30 ` Johannes Weiner 2020-04-22 13:30 ` Johannes Weiner 2020-04-22 13:40 ` Alex Shi 2020-04-22 13:43 ` Alex Shi 2020-04-24 0:30 ` Joonsoo Kim 2020-04-24 0:30 ` Joonsoo Kim 2020-04-24 3:01 ` Johannes Weiner 2020-04-20 22:11 ` [PATCH 16/18] mm: memcontrol: charge swapin pages on instantiation Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-21 9:21 ` Alex Shi 2020-04-21 9:21 ` Alex Shi 2020-04-24 0:44 ` Joonsoo Kim 2020-04-24 2:51 ` Johannes Weiner 2020-04-24 2:51 ` Johannes Weiner 2020-04-28 6:49 ` Joonsoo Kim 2020-04-28 6:49 ` Joonsoo Kim 2020-04-28 6:49 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 17/18] mm: memcontrol: delete unused lrucare handling Johannes Weiner 2020-04-20 22:11 ` Johannes Weiner 2020-04-24 0:46 ` Joonsoo Kim 2020-04-24 0:46 ` Joonsoo Kim 2020-04-20 22:11 ` [PATCH 18/18] mm: memcontrol: update page->mem_cgroup stability rules Johannes Weiner 2020-04-21 9:20 ` Alex Shi 2020-04-21 9:20 ` Alex Shi 2020-04-24 0:48 ` Joonsoo Kim 2020-04-24 0:48 ` Joonsoo Kim 2020-04-21 9:10 ` Hillf Danton 2020-04-21 14:34 ` Johannes Weiner 2020-04-21 14:34 ` Johannes Weiner 2020-04-21 9:32 ` [PATCH 00/18] mm: memcontrol: charge swapin pages on instantiation Alex Shi 2020-04-21 9:32 ` Alex Shi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c5c379d5-d580-58ec-c9d1-f05d6cdc57b4@linux.alibaba.com \ --to=alex.shi@linux.alibaba.com \ --cc=cgroups@vger.kernel.org \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=js1304@gmail.com \ --cc=kernel-team@fb.com \ --cc=kirill@shutemov.name \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=shakeelb@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.