From: Ezequiel Garcia <ezequiel@collabora.com> To: Helen Koike <helen.koike@collabora.com>, linux-rockchip@lists.infradead.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de, gregkh@linuxfoundation.org, andrey.konovalov@linaro.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, robh+dt@kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, joacim.zetterling@gmail.com, kernel@collabora.com, linux-media@vger.kernel.org, jacob-chen@iotwrt.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v12 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Date: Mon, 30 Dec 2019 15:25:10 -0300 [thread overview] Message-ID: <c6514f8e8bf49913e3cb907ba91c0a47de39e68c.camel@collabora.com> (raw) In-Reply-To: <20191227200116.2612137-2-helen.koike@collabora.com> Hi Helen, Thanks for taking care of this. On Fri, 2019-12-27 at 17:01 -0300, Helen Koike wrote: > From: Ezequiel Garcia <ezequiel@collabora.com> > > Add driver for Rockchip MIPI Synopsys DPHY driver > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > > --- > > Changes in v12: > - several cleanups > - remove "rx" from function names, as this driver only supports rx > > Changes in v11: > - fix checkpatch errors > > Changes in v10: None > Changes in v9: > - Move to staging > - replace memcpy by a directly assignment > - remove unecessary ret variable in rockchip_dphy_init > - s/0x1/1 > - s/0x0/0 > - coding style changes > - dphy_reg variable sizes > - variables from int to unsigned int > - rename functions to start with rk_ > - rename dphy0 to rx > - fix hardcoded lane0 usage > - disable rx on power off > - general cleanups of unused variables > > Changes in v8: > - Remove boiler plate license text > > Changes in v7: > - Migrate dphy specific code from > drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c > to drivers/phy/rockchip/phy-rockchip-dphy.c > - Drop support for rk3288 > - Drop support for dphy txrx > - code styling and checkpatch fixes > > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > .../staging/media/phy-rockchip-dphy/Kconfig | 11 + > .../staging/media/phy-rockchip-dphy/Makefile | 2 + > drivers/staging/media/phy-rockchip-dphy/TODO | 6 + > .../phy-rockchip-dphy/phy-rockchip-dphy.c | 396 ++++++++++++++++++ > 6 files changed, 418 insertions(+) > create mode 100644 drivers/staging/media/phy-rockchip-dphy/Kconfig > create mode 100644 drivers/staging/media/phy-rockchip-dphy/Makefile > create mode 100644 drivers/staging/media/phy-rockchip-dphy/TODO > create mode 100644 drivers/staging/media/phy-rockchip-dphy/phy-rockchip-dphy.c > > diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig > index 642adc4c24d2..a47484473883 100644 > --- a/drivers/staging/media/Kconfig > +++ b/drivers/staging/media/Kconfig > @@ -38,4 +38,6 @@ source "drivers/staging/media/ipu3/Kconfig" > > source "drivers/staging/media/soc_camera/Kconfig" > > +source "drivers/staging/media/phy-rockchip-dphy/Kconfig" > + > endif > diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile > index 2f1711a8aeed..b0eae3906208 100644 > --- a/drivers/staging/media/Makefile > +++ b/drivers/staging/media/Makefile > @@ -8,3 +8,4 @@ obj-$(CONFIG_TEGRA_VDE) += tegra-vde/ > obj-$(CONFIG_VIDEO_HANTRO) += hantro/ > obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3/ > obj-$(CONFIG_SOC_CAMERA) += soc_camera/ > +obj-$(CONFIG_PHY_ROCKCHIP_DPHY) += phy-rockchip-dphy/ > diff --git a/drivers/staging/media/phy-rockchip-dphy/Kconfig b/drivers/staging/media/phy-rockchip-dphy/Kconfig > new file mode 100644 > index 000000000000..7378bd75fa7c > --- /dev/null Seems I overlooked the Kconfig file for this driver, sorry about that! > +++ b/drivers/staging/media/phy-rockchip-dphy/Kconfig > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Phy drivers for Rockchip platforms > +# > +config PHY_ROCKCHIP_DPHY > + tristate "Rockchip MIPI Synopsys DPHY driver" > + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + select GENERIC_PHY_MIPI_DPHY > + select GENERIC_PHY > + help > + Enable this to support the Rockchip MIPI Synopsys DPHY. Following a more user-friendly convention, this should read more like: """ Enable this to support the Rockchip MIPI Synopsys DPHY associated to the Rockchip ISP module present in RK3399 SoCs. To compile this driver as a module, choose M here: the module will be called phy-rockchip-dphy. """ And I believe the same improvement should be applied to the ISP driver Kconfig help. Thanks, Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com> To: Helen Koike <helen.koike@collabora.com>, linux-rockchip@lists.infradead.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, eddie.cai.linux@gmail.com, kernel@collabora.com, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, robh+dt@kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, joacim.zetterling@gmail.com, mchehab@kernel.org, andrey.konovalov@linaro.org, jacob-chen@iotwrt.com, linux-media@vger.kernel.org Subject: Re: [PATCH v12 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Date: Mon, 30 Dec 2019 15:25:10 -0300 [thread overview] Message-ID: <c6514f8e8bf49913e3cb907ba91c0a47de39e68c.camel@collabora.com> (raw) In-Reply-To: <20191227200116.2612137-2-helen.koike@collabora.com> Hi Helen, Thanks for taking care of this. On Fri, 2019-12-27 at 17:01 -0300, Helen Koike wrote: > From: Ezequiel Garcia <ezequiel@collabora.com> > > Add driver for Rockchip MIPI Synopsys DPHY driver > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > > --- > > Changes in v12: > - several cleanups > - remove "rx" from function names, as this driver only supports rx > > Changes in v11: > - fix checkpatch errors > > Changes in v10: None > Changes in v9: > - Move to staging > - replace memcpy by a directly assignment > - remove unecessary ret variable in rockchip_dphy_init > - s/0x1/1 > - s/0x0/0 > - coding style changes > - dphy_reg variable sizes > - variables from int to unsigned int > - rename functions to start with rk_ > - rename dphy0 to rx > - fix hardcoded lane0 usage > - disable rx on power off > - general cleanups of unused variables > > Changes in v8: > - Remove boiler plate license text > > Changes in v7: > - Migrate dphy specific code from > drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c > to drivers/phy/rockchip/phy-rockchip-dphy.c > - Drop support for rk3288 > - Drop support for dphy txrx > - code styling and checkpatch fixes > > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > .../staging/media/phy-rockchip-dphy/Kconfig | 11 + > .../staging/media/phy-rockchip-dphy/Makefile | 2 + > drivers/staging/media/phy-rockchip-dphy/TODO | 6 + > .../phy-rockchip-dphy/phy-rockchip-dphy.c | 396 ++++++++++++++++++ > 6 files changed, 418 insertions(+) > create mode 100644 drivers/staging/media/phy-rockchip-dphy/Kconfig > create mode 100644 drivers/staging/media/phy-rockchip-dphy/Makefile > create mode 100644 drivers/staging/media/phy-rockchip-dphy/TODO > create mode 100644 drivers/staging/media/phy-rockchip-dphy/phy-rockchip-dphy.c > > diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig > index 642adc4c24d2..a47484473883 100644 > --- a/drivers/staging/media/Kconfig > +++ b/drivers/staging/media/Kconfig > @@ -38,4 +38,6 @@ source "drivers/staging/media/ipu3/Kconfig" > > source "drivers/staging/media/soc_camera/Kconfig" > > +source "drivers/staging/media/phy-rockchip-dphy/Kconfig" > + > endif > diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile > index 2f1711a8aeed..b0eae3906208 100644 > --- a/drivers/staging/media/Makefile > +++ b/drivers/staging/media/Makefile > @@ -8,3 +8,4 @@ obj-$(CONFIG_TEGRA_VDE) += tegra-vde/ > obj-$(CONFIG_VIDEO_HANTRO) += hantro/ > obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3/ > obj-$(CONFIG_SOC_CAMERA) += soc_camera/ > +obj-$(CONFIG_PHY_ROCKCHIP_DPHY) += phy-rockchip-dphy/ > diff --git a/drivers/staging/media/phy-rockchip-dphy/Kconfig b/drivers/staging/media/phy-rockchip-dphy/Kconfig > new file mode 100644 > index 000000000000..7378bd75fa7c > --- /dev/null Seems I overlooked the Kconfig file for this driver, sorry about that! > +++ b/drivers/staging/media/phy-rockchip-dphy/Kconfig > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Phy drivers for Rockchip platforms > +# > +config PHY_ROCKCHIP_DPHY > + tristate "Rockchip MIPI Synopsys DPHY driver" > + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + select GENERIC_PHY_MIPI_DPHY > + select GENERIC_PHY > + help > + Enable this to support the Rockchip MIPI Synopsys DPHY. Following a more user-friendly convention, this should read more like: """ Enable this to support the Rockchip MIPI Synopsys DPHY associated to the Rockchip ISP module present in RK3399 SoCs. To compile this driver as a module, choose M here: the module will be called phy-rockchip-dphy. """ And I believe the same improvement should be applied to the ISP driver Kconfig help. Thanks, Ezequiel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-30 18:25 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 20:01 [PATCH v12 00/11] Rockchip ISP Driver Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-30 18:25 ` Ezequiel Garcia [this message] 2019-12-30 18:25 ` Ezequiel Garcia 2020-01-07 1:11 ` Laurent Pinchart 2020-01-07 1:11 ` Laurent Pinchart 2020-01-07 15:58 ` Ezequiel Garcia 2020-01-07 15:58 ` Ezequiel Garcia 2020-01-07 16:18 ` Laurent Pinchart 2020-01-07 16:18 ` Laurent Pinchart 2019-12-27 20:01 ` [PATCH v12 02/11] media: staging: rkisp1: add Rockchip ISP1 base driver Helen Koike 2019-12-30 18:13 ` Ezequiel Garcia 2019-12-30 18:13 ` Ezequiel Garcia 2019-12-27 20:01 ` [PATCH v12 03/11] media: staging: rkisp1: add streaming paths Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 04/11] media: staging: rkisp1: add user space ABI definitions Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 05/11] media: staging: rkisp1: add capture device for statistics Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 06/11] media: staging: rkisp1: add output device for parameters Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 07/11] media: staging: rkisp1: add document for rkisp1 meta buffer format Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings Helen Koike 2019-12-27 20:01 ` Helen Koike 2020-01-06 22:27 ` Rob Herring 2020-01-06 22:27 ` Rob Herring 2020-01-06 22:27 ` Rob Herring 2020-01-06 23:59 ` Laurent Pinchart 2020-01-06 23:59 ` Laurent Pinchart 2020-01-07 13:45 ` Ezequiel Garcia 2020-01-07 13:45 ` Ezequiel Garcia 2020-01-07 16:19 ` Laurent Pinchart 2020-01-07 16:19 ` Laurent Pinchart 2020-01-07 14:01 ` Sakari Ailus 2020-01-07 14:01 ` Sakari Ailus 2020-01-08 16:50 ` Helen Koike 2020-01-08 16:50 ` Helen Koike 2020-01-08 18:08 ` Sakari Ailus 2020-01-08 18:08 ` Sakari Ailus 2020-01-08 18:08 ` Sakari Ailus 2019-12-27 20:01 ` [PATCH v12 09/11] media: staging: dt-bindings: add Rockchip MIPI RX D-PHY " Helen Koike 2019-12-27 20:01 ` Helen Koike 2020-01-06 22:29 ` Rob Herring 2020-01-06 22:29 ` Rob Herring 2020-01-06 22:29 ` Rob Herring 2020-01-07 0:10 ` Laurent Pinchart 2020-01-07 0:10 ` Laurent Pinchart 2020-01-07 2:06 ` Ezequiel Garcia 2020-01-07 2:06 ` Ezequiel Garcia 2020-01-07 2:37 ` Laurent Pinchart 2020-01-07 2:37 ` Laurent Pinchart 2020-01-07 9:28 ` Heiko Stübner 2020-01-07 9:28 ` Heiko Stübner 2020-01-07 13:20 ` Ezequiel Garcia 2020-01-07 13:20 ` Ezequiel Garcia 2020-01-07 21:30 ` Heiko Stübner 2020-01-07 21:30 ` Heiko Stübner 2020-01-07 21:57 ` Laurent Pinchart 2020-01-07 21:57 ` Laurent Pinchart 2020-01-07 22:12 ` Heiko Stuebner 2020-01-07 22:12 ` Heiko Stuebner 2020-01-07 22:03 ` Ezequiel Garcia 2020-01-07 22:03 ` Ezequiel Garcia 2020-01-07 22:25 ` Heiko Stuebner 2020-01-07 22:25 ` Heiko Stuebner 2020-01-07 22:41 ` Ezequiel Garcia 2020-01-07 22:41 ` Ezequiel Garcia 2019-12-27 20:01 ` [PATCH v12 10/11] media: staging: rkisp1: add TODO file for staging Helen Koike 2019-12-27 20:01 ` Helen Koike 2019-12-27 20:01 ` [PATCH v12 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike 2019-12-27 20:01 ` Helen Koike
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c6514f8e8bf49913e3cb907ba91c0a47de39e68c.camel@collabora.com \ --to=ezequiel@collabora.com \ --cc=andrey.konovalov@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=eddie.cai.linux@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hans.verkuil@cisco.com \ --cc=heiko@sntech.de \ --cc=helen.koike@collabora.com \ --cc=jacob-chen@iotwrt.com \ --cc=joacim.zetterling@gmail.com \ --cc=kernel@collabora.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.