From: "Alastair D'Silva" <alastair@d-silva.org>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
Karsten Keil <isdn@linux-pingi.de>,
Jassi Brar <jassisinghbrar@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Kalle Valo <kvalo@codeaurora.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
David Laight <David.Laight@ACULAB.COM>,
Andrew Morton <akpm@linux-foundation.org>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Thu, 20 Jun 2019 09:15:58 +1000 [thread overview]
Message-ID: <c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org> (raw)
In-Reply-To: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com>
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote:
> On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
> > change
> > in those subsystems.
> >
> > This series enhances hexdump.
>
> Still not a fan of these patches.
I'm afraid there's not too much action I can take on that, I'm happy to
address specific issues though.
>
> > These improve the readability of the dumped data in certain
> > situations
> > (eg. wide terminals are available, many lines of empty bytes exist,
> > etc).
>
> Changing hexdump's last argument from bool to int is odd.
>
Think of it as replacing a single boolean with many booleans.
> Perhaps a new function should be added instead of changing
> the existing hexdump.
>
There's only a handful of consumers, I don't think there is a value-add
in creating more wrappers vs updating the existing callers.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
WARNING: multiple messages have this Message-ID (diff)
From: "Alastair D'Silva" <alastair@d-silva.org>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
Karsten Keil <isdn@linux-pingi.de>,
Jassi Brar <jassisinghbrar@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Kalle Valo <kvalo@codeaurora.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexa
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Wed, 19 Jun 2019 23:15:58 +0000 [thread overview]
Message-ID: <c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org> (raw)
In-Reply-To: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com>
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote:
> On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
> > change
> > in those subsystems.
> >
> > This series enhances hexdump.
>
> Still not a fan of these patches.
I'm afraid there's not too much action I can take on that, I'm happy to
address specific issues though.
>
> > These improve the readability of the dumped data in certain
> > situations
> > (eg. wide terminals are available, many lines of empty bytes exist,
> > etc).
>
> Changing hexdump's last argument from bool to int is odd.
>
Think of it as replacing a single boolean with many booleans.
> Perhaps a new function should be added instead of changing
> the existing hexdump.
>
There's only a handful of consumers, I don't think there is a value-add
in creating more wrappers vs updating the existing callers.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
WARNING: multiple messages have this Message-ID (diff)
From: "Alastair D'Silva" <alastair@d-silva.org>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
Karsten Keil <isdn@linux-pingi.de>,
Jassi Brar <jassisinghbrar@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Kalle Valo <kvalo@codeaurora.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexa
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Thu, 20 Jun 2019 09:15:58 +1000 [thread overview]
Message-ID: <c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org> (raw)
In-Reply-To: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com>
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote:
> On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
> > change
> > in those subsystems.
> >
> > This series enhances hexdump.
>
> Still not a fan of these patches.
I'm afraid there's not too much action I can take on that, I'm happy to
address specific issues though.
>
> > These improve the readability of the dumped data in certain
> > situations
> > (eg. wide terminals are available, many lines of empty bytes exist,
> > etc).
>
> Changing hexdump's last argument from bool to int is odd.
>
Think of it as replacing a single boolean with many booleans.
> Perhaps a new function should be added instead of changing
> the existing hexdump.
>
There's only a handful of consumers, I don't think there is a value-add
in creating more wrappers vs updating the existing callers.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
WARNING: multiple messages have this Message-ID (diff)
From: "Alastair D'Silva" <alastair@d-silva.org>
To: Joe Perches <joe@perches.com>
Cc: linux-fbdev@vger.kernel.org,
Stanislaw Gruszka <sgruszka@redhat.com>,
Petr Mladek <pmladek@suse.com>, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
linux-scsi@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>,
ath10k@lists.infradead.org, intel-gfx@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-fsdevel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Benson Leung <bleung@chromium.org>,
Kalle Valo <kvalo@codeaurora.org>,
Karsten Keil <isdn@linux-pingi.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
David Laight <David.Laight@ACULAB.COM>,
Daniel Vetter <daniel@ffwll.ch>,
netdev@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Thu, 20 Jun 2019 09:15:58 +1000 [thread overview]
Message-ID: <c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org> (raw)
In-Reply-To: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com>
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote:
> On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
> > change
> > in those subsystems.
> >
> > This series enhances hexdump.
>
> Still not a fan of these patches.
I'm afraid there's not too much action I can take on that, I'm happy to
address specific issues though.
>
> > These improve the readability of the dumped data in certain
> > situations
> > (eg. wide terminals are available, many lines of empty bytes exist,
> > etc).
>
> Changing hexdump's last argument from bool to int is odd.
>
Think of it as replacing a single boolean with many booleans.
> Perhaps a new function should be added instead of changing
> the existing hexdump.
>
There's only a handful of consumers, I don't think there is a value-add
in creating more wrappers vs updating the existing callers.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Alastair D'Silva" <alastair@d-silva.org>
To: Joe Perches <joe@perches.com>
Cc: linux-fbdev@vger.kernel.org,
Stanislaw Gruszka <sgruszka@redhat.com>,
Petr Mladek <pmladek@suse.com>, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
linux-scsi@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>,
ath10k@lists.infradead.org, intel-gfx@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-fsdevel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Benson Leung <bleung@chromium.org>,
Kalle Valo <kvalo@codeaurora.org>,
Karsten Keil <isdn@linux-pingi.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
David Laight <David.Laight@ACULAB.COM>,
Daniel Vetter <daniel@ffwll.ch>,
netdev@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Thu, 20 Jun 2019 09:15:58 +1000 [thread overview]
Message-ID: <c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org> (raw)
In-Reply-To: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com>
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote:
> On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
> > change
> > in those subsystems.
> >
> > This series enhances hexdump.
>
> Still not a fan of these patches.
I'm afraid there's not too much action I can take on that, I'm happy to
address specific issues though.
>
> > These improve the readability of the dumped data in certain
> > situations
> > (eg. wide terminals are available, many lines of empty bytes exist,
> > etc).
>
> Changing hexdump's last argument from bool to int is odd.
>
Think of it as replacing a single boolean with many booleans.
> Perhaps a new function should be added instead of changing
> the existing hexdump.
>
There's only a handful of consumers, I don't think there is a value-add
in creating more wrappers vs updating the existing callers.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-06-19 23:16 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 2:04 [PATCH v3 0/7] Hexdump Enhancements Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 1/7] lib/hexdump.c: Fix selftests Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 22:47 ` Randy Dunlap
2019-06-17 22:47 ` Randy Dunlap
2019-06-17 22:47 ` Randy Dunlap
2019-06-17 22:47 ` Randy Dunlap
2019-06-18 0:57 ` Alastair D'Silva
2019-06-18 0:57 ` Alastair D'Silva
2019-06-18 0:57 ` Alastair D'Silva
2019-06-18 0:57 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 4:07 ` Alastair D'Silva
2019-06-17 4:07 ` Alastair D'Silva
2019-06-17 4:07 ` Alastair D'Silva
2019-06-17 4:07 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 7:39 ` Jani Nikula
2019-06-17 7:39 ` Jani Nikula
2019-06-17 7:39 ` Jani Nikula
2019-06-17 7:39 ` Jani Nikula
2019-06-17 2:04 ` [PATCH v3 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|' Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 6/7] lib/hexdump.c: Allow multiple groups to be separated by spaces Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 7/7] lib/hexdump.c: Optionally retain byte ordering Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-17 2:04 ` Alastair D'Silva
2019-06-19 16:31 ` [PATCH v3 0/7] Hexdump Enhancements Joe Perches
2019-06-19 16:31 ` Joe Perches
2019-06-19 16:31 ` Joe Perches
2019-06-19 16:31 ` Joe Perches
2019-06-19 23:15 ` Alastair D'Silva [this message]
2019-06-19 23:15 ` Alastair D'Silva
2019-06-19 23:15 ` Alastair D'Silva
2019-06-19 23:15 ` Alastair D'Silva
2019-06-19 23:15 ` Alastair D'Silva
2019-06-20 0:35 ` Joe Perches
2019-06-20 0:35 ` Joe Perches
2019-06-20 0:35 ` Joe Perches
2019-06-20 0:35 ` Joe Perches
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 2:00 ` Joe Perches
2019-06-20 2:00 ` Joe Perches
2019-06-20 2:00 ` Joe Perches
2019-06-20 2:00 ` Joe Perches
2019-06-20 2:00 ` Joe Perches
2019-06-20 10:50 ` Jani Nikula
2019-06-20 10:50 ` Jani Nikula
2019-06-20 10:50 ` Jani Nikula
2019-06-20 10:50 ` Jani Nikula
2019-06-20 10:50 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68cb819257f251cbb66f8998a95c31cebe2d72e.camel@d-silva.org \
--to=alastair@d-silva.org \
--cc=David.Laight@ACULAB.COM \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=ath10k@lists.infradead.org \
--cc=bleung@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=isdn@linux-pingi.de \
--cc=jani.nikula@linux.intel.com \
--cc=jassisinghbrar@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sgruszka@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.