From: Jani Nikula <jani.nikula@intel.com> To: dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org Subject: [PATCH v2 15/15] drm/todo: add entry for converting the subsystem to struct drm_edid Date: Wed, 8 Jun 2022 10:50:45 +0300 [thread overview] Message-ID: <c6b45097910d806c25c346ecbe9894cab58f9956.1654674560.git.jani.nikula@intel.com> (raw) In-Reply-To: <cover.1654674560.git.jani.nikula@intel.com> We need to stop duplicating EDID validation and parsing all over the subsystem in various broken ways. v2: Update to reflect drm_connector_helper_get_modes() Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Documentation/gpu/todo.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 513b20ccef1e..04ef31e3405f 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -480,6 +480,31 @@ Contact: Thomas Zimmermann <tzimmermann@suse.de> Level: Starter +Convert core and drivers from struct edid to struct drm_edid +------------------------------------------------------------ + +Go through all drivers and drm core KMS code to convert all raw struct edid +usage to the opaque struct drm_edid. See commit e4ccf9a777d3 ("drm/edid: add +struct drm_edid container") for rationale. + +Convert drm_get_edid() and drm_do_get_edid() usage to drm_edid_read(), +drm_edid_read_ddc(), or drm_edid_read_custom(). + +Convert drm_add_edid_modes() and drm_connector_update_edid_property() to +drm_edid_connector_update(). See drm_connector_helper_get_modes() for reference +for converting the ->get_modes() hooks. + +Convert decentralized, direct struct edid parsing to centralized parsing in +drm_edid.c. Prefer one-time parsing as part of drm_edid_connector_update() and +storing the result in drm_connector->display_info over adding individual, +exported parser functions. + +During the transition period, it may be necessary to use drm_edid_raw(), but do +use it sparingly. Eventually, all of them need to go. + +Contact: Jani Nikula <jani.nikula@intel.com> + +Level: Intermediate Core refactorings ================= -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com> To: dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2 15/15] drm/todo: add entry for converting the subsystem to struct drm_edid Date: Wed, 8 Jun 2022 10:50:45 +0300 [thread overview] Message-ID: <c6b45097910d806c25c346ecbe9894cab58f9956.1654674560.git.jani.nikula@intel.com> (raw) In-Reply-To: <cover.1654674560.git.jani.nikula@intel.com> We need to stop duplicating EDID validation and parsing all over the subsystem in various broken ways. v2: Update to reflect drm_connector_helper_get_modes() Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Documentation/gpu/todo.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 513b20ccef1e..04ef31e3405f 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -480,6 +480,31 @@ Contact: Thomas Zimmermann <tzimmermann@suse.de> Level: Starter +Convert core and drivers from struct edid to struct drm_edid +------------------------------------------------------------ + +Go through all drivers and drm core KMS code to convert all raw struct edid +usage to the opaque struct drm_edid. See commit e4ccf9a777d3 ("drm/edid: add +struct drm_edid container") for rationale. + +Convert drm_get_edid() and drm_do_get_edid() usage to drm_edid_read(), +drm_edid_read_ddc(), or drm_edid_read_custom(). + +Convert drm_add_edid_modes() and drm_connector_update_edid_property() to +drm_edid_connector_update(). See drm_connector_helper_get_modes() for reference +for converting the ->get_modes() hooks. + +Convert decentralized, direct struct edid parsing to centralized parsing in +drm_edid.c. Prefer one-time parsing as part of drm_edid_connector_update() and +storing the result in drm_connector->display_info over adding individual, +exported parser functions. + +During the transition period, it may be necessary to use drm_edid_raw(), but do +use it sparingly. Eventually, all of them need to go. + +Contact: Jani Nikula <jani.nikula@intel.com> + +Level: Intermediate Core refactorings ================= -- 2.30.2
next prev parent reply other threads:[~2022-06-08 7:51 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-08 7:50 [PATCH v2 00/15] drm/edid: expand on struct drm_edid usage Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-08 7:50 ` [PATCH v2 01/15] drm/edid: fix CTA data block collection size for CTA version 3 Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 18:56 ` Ville Syrjälä 2022-06-10 18:56 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 02/15] drm/edid: abstract cea data block collection size Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 18:58 ` Ville Syrjälä 2022-06-10 18:58 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 03/15] drm/edid: add block count and data helper functions for drm_edid Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-08 7:50 ` [PATCH v2 04/15] drm/edid: keep track of alloc size in drm_do_get_edid() Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:35 ` Ville Syrjälä 2022-06-10 19:35 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 05/15] drm/edid: add new interfaces around struct drm_edid Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:35 ` Ville Syrjälä 2022-06-10 19:35 ` [Intel-gfx] " Ville Syrjälä 2022-06-10 19:43 ` Ville Syrjälä 2022-06-10 19:43 ` [Intel-gfx] " Ville Syrjälä 2022-06-13 8:37 ` Jani Nikula 2022-06-13 8:37 ` [Intel-gfx] " Jani Nikula 2022-06-08 7:50 ` [PATCH v2 06/15] drm/edid: add drm_edid_connector_update() Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:15 ` Ville Syrjälä 2022-06-10 19:15 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 07/15] drm/probe-helper: abstract .get_modes() connector helper call Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:36 ` Ville Syrjälä 2022-06-10 19:36 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 08/15] drm/probe-helper: add drm_connector_helper_get_modes() Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:44 ` Ville Syrjälä 2022-06-10 19:44 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 09/15] drm/edid: add drm_edid_raw() to access the raw EDID data Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:29 ` Ville Syrjälä 2022-06-10 19:29 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 10/15] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:21 ` Ville Syrjälä 2022-06-10 19:21 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 11/15] drm/i915/bios: convert intel_bios_init_panel() " Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:29 ` Ville Syrjälä 2022-06-10 19:29 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 12/15] drm/edid: do invalid block filtering in-place Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:30 ` Ville Syrjälä 2022-06-10 19:30 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 13/15] drm/edid: add HF-EEODB support to EDID read and allocation Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:30 ` Ville Syrjälä 2022-06-10 19:30 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` [PATCH v2 14/15] drm/edid: take HF-EEODB extension count into account Jani Nikula 2022-06-08 7:50 ` [Intel-gfx] " Jani Nikula 2022-06-10 19:34 ` Ville Syrjälä 2022-06-10 19:34 ` [Intel-gfx] " Ville Syrjälä 2022-06-08 7:50 ` Jani Nikula [this message] 2022-06-08 7:50 ` [Intel-gfx] [PATCH v2 15/15] drm/todo: add entry for converting the subsystem to struct drm_edid Jani Nikula 2022-06-08 8:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: expand on struct drm_edid usage (rev3) Patchwork 2022-06-08 8:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-06-08 11:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-06-08 19:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-06-13 9:37 ` [PATCH v2 00/15] drm/edid: expand on struct drm_edid usage Jani Nikula 2022-06-13 9:37 ` [Intel-gfx] " Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c6b45097910d806c25c346ecbe9894cab58f9956.1654674560.git.jani.nikula@intel.com \ --to=jani.nikula@intel.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.