From: Neil Armstrong <narmstrong@baylibre.com>
To: Fabio Estevam <festevam@denx.de>, martin.blumenstingl@googlemail.com
Cc: linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
Date: Mon, 29 Aug 2022 09:37:37 +0200 [thread overview]
Message-ID: <c6ef3060-3576-602d-25e7-b0a7afbbbb56@baylibre.com> (raw)
In-Reply-To: <20220827203813.1742715-1-festevam@denx.de>
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
>
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index b4e86196e346..b2bb94981838 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -111,7 +111,6 @@ vcc_5v: regulator-vcc_5v {
> vin-supply = <&dc_in>;
>
> gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> - enable-active-low;
> };
>
> vddao_1v8: regulator-vddao_1v8 {
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Fabio Estevam <festevam@denx.de>, martin.blumenstingl@googlemail.com
Cc: linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
Date: Mon, 29 Aug 2022 09:37:37 +0200 [thread overview]
Message-ID: <c6ef3060-3576-602d-25e7-b0a7afbbbb56@baylibre.com> (raw)
In-Reply-To: <20220827203813.1742715-1-festevam@denx.de>
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
>
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index b4e86196e346..b2bb94981838 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -111,7 +111,6 @@ vcc_5v: regulator-vcc_5v {
> vin-supply = <&dc_in>;
>
> gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> - enable-active-low;
> };
>
> vddao_1v8: regulator-vddao_1v8 {
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-29 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
2022-08-27 20:38 ` Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
2022-08-27 20:38 ` Fabio Estevam
2022-08-29 7:37 ` Neil Armstrong
2022-08-29 7:37 ` Neil Armstrong
2022-08-29 7:37 ` Neil Armstrong [this message]
2022-08-29 7:37 ` [PATCH v2 1/2] arm64: dts: meson-g12a: " Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ef3060-3576-602d-25e7-b0a7afbbbb56@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=festevam@denx.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.