All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org, zohar@linux.vnet.ibm.com,
	jgg@ziepe.ca, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] tpm: Implement tpm_chip_find() and tpm_chip_put() for other subsystems
Date: Thu, 21 Jun 2018 13:27:33 -0400	[thread overview]
Message-ID: <c74308ff-9fd1-1779-0432-e7cacbed769f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180621171518.GI11859@linux.intel.com>

On 06/21/2018 01:15 PM, Jarkko Sakkinen wrote:
> On Wed, Jun 20, 2018 at 04:42:33PM -0400, Stefan Berger wrote:
>> Implement tpm_chip_find() for other subsystems to find a TPM chip and
>> get a reference to that chip. Once done with using the chip, the reference
>> is released using tpm_chip_put().
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> You should sort this out in a way that we don't end up with duplicate
> functions.

We cannot hold the ops_sem semaphore for a long time. So we need a 
function that gets us a reference and doesn't hold the ops semaphore and 
that's where this tpm_chip_find() comes from.

    Stefan

> /Jarkko
>


WARNING: multiple messages have this Message-ID (diff)
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org, zohar@linux.vnet.ibm.com,
	jgg@ziepe.ca, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] tpm: Implement tpm_chip_find() and tpm_chip_put() for other subsystems
Date: Thu, 21 Jun 2018 13:27:33 -0400	[thread overview]
Message-ID: <c74308ff-9fd1-1779-0432-e7cacbed769f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180621171518.GI11859@linux.intel.com>

On 06/21/2018 01:15 PM, Jarkko Sakkinen wrote:
> On Wed, Jun 20, 2018 at 04:42:33PM -0400, Stefan Berger wrote:
>> Implement tpm_chip_find() for other subsystems to find a TPM chip and
>> get a reference to that chip. Once done with using the chip, the reference
>> is released using tpm_chip_put().
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> You should sort this out in a way that we don't end up with duplicate
> functions.

We cannot hold the ops_sem semaphore for a long time. So we need a 
function that gets us a reference and doesn't hold the ops semaphore and 
that's where this tpm_chip_find() comes from.

    Stefan

> /Jarkko
>

  reply	other threads:[~2018-06-21 17:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 20:42 [PATCH v2 0/4] Have IMA find and use a tpm_chip until system shutdown Stefan Berger
2018-06-20 20:42 ` [PATCH v2 1/4] tpm: Implement tpm_chip_find() and tpm_chip_put() for other subsystems Stefan Berger
2018-06-20 20:50   ` Jason Gunthorpe
2018-06-20 21:13     ` Stefan Berger
2018-06-20 21:13       ` Stefan Berger
2018-06-21 17:13     ` Jarkko Sakkinen
2018-06-21 17:15   ` Jarkko Sakkinen
2018-06-21 17:27     ` Stefan Berger [this message]
2018-06-21 17:27       ` Stefan Berger
2018-06-21 17:45     ` Stefan Berger
2018-06-21 17:45       ` Stefan Berger
2018-06-21 17:56       ` Jason Gunthorpe
2018-06-21 18:19         ` Stefan Berger
2018-06-21 18:19           ` Stefan Berger
2018-06-21 19:06           ` Jason Gunthorpe
2018-06-21 20:14             ` Stefan Berger
2018-06-21 20:51               ` Jason Gunthorpe
2018-06-20 20:42 ` [PATCH v2 2/4] ima: Implement ima_shutdown and register it as a reboot_notifier Stefan Berger
2018-06-20 20:42 ` [PATCH v2 3/4] ima: Use tpm_chip_find() and access TPM functions using it Stefan Berger
2018-06-21 20:53   ` Mimi Zohar
2018-06-21 20:53     ` Mimi Zohar
2018-06-21 20:59     ` Stefan Berger
2018-06-21 20:59       ` Stefan Berger
2018-06-22  3:25       ` Jason Gunthorpe
2018-06-22  3:25         ` Jason Gunthorpe
2018-06-22 11:40         ` Stefan Berger
2018-06-22 11:40           ` Stefan Berger
2018-06-22 14:19           ` Jason Gunthorpe
2018-06-22 14:19             ` Jason Gunthorpe
2018-06-20 20:42 ` [PATCH v2 4/4] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c74308ff-9fd1-1779-0432-e7cacbed769f@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.